Joshua Nelson 31e39446ec Stabilize #![feature(label_break_value)] ... # Stabilization proposal The feature was implemented in https://github.com/rust-lang/rust/pull/50045 by est31 and has been in nightly since 2018-05-16 (over 4 years now). There are [no open issues][issue-label] other than the tracking issue. There is a strong consensus that `break` is the right keyword and we should not use `return`. There have been several concerns raised about this feature on the tracking issue (other than the one about tests, which has been fixed, and an interaction with try blocks, which has been fixed). 1. nrc's original comment about cost-benefit analysis: https://github.com/rust-lang/rust/issues/48594#issuecomment-422235234 2. joshtriplett's comments about seeing use cases: https://github.com/rust-lang/rust/issues/48594#issuecomment-422281176 3. withoutboats's comments that Rust does not need more control flow constructs: https://github.com/rust-lang/rust/issues/48594#issuecomment-450050630 Many different examples of code that's simpler using this feature have been provided: - A lexer by rpjohnst which must repeat code without label-break-value: https://github.com/rust-lang/rust/issues/48594#issuecomment-422502014 - A snippet by SergioBenitez which avoids using a new function and adding several new return points to a function: https://github.com/rust-lang/rust/issues/48594#issuecomment-427628251. This particular case would also work if `try` blocks were stabilized (at the cost of making the code harder to optimize). - Several examples by JohnBSmith: https://github.com/rust-lang/rust/issues/48594#issuecomment-434651395 - Several examples by Centril: https://github.com/rust-lang/rust/issues/48594#issuecomment-440154733 - An example by petrochenkov where this is used in the compiler itself to avoid duplicating error checking code: https://github.com/rust-lang/rust/issues/48594#issuecomment-443557569 - Amanieu recently provided another example related to complex conditions, where try blocks would not have helped: https://github.com/rust-lang/rust/issues/48594#issuecomment-1184213006 Additionally, petrochenkov notes that this is strictly more powerful than labelled loops due to macros which accidentally exit a loop instead of being consumed by the macro matchers: https://github.com/rust-lang/rust/issues/48594#issuecomment-450246249 nrc later resolved their concern, mostly because of the aforementioned macro problems. joshtriplett suggested that macros could be able to generate IR directly (https://github.com/rust-lang/rust/issues/48594#issuecomment-451685983) but there are no open RFCs, and the design space seems rather speculative. joshtriplett later resolved his concerns, due to a symmetry between this feature and existing labelled break: https://github.com/rust-lang/rust/issues/48594#issuecomment-632960804 withoutboats has regrettably left the language team. joshtriplett later posted that the lang team would consider starting an FCP given a stabilization report: https://github.com/rust-lang/rust/issues/48594#issuecomment-1111269353 [issue-label]: https://github.com/rust-lang/rust/issues?q=is%3Aissue+is%3Aopen+label%3AF-label_break_value+ ## Report + Feature gate: - d695a497bb/src/test/ui/feature-gates/feature-gate-label_break_value.rs + Diagnostics: - 6b2d3d5f3c/compiler/rustc_parse/src/parser/diagnostics.rs (L2629) - f65bf0b2bb/compiler/rustc_resolve/src/diagnostics.rs (L749) - f65bf0b2bb/compiler/rustc_resolve/src/diagnostics.rs (L1001) - 111df9e6ed/compiler/rustc_passes/src/loops.rs (L254) - d695a497bb/compiler/rustc_parse/src/parser/expr.rs (L2079) - d695a497bb/compiler/rustc_parse/src/parser/expr.rs (L1569) + Tests: - https://github.com/rust-lang/rust/blob/master/src/test/ui/label/label_break_value_continue.rs - https://github.com/rust-lang/rust/blob/master/src/test/ui/label/label_break_value_unlabeled_break.rs - https://github.com/rust-lang/rust/blob/master/src/test/ui/label/label_break_value_illegal_uses.rs - https://github.com/rust-lang/rust/blob/master/src/test/ui/lint/unused_labels.rs - https://github.com/rust-lang/rust/blob/master/src/test/ui/run-pass/for-loop-while/label_break_value.rs ## Interactions with other features Labels follow the hygiene of local variables. label-break-value is permitted within `try` blocks: ```rust let _: Result<(), ()> = try { 'foo: { Err(())?; break 'foo; } }; ``` label-break-value is disallowed within closures, generators, and async blocks: ```rust 'a: { || break 'a //~^ ERROR use of unreachable label `'a` //~| ERROR `break` inside of a closure } ``` label-break-value is disallowed on [_BlockExpression_]; it can only occur as a [_LoopExpression_]: ```rust fn labeled_match() { match false 'b: { //~ ERROR block label not supported here _ => {} } } macro_rules! m { ($b:block) => { 'lab: $b; //~ ERROR cannot use a `block` macro fragment here unsafe $b; //~ ERROR cannot use a `block` macro fragment here |x: u8| -> () $b; //~ ERROR cannot use a `block` macro fragment here } } fn foo() { m!({}); } ``` [_BlockExpression_]: https://doc.rust-lang.org/nightly/reference/expressions/block-expr.html [_LoopExpression_]: https://doc.rust-lang.org/nightly/reference/expressions/loop-expr.html		2022-08-23 21:14:12 -05:00
..
E0001.md
E0002.md
E0004.md
E0005.md
E0007.md
E0009.md
E0010.md
E0013.md
E0014.md
E0015.md
E0023.md
E0025.md
E0026.md
E0027.md
E0029.md
E0030.md
E0033.md
E0034.md
E0038.md
E0040.md
E0044.md
E0045.md
E0046.md
E0049.md
E0050.md
E0053.md
E0054.md
E0055.md
E0057.md
E0059.md
E0060.md	Stabilize the bundle native library modifier	2022-06-09 23:12:58 +04:00
E0061.md
E0062.md
E0063.md
E0067.md
E0069.md
E0070.md
E0071.md
E0072.md
E0073.md
E0074.md
E0075.md
E0076.md
E0077.md
E0080.md
E0081.md
E0084.md
E0087.md
E0088.md
E0089.md
E0090.md
E0091.md
E0092.md
E0093.md	Rename/restructure memory ordering intrinsics.	2022-06-28 08:58:27 +02:00
E0094.md
E0106.md
E0107.md
E0109.md
E0110.md
E0116.md
E0117.md
E0118.md	Improve the function pointer docs	2022-07-19 08:52:24 -07:00
E0119.md
E0120.md
E0121.md
E0124.md
E0128.md
E0130.md
E0131.md
E0132.md
E0133.md
E0136.md
E0137.md
E0138.md
E0139.md
E0152.md
E0154.md
E0158.md
E0161.md
E0162.md
E0164.md
E0165.md
E0170.md
E0178.md
E0183.md
E0184.md
E0185.md
E0186.md
E0191.md
E0192.md
E0193.md
E0195.md
E0197.md
E0198.md
E0199.md
E0200.md
E0201.md
E0203.md
E0204.md
E0205.md
E0206.md
E0207.md
E0210.md
E0211.md
E0212.md
E0214.md
E0220.md
E0221.md
E0222.md
E0223.md
E0224.md
E0225.md
E0226.md
E0227.md
E0228.md
E0229.md
E0230.md
E0231.md
E0232.md
E0243.md
E0244.md
E0251.md
E0252.md
E0253.md
E0254.md
E0255.md
E0256.md
E0259.md
E0260.md
E0261.md
E0262.md
E0263.md	Use the same message as type & const generics.	2022-06-03 08:26:10 +02:00
E0264.md
E0267.md
E0268.md
E0271.md
E0275.md
E0276.md
E0277.md
E0281.md
E0282.md
E0283.md	Don't use main; improve example	2022-07-19 10:23:34 +02:00
E0284.md
E0297.md
E0301.md
E0302.md
E0303.md
E0307.md
E0308.md
E0309.md
E0310.md
E0312.md	Fully stabilize NLL	2022-06-03 17:16:41 -04:00
E0316.md
E0317.md
E0321.md
E0322.md
E0323.md
E0324.md
E0325.md
E0326.md
E0328.md
E0329.md
E0364.md
E0365.md
E0366.md
E0367.md
E0368.md
E0369.md
E0370.md
E0371.md
E0373.md
E0374.md
E0375.md
E0376.md
E0378.md
E0379.md
E0380.md
E0381.md
E0382.md
E0383.md
E0384.md
E0386.md
E0387.md
E0388.md
E0389.md
E0390.md
E0391.md
E0392.md
E0393.md
E0398.md
E0399.md
E0401.md
E0403.md
E0404.md
E0405.md
E0407.md
E0408.md
E0409.md
E0411.md
E0412.md
E0415.md
E0416.md
E0422.md
E0423.md
E0424.md
E0425.md
E0426.md
E0428.md
E0429.md
E0430.md
E0431.md
E0432.md	E0432: rust 2018 -> rust 2018 or later in --explain message	2022-06-06 11:58:49 +02:00
E0433.md
E0434.md
E0435.md
E0436.md
E0437.md
E0438.md
E0439.md
E0445.md
E0446.md
E0447.md
E0448.md
E0449.md
E0451.md	Fixed several error_codes/Exxxx.md messages which used UpperCamelCase instead of snake_case for module names	2022-06-10 11:25:47 +01:00
E0452.md
E0453.md
E0454.md
E0455.md	rustc: Stricter checking for #[link] attributes	2022-05-15 02:45:47 +03:00
E0458.md	rustc: Stricter checking for #[link] attributes	2022-05-15 02:45:47 +03:00
E0459.md
E0463.md
E0464.md
E0466.md
E0468.md
E0469.md
E0477.md	Fully stabilize NLL	2022-06-03 17:16:41 -04:00
E0478.md
E0482.md
E0491.md
E0492.md
E0493.md
E0495.md	Fully stabilize NLL	2022-06-03 17:16:41 -04:00
E0496.md
E0497.md
E0498.md
E0499.md
E0500.md
E0501.md
E0502.md
E0503.md
E0504.md
E0505.md
E0506.md
E0507.md
E0508.md
E0509.md
E0510.md
E0511.md
E0512.md
E0515.md
E0516.md
E0517.md
E0518.md
E0520.md
E0521.md
E0522.md
E0524.md
E0525.md
E0527.md
E0528.md
E0529.md
E0530.md
E0531.md
E0532.md
E0533.md
E0534.md
E0535.md
E0536.md
E0537.md
E0538.md
E0539.md
E0541.md
E0542.md
E0543.md
E0544.md
E0545.md
E0546.md
E0547.md
E0549.md
E0550.md
E0551.md
E0552.md
E0554.md
E0556.md
E0557.md
E0559.md
E0560.md
E0561.md
E0562.md
E0565.md
E0566.md
E0567.md
E0568.md
E0569.md
E0570.md
E0571.md
E0572.md
E0573.md
E0574.md	Fixed several error_codes/Exxxx.md messages which used UpperCamelCase instead of snake_case for module names	2022-06-10 11:25:47 +01:00
E0575.md
E0576.md
E0577.md	E0577 fixed Sea struct CamelCase/sea module snake_case	2022-06-10 14:21:40 +01:00
E0578.md
E0579.md
E0580.md
E0581.md
E0582.md
E0583.md
E0584.md
E0585.md
E0586.md
E0587.md
E0588.md
E0589.md
E0590.md
E0591.md
E0592.md
E0593.md
E0594.md
E0595.md
E0596.md
E0597.md
E0599.md
E0600.md
E0601.md
E0602.md
E0603.md	Fixed several error_codes/Exxxx.md messages which used UpperCamelCase instead of snake_case for module names	2022-06-10 11:25:47 +01:00
E0604.md
E0605.md
E0606.md
E0607.md
E0608.md
E0609.md
E0610.md
E0614.md
E0615.md
E0616.md
E0617.md
E0618.md
E0619.md
E0620.md
E0621.md
E0622.md
E0623.md	Fully stabilize NLL	2022-06-03 17:16:41 -04:00
E0624.md
E0625.md
E0626.md
E0627.md
E0628.md
E0631.md
E0632.md	Deactivate feature gate explicit_generic_args_with_impl_trait	2022-06-06 12:21:49 +01:00
E0633.md
E0634.md
E0635.md
E0636.md
E0637.md
E0638.md
E0639.md
E0641.md
E0642.md
E0643.md
E0644.md
E0646.md
E0647.md
E0648.md
E0657.md
E0658.md
E0659.md
E0660.md
E0661.md
E0662.md
E0663.md
E0664.md
E0665.md
E0666.md
E0667.md
E0668.md
E0669.md
E0670.md
E0671.md
E0687.md
E0688.md
E0689.md
E0690.md
E0691.md
E0692.md
E0693.md
E0695.md	Stabilize #![feature(label_break_value)]	2022-08-23 21:14:12 -05:00
E0696.md
E0697.md
E0698.md
E0699.md
E0700.md
E0701.md
E0703.md
E0704.md
E0705.md
E0706.md
E0708.md
E0710.md
E0712.md
E0713.md	Fully stabilize NLL	2022-06-03 17:16:41 -04:00
E0714.md
E0715.md
E0716.md
E0718.md
E0719.md
E0720.md
E0722.md
E0724.md
E0725.md
E0726.md
E0727.md
E0728.md
E0729.md
E0730.md
E0731.md
E0732.md
E0733.md
E0734.md
E0735.md
E0736.md
E0737.md
E0739.md
E0740.md
E0741.md
E0742.md	Fixed several error_codes/Exxxx.md messages which used UpperCamelCase instead of snake_case for module names	2022-06-10 11:25:47 +01:00
E0743.md
E0744.md
E0745.md
E0746.md
E0747.md
E0748.md
E0749.md
E0750.md
E0751.md
E0752.md
E0753.md
E0754.md
E0755.md
E0756.md
E0757.md
E0758.md
E0759.md	Fully stabilize NLL	2022-06-03 17:16:41 -04:00
E0760.md
E0761.md
E0762.md
E0763.md
E0764.md
E0765.md
E0766.md
E0767.md
E0768.md
E0769.md
E0770.md
E0771.md
E0772.md	Fully stabilize NLL	2022-06-03 17:16:41 -04:00
E0773.md
E0774.md
E0775.md
E0776.md
E0777.md
E0778.md
E0779.md
E0780.md
E0781.md
E0782.md
E0783.md
E0784.md
E0785.md
E0786.md
E0787.md
E0788.md	Changes from code review	2022-06-05 22:24:14 -04:00
E0790.md	Don't use main; improve example	2022-07-19 10:23:34 +02:00