e7724a2e31
And make all hand-written `IntoDiagnostic` impls generic, by using `DiagnosticBuilder::new(dcx, level, ...)` instead of e.g. `dcx.struct_err(...)`. This means the `create_*` functions are the source of the error level. This change will let us remove `struct_diagnostic`. Note: `#[rustc_lint_diagnostics]` is added to `DiagnosticBuilder::new`, it's necessary to pass diagnostics tests now that it's used in `into_diagnostic` functions.
45 lines
1.4 KiB
Plaintext
45 lines
1.4 KiB
Plaintext
error: diagnostics should be created using translatable messages
|
|
--> $DIR/diagnostics.rs:42:9
|
|
|
|
|
LL | DiagnosticBuilder::new(dcx, level, "untranslatable diagnostic")
|
|
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
note: the lint level is defined here
|
|
--> $DIR/diagnostics.rs:6:9
|
|
|
|
|
LL | #![deny(rustc::untranslatable_diagnostic)]
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: diagnostics should be created using translatable messages
|
|
--> $DIR/diagnostics.rs:62:14
|
|
|
|
|
LL | diag.note("untranslatable diagnostic");
|
|
| ^^^^
|
|
|
|
error: diagnostics should only be created in `IntoDiagnostic`/`AddToDiagnostic` impls
|
|
--> $DIR/diagnostics.rs:79:21
|
|
|
|
|
LL | let _diag = dcx.struct_err(crate::fluent_generated::no_crate_example);
|
|
| ^^^^^^^^^^
|
|
|
|
|
note: the lint level is defined here
|
|
--> $DIR/diagnostics.rs:7:9
|
|
|
|
|
LL | #![deny(rustc::diagnostic_outside_of_impl)]
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: diagnostics should only be created in `IntoDiagnostic`/`AddToDiagnostic` impls
|
|
--> $DIR/diagnostics.rs:82:21
|
|
|
|
|
LL | let _diag = dcx.struct_err("untranslatable diagnostic");
|
|
| ^^^^^^^^^^
|
|
|
|
error: diagnostics should be created using translatable messages
|
|
--> $DIR/diagnostics.rs:82:21
|
|
|
|
|
LL | let _diag = dcx.struct_err("untranslatable diagnostic");
|
|
| ^^^^^^^^^^
|
|
|
|
error: aborting due to 5 previous errors
|
|
|