32d0dbd49a
enumerations that implement the `Drop` trait.
This breaks code like:
struct Struct {
f: String,
g: String,
}
impl Drop for Struct { ... }
fn main() {
let x = Struct { ... };
drop(x);
x.f = ...;
}
Change this code to not create partially-initialized structures. For
example:
struct Struct {
f: String,
g: String,
}
impl Drop for Struct { ... }
fn main() {
let x = Struct { ... };
drop(x);
x = Struct {
f: ...,
g: ...,
}
}
Closes #18571.
[breaking-change]
----
(Joint authorship by pcwalton and Ryman; thanks all!)
50 lines
1.1 KiB
Rust
50 lines
1.1 KiB
Rust
// Copyright 2014-2015 The Rust Project Developers. See the COPYRIGHT
|
|
// file at the top-level directory of this distribution and at
|
|
// http://rust-lang.org/COPYRIGHT.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
// option. This file may not be copied, modified, or distributed
|
|
// except according to those terms.
|
|
|
|
struct Test;
|
|
|
|
struct Test2 {
|
|
b: Option<Test>,
|
|
}
|
|
|
|
struct Test3(Option<Test>);
|
|
|
|
impl Drop for Test {
|
|
fn drop(&mut self) {
|
|
println!("dropping!");
|
|
}
|
|
}
|
|
|
|
impl Drop for Test2 {
|
|
fn drop(&mut self) {}
|
|
}
|
|
|
|
impl Drop for Test3 {
|
|
fn drop(&mut self) {}
|
|
}
|
|
|
|
fn stuff() {
|
|
let mut t = Test2 { b: None };
|
|
let u = Test;
|
|
drop(t);
|
|
t.b = Some(u);
|
|
//~^ ERROR partial reinitialization of uninitialized structure `t`
|
|
|
|
let mut t = Test3(None);
|
|
let u = Test;
|
|
drop(t);
|
|
t.0 = Some(u);
|
|
//~^ ERROR partial reinitialization of uninitialized structure `t`
|
|
}
|
|
|
|
fn main() {
|
|
stuff()
|
|
}
|