eb3970285b
In order to switch `clippy::uninlined_format_args` from pedantic to style, all existing tests must not raise a warning. I did not want to change the actual tests, so this is a relatively minor change that: * add `#![allow(clippy::uninlined_format_args)]` where needed * normalizes all allow/deny/warn attributes * all allow attributes are grouped together * sorted alphabetically * the `clippy::*` attributes are listed separate from the other ones. * deny and warn attributes are listed before the allowed ones changelog: none
102 lines
1.9 KiB
Rust
102 lines
1.9 KiB
Rust
// run-rustfix
|
|
#![warn(clippy::explicit_deref_methods)]
|
|
#![allow(unused_variables)]
|
|
#![allow(
|
|
clippy::borrow_deref_ref,
|
|
clippy::clone_double_ref,
|
|
clippy::explicit_auto_deref,
|
|
clippy::needless_borrow,
|
|
clippy::uninlined_format_args
|
|
)]
|
|
|
|
use std::ops::{Deref, DerefMut};
|
|
|
|
fn concat(deref_str: &str) -> String {
|
|
format!("{}bar", deref_str)
|
|
}
|
|
|
|
fn just_return(deref_str: &str) -> &str {
|
|
deref_str
|
|
}
|
|
|
|
struct CustomVec(Vec<u8>);
|
|
impl Deref for CustomVec {
|
|
type Target = Vec<u8>;
|
|
|
|
fn deref(&self) -> &Vec<u8> {
|
|
&self.0
|
|
}
|
|
}
|
|
|
|
fn main() {
|
|
let a: &mut String = &mut String::from("foo");
|
|
|
|
// these should require linting
|
|
|
|
let b: &str = &*a;
|
|
|
|
let b: &mut str = &mut **a;
|
|
|
|
// both derefs should get linted here
|
|
let b: String = format!("{}, {}", &*a, &*a);
|
|
|
|
println!("{}", &*a);
|
|
|
|
#[allow(clippy::match_single_binding)]
|
|
match &*a {
|
|
_ => (),
|
|
}
|
|
|
|
let b: String = concat(&*a);
|
|
|
|
let b = just_return(a);
|
|
|
|
let b: String = concat(just_return(a));
|
|
|
|
let b: &str = &**a;
|
|
|
|
let opt_a = Some(a.clone());
|
|
let b = &*opt_a.unwrap();
|
|
|
|
// following should not require linting
|
|
|
|
let cv = CustomVec(vec![0, 42]);
|
|
let c = cv.deref()[0];
|
|
|
|
let b: &str = &*a.deref();
|
|
|
|
let b: String = a.deref().clone();
|
|
|
|
let b: usize = a.deref_mut().len();
|
|
|
|
let b: &usize = &a.deref().len();
|
|
|
|
let b: &str = &*a;
|
|
|
|
let b: &mut str = &mut *a;
|
|
|
|
macro_rules! expr_deref {
|
|
($body:expr) => {
|
|
$body.deref()
|
|
};
|
|
}
|
|
let b: &str = expr_deref!(a);
|
|
|
|
let b: &str = expr_deref!(&*a);
|
|
|
|
// The struct does not implement Deref trait
|
|
#[derive(Copy, Clone)]
|
|
struct NoLint(u32);
|
|
impl NoLint {
|
|
pub fn deref(self) -> u32 {
|
|
self.0
|
|
}
|
|
pub fn deref_mut(self) -> u32 {
|
|
self.0
|
|
}
|
|
}
|
|
let no_lint = NoLint(42);
|
|
let b = no_lint.deref();
|
|
let b = no_lint.deref_mut();
|
|
}
|