7828c3dd28
https://github.com/rust-lang/rfcs/pull/221 The current terminology of "task failure" often causes problems when writing or speaking about code. You often want to talk about the possibility of an operation that returns a Result "failing", but cannot because of the ambiguity with task failure. Instead, you have to speak of "the failing case" or "when the operation does not succeed" or other circumlocutions. Likewise, we use a "Failure" header in rustdoc to describe when operations may fail the task, but it would often be helpful to separate out a section describing the "Err-producing" case. We have been steadily moving away from task failure and toward Result as an error-handling mechanism, so we should optimize our terminology accordingly: Result-producing functions should be easy to describe. To update your code, rename any call to `fail!` to `panic!` instead. Assuming you have not created your own macro named `panic!`, this will work on UNIX based systems: grep -lZR 'fail!' . | xargs -0 -l sed -i -e 's/fail!/panic!/g' You can of course also do this by hand. [breaking-change]
67 lines
2.0 KiB
Rust
67 lines
2.0 KiB
Rust
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
|
|
// file at the top-level directory of this distribution and at
|
|
// http://rust-lang.org/COPYRIGHT.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
// option. This file may not be copied, modified, or distributed
|
|
// except according to those terms.
|
|
|
|
// Exercise the unused_unsafe attribute in some positive and negative cases
|
|
|
|
#![allow(dead_code)]
|
|
#![deny(unused_unsafe)]
|
|
|
|
|
|
mod foo {
|
|
extern {
|
|
pub fn bar();
|
|
}
|
|
}
|
|
|
|
fn callback<T>(_f: || -> T) -> T { panic!() }
|
|
unsafe fn unsf() {}
|
|
|
|
fn bad1() { unsafe {} } //~ ERROR: unnecessary `unsafe` block
|
|
fn bad2() { unsafe { bad1() } } //~ ERROR: unnecessary `unsafe` block
|
|
unsafe fn bad3() { unsafe {} } //~ ERROR: unnecessary `unsafe` block
|
|
fn bad4() { unsafe { callback(||{}) } } //~ ERROR: unnecessary `unsafe` block
|
|
unsafe fn bad5() { unsafe { unsf() } } //~ ERROR: unnecessary `unsafe` block
|
|
fn bad6() {
|
|
unsafe { // don't put the warning here
|
|
unsafe { //~ ERROR: unnecessary `unsafe` block
|
|
unsf()
|
|
}
|
|
}
|
|
}
|
|
unsafe fn bad7() {
|
|
unsafe { //~ ERROR: unnecessary `unsafe` block
|
|
unsafe { //~ ERROR: unnecessary `unsafe` block
|
|
unsf()
|
|
}
|
|
}
|
|
}
|
|
|
|
unsafe fn good0() { unsf() }
|
|
fn good1() { unsafe { unsf() } }
|
|
fn good2() {
|
|
/* bug uncovered when implementing warning about unused unsafe blocks. Be
|
|
sure that when purity is inherited that the source of the unsafe-ness
|
|
is tracked correctly */
|
|
unsafe {
|
|
unsafe fn what() -> Vec<String> { panic!() }
|
|
|
|
callback(|| {
|
|
what();
|
|
});
|
|
}
|
|
}
|
|
|
|
unsafe fn good3() { foo::bar() }
|
|
fn good4() { unsafe { foo::bar() } }
|
|
|
|
#[allow(unused_unsafe)] fn allowed() { unsafe {} }
|
|
|
|
fn main() {}
|