rust/compiler
Josh Stone 5861815559
Rollup merge of #114931 - Urgau:revert-114052, r=compiler-errors
Revert PR #114052 to fix invalid suggestion

This PR reverts https://github.com/rust-lang/rust/pull/114052 to fix the invalid suggestion produced by the PR.

Unfortunately the invalid suggestion cannot be improved from the current position where it's emitted since we lack enough information (is an assignment?, left or right?, ...) to be able to fix it here. Furthermore the previous wasn't wrong, just suboptimal, contrary to the current one which is just wrong.

Added a regression test and commented out some code instead of removing it so we can use it later.

Reopens https://github.com/rust-lang/rust/issues/114050
Fixes https://github.com/rust-lang/rust/issues/114925
2023-08-17 15:40:09 -07:00
..
rustc
rustc_abi
rustc_arena Address comments 2023-08-14 21:29:19 +02:00
rustc_ast Auto merge of #114545 - fee1-dead-contrib:lower-impl-effect, r=oli-obk 2023-08-08 19:23:41 +00:00
rustc_ast_lowering Move scrutinee HirId into MatchSource::TryDesugar 2023-08-14 21:43:56 +00:00
rustc_ast_passes rustc: Move features from Session to GlobalCtxt 2023-08-11 16:51:50 +08:00
rustc_ast_pretty Improve spans for indexing expressions 2023-08-04 13:17:39 +02:00
rustc_attr rustc: Move features from Session to GlobalCtxt 2023-08-11 16:51:50 +08:00
rustc_baked_icu_data
rustc_borrowck Make TerminatorEdge plural. 2023-08-16 18:12:18 +00:00
rustc_builtin_macros rustc: Move features from Session to GlobalCtxt 2023-08-11 16:51:50 +08:00
rustc_codegen_cranelift reverse change in rustc_codegen_cranelift 2023-08-15 00:09:20 +08:00
rustc_codegen_gcc Auto merge of #114467 - Amanieu:asm-unstable-features, r=davidtwco 2023-08-15 11:59:02 +00:00
rustc_codegen_llvm Auto merge of #114467 - Amanieu:asm-unstable-features, r=davidtwco 2023-08-15 11:59:02 +00:00
rustc_codegen_ssa Rollup merge of #114711 - lqd:linker-inference, r=petrochenkov 2023-08-15 14:29:45 +02:00
rustc_const_eval Make TerminatorEdge plural. 2023-08-16 18:12:18 +00:00
rustc_data_structures Auto merge of #114339 - ttsugriy:unsafe-utf8, r=davidtwco 2023-08-08 10:25:37 +00:00
rustc_driver
rustc_driver_impl rustc: Move crate_types from Session to GlobalCtxt 2023-08-09 14:17:54 +08:00
rustc_error_codes Rollup merge of #113715 - kadiwa4:lang_items_doc, r=JohnTitor 2023-08-17 15:40:08 -07:00
rustc_error_messages
rustc_errors Auto merge of #114104 - oli-obk:syn2, r=compiler-errors 2023-08-04 18:46:19 +00:00
rustc_expand rustc: Move features from Session to GlobalCtxt 2023-08-11 16:51:50 +08:00
rustc_feature Update compiler/rustc_feature/src/active.rs 2023-08-15 02:13:17 +08:00
rustc_fluent_macro
rustc_fs_util
rustc_graphviz
rustc_hir Move scrutinee HirId into MatchSource::TryDesugar 2023-08-14 21:43:56 +00:00
rustc_hir_analysis Rollup merge of #114746 - compiler-errors:atb-no-const, r=TaKO8Ki 2023-08-16 08:43:50 +02:00
rustc_hir_pretty Auto merge of #114545 - fee1-dead-contrib:lower-impl-effect, r=oli-obk 2023-08-08 19:23:41 +00:00
rustc_hir_typeck Revert PR #114052 to fix invalid suggestion 2023-08-17 14:33:33 +02:00
rustc_incremental Pass WorkProductMap to build_dep_graph instead of FxIndexMap 2023-08-13 16:07:48 +00:00
rustc_index
rustc_infer Rollup merge of #114819 - estebank:issue-78124, r=compiler-errors 2023-08-15 20:34:25 +02:00
rustc_interface Fix review comment 2023-08-14 16:16:51 +00:00
rustc_lexer
rustc_lint Rollup merge of #114784 - Urgau:many-improve-invalid_reference_casting-lint, r=est31 2023-08-16 20:10:37 +02:00
rustc_lint_defs more nits 2023-08-15 03:44:21 +00:00
rustc_llvm add a csky-unknown-linux-gnuabiv2 target 2023-08-14 23:02:36 +08:00
rustc_log
rustc_macros
rustc_metadata Remove metadata_loader query 2023-08-13 16:38:50 +00:00
rustc_middle Rollup merge of #114876 - compiler-errors:non-lifetime-binders-sized, r=wesleywiser 2023-08-17 08:39:21 +02:00
rustc_mir_build Rollup merge of #114819 - estebank:issue-78124, r=compiler-errors 2023-08-15 20:34:25 +02:00
rustc_mir_dataflow Use Terminator::edges for backward analysis too. 2023-08-16 19:40:46 +00:00
rustc_mir_transform Do not pre-compute reachable blocks. 2023-08-16 19:40:46 +00:00
rustc_monomorphize Store the laziness of type aliases in the DefKind 2023-08-07 15:54:31 +02:00
rustc_parse Rollup merge of #114913 - beetrees:escape-double-quote, r=davidtwco 2023-08-17 15:40:09 -07:00
rustc_parse_format
rustc_passes Rollup merge of #114819 - estebank:issue-78124, r=compiler-errors 2023-08-15 20:34:25 +02:00
rustc_plugin_impl
rustc_privacy Use {Local}ModDefId in many queries 2023-08-14 07:22:48 +00:00
rustc_query_impl
rustc_query_system Remove conditional use of Sharded from query caches 2023-08-16 14:16:05 +02:00
rustc_resolve rustc: Move features from Session to GlobalCtxt 2023-08-11 16:51:50 +08:00
rustc_serialize
rustc_session Remove reached_eof from ParseSess 2023-08-13 13:33:37 +00:00
rustc_smir Add missing Clone/Debug impls to SMIR Trait related tys 2023-08-16 13:10:52 -03:00
rustc_span Rollup merge of #114784 - Urgau:many-improve-invalid_reference_casting-lint, r=est31 2023-08-16 20:10:37 +02:00
rustc_symbol_mangling Auto merge of #114672 - lenawanel:master, r=compiler-errors 2023-08-11 09:30:41 +00:00
rustc_target Rollup merge of #114711 - lqd:linker-inference, r=petrochenkov 2023-08-15 14:29:45 +02:00
rustc_trait_selection Rollup merge of #114819 - estebank:issue-78124, r=compiler-errors 2023-08-15 20:34:25 +02:00
rustc_traits
rustc_transmute
rustc_ty_utils Rollup merge of #114670 - compiler-errors:issue-114660, r=cjgillot 2023-08-09 23:00:00 +02:00
rustc_type_ir Comment nits 2023-08-10 23:22:03 +00:00