008ba2b8bb
fix dogfood lints in `redundant_local` keep `redundant_local` from running in proc macros rewrite `redundant_local` as late pass make redundant_local's `find_binding` more readable pluralize `redundant_locals` name add test for `redundant_locals` in macros test `redundant_locals` in proc macros use more destructuring in `redundant_locals` fix: format redundant_locals.rs ignore needless_pass_by_mut_ref in redundant_locals test
160 lines
4.6 KiB
Plaintext
160 lines
4.6 KiB
Plaintext
error: this looks like you are swapping `bar.a` and `bar.b` manually
|
|
--> $DIR/swap.rs:29:5
|
|
|
|
|
LL | / let temp = bar.a;
|
|
LL | | bar.a = bar.b;
|
|
LL | | bar.b = temp;
|
|
| |_________________^ help: try: `std::mem::swap(&mut bar.a, &mut bar.b);`
|
|
|
|
|
= note: or maybe you should use `std::mem::replace`?
|
|
= note: `-D clippy::manual-swap` implied by `-D warnings`
|
|
|
|
error: this looks like you are swapping elements of `foo` manually
|
|
--> $DIR/swap.rs:41:5
|
|
|
|
|
LL | / let temp = foo[0];
|
|
LL | | foo[0] = foo[1];
|
|
LL | | foo[1] = temp;
|
|
| |__________________^ help: try: `foo.swap(0, 1);`
|
|
|
|
error: this looks like you are swapping elements of `foo` manually
|
|
--> $DIR/swap.rs:50:5
|
|
|
|
|
LL | / let temp = foo[0];
|
|
LL | | foo[0] = foo[1];
|
|
LL | | foo[1] = temp;
|
|
| |__________________^ help: try: `foo.swap(0, 1);`
|
|
|
|
error: this looks like you are swapping elements of `foo` manually
|
|
--> $DIR/swap.rs:69:5
|
|
|
|
|
LL | / let temp = foo[0];
|
|
LL | | foo[0] = foo[1];
|
|
LL | | foo[1] = temp;
|
|
| |__________________^ help: try: `foo.swap(0, 1);`
|
|
|
|
error: this looks like you are swapping `a` and `b` manually
|
|
--> $DIR/swap.rs:80:5
|
|
|
|
|
LL | / a ^= b;
|
|
LL | | b ^= a;
|
|
LL | | a ^= b;
|
|
| |___________^ help: try: `std::mem::swap(&mut a, &mut b);`
|
|
|
|
error: this looks like you are swapping `bar.a` and `bar.b` manually
|
|
--> $DIR/swap.rs:88:5
|
|
|
|
|
LL | / bar.a ^= bar.b;
|
|
LL | | bar.b ^= bar.a;
|
|
LL | | bar.a ^= bar.b;
|
|
| |___________________^ help: try: `std::mem::swap(&mut bar.a, &mut bar.b);`
|
|
|
|
error: this looks like you are swapping elements of `foo` manually
|
|
--> $DIR/swap.rs:96:5
|
|
|
|
|
LL | / foo[0] ^= foo[1];
|
|
LL | | foo[1] ^= foo[0];
|
|
LL | | foo[0] ^= foo[1];
|
|
| |_____________________^ help: try: `foo.swap(0, 1);`
|
|
|
|
error: this looks like you are swapping `foo[0][1]` and `bar[1][0]` manually
|
|
--> $DIR/swap.rs:125:5
|
|
|
|
|
LL | / let temp = foo[0][1];
|
|
LL | | foo[0][1] = bar[1][0];
|
|
LL | | bar[1][0] = temp;
|
|
| |_____________________^ help: try: `std::mem::swap(&mut foo[0][1], &mut bar[1][0]);`
|
|
|
|
|
= note: or maybe you should use `std::mem::replace`?
|
|
|
|
error: this looks like you are swapping `a` and `b` manually
|
|
--> $DIR/swap.rs:139:7
|
|
|
|
|
LL | ; let t = a;
|
|
| _______^
|
|
LL | | a = b;
|
|
LL | | b = t;
|
|
| |__________^ help: try: `std::mem::swap(&mut a, &mut b);`
|
|
|
|
|
= note: or maybe you should use `std::mem::replace`?
|
|
|
|
error: this looks like you are swapping `c.0` and `a` manually
|
|
--> $DIR/swap.rs:148:7
|
|
|
|
|
LL | ; let t = c.0;
|
|
| _______^
|
|
LL | | c.0 = a;
|
|
LL | | a = t;
|
|
| |__________^ help: try: `std::mem::swap(&mut c.0, &mut a);`
|
|
|
|
|
= note: or maybe you should use `std::mem::replace`?
|
|
|
|
error: this looks like you are swapping `b` and `a` manually
|
|
--> $DIR/swap.rs:174:5
|
|
|
|
|
LL | / let t = b;
|
|
LL | | b = a;
|
|
LL | | a = t;
|
|
| |__________^ help: try: `std::mem::swap(&mut b, &mut a);`
|
|
|
|
|
= note: or maybe you should use `std::mem::replace`?
|
|
|
|
error: this looks like you are trying to swap `a` and `b`
|
|
--> $DIR/swap.rs:136:5
|
|
|
|
|
LL | / a = b;
|
|
LL | | b = a;
|
|
| |_________^ help: try: `std::mem::swap(&mut a, &mut b)`
|
|
|
|
|
= note: or maybe you should use `std::mem::replace`?
|
|
= note: `-D clippy::almost-swapped` implied by `-D warnings`
|
|
|
|
error: this looks like you are trying to swap `c.0` and `a`
|
|
--> $DIR/swap.rs:145:5
|
|
|
|
|
LL | / c.0 = a;
|
|
LL | | a = c.0;
|
|
| |___________^ help: try: `std::mem::swap(&mut c.0, &mut a)`
|
|
|
|
|
= note: or maybe you should use `std::mem::replace`?
|
|
|
|
error: this looks like you are trying to swap `a` and `b`
|
|
--> $DIR/swap.rs:152:5
|
|
|
|
|
LL | / let a = b;
|
|
LL | | let b = a;
|
|
| |_____________^ help: try: `std::mem::swap(&mut a, &mut b)`
|
|
|
|
|
= note: or maybe you should use `std::mem::replace`?
|
|
|
|
error: this looks like you are trying to swap `d` and `c`
|
|
--> $DIR/swap.rs:157:5
|
|
|
|
|
LL | / d = c;
|
|
LL | | c = d;
|
|
| |_________^ help: try: `std::mem::swap(&mut d, &mut c)`
|
|
|
|
|
= note: or maybe you should use `std::mem::replace`?
|
|
|
|
error: this looks like you are trying to swap `a` and `b`
|
|
--> $DIR/swap.rs:161:5
|
|
|
|
|
LL | / let a = b;
|
|
LL | | b = a;
|
|
| |_________^ help: try: `std::mem::swap(&mut a, &mut b)`
|
|
|
|
|
= note: or maybe you should use `std::mem::replace`?
|
|
|
|
error: this looks like you are swapping `s.0.x` and `s.0.y` manually
|
|
--> $DIR/swap.rs:209:5
|
|
|
|
|
LL | / let t = s.0.x;
|
|
LL | | s.0.x = s.0.y;
|
|
LL | | s.0.y = t;
|
|
| |______________^ help: try: `std::mem::swap(&mut s.0.x, &mut s.0.y);`
|
|
|
|
|
= note: or maybe you should use `std::mem::replace`?
|
|
|
|
error: aborting due to 17 previous errors
|
|
|