4438c41d14
- Fix copy-paste error - Check for opt.map_or argument after ensuring that opt is an Option - Use span_lint_and_then and span_suggestion - Update reference
473 lines
18 KiB
Plaintext
473 lines
18 KiB
Plaintext
error: unnecessary structure name repetition
|
|
--> $DIR/methods.rs:20:25
|
|
|
|
|
20 | fn add(self, other: T) -> T { self }
|
|
| ^ help: use the applicable keyword: `Self`
|
|
|
|
|
= note: `-D use-self` implied by `-D warnings`
|
|
|
|
error: unnecessary structure name repetition
|
|
--> $DIR/methods.rs:20:31
|
|
|
|
|
20 | fn add(self, other: T) -> T { self }
|
|
| ^ help: use the applicable keyword: `Self`
|
|
|
|
error: unnecessary structure name repetition
|
|
--> $DIR/methods.rs:23:26
|
|
|
|
|
23 | fn sub(&self, other: T) -> &T { self } // no error, self is a ref
|
|
| ^ help: use the applicable keyword: `Self`
|
|
|
|
error: unnecessary structure name repetition
|
|
--> $DIR/methods.rs:23:33
|
|
|
|
|
23 | fn sub(&self, other: T) -> &T { self } // no error, self is a ref
|
|
| ^ help: use the applicable keyword: `Self`
|
|
|
|
error: unnecessary structure name repetition
|
|
--> $DIR/methods.rs:24:21
|
|
|
|
|
24 | fn div(self) -> T { self } // no error, different #arguments
|
|
| ^ help: use the applicable keyword: `Self`
|
|
|
|
error: unnecessary structure name repetition
|
|
--> $DIR/methods.rs:25:25
|
|
|
|
|
25 | fn rem(self, other: T) { } // no error, wrong return type
|
|
| ^ help: use the applicable keyword: `Self`
|
|
|
|
error: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name
|
|
--> $DIR/methods.rs:20:5
|
|
|
|
|
20 | fn add(self, other: T) -> T { self }
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D should-implement-trait` implied by `-D warnings`
|
|
|
|
error: defining a method called `drop` on this type; consider implementing the `std::ops::Drop` trait or choosing a less ambiguous name
|
|
--> $DIR/methods.rs:21:5
|
|
|
|
|
21 | fn drop(&mut self) { }
|
|
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
|
|
--> $DIR/methods.rs:28:17
|
|
|
|
|
28 | fn into_u16(&self) -> u16 { 0 }
|
|
| ^^^^^
|
|
|
|
|
= note: `-D wrong-self-convention` implied by `-D warnings`
|
|
|
|
error: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
|
|
--> $DIR/methods.rs:30:21
|
|
|
|
|
30 | fn to_something(self) -> u32 { 0 }
|
|
| ^^^^
|
|
|
|
error: methods called `new` usually take no self; consider choosing a less ambiguous name
|
|
--> $DIR/methods.rs:32:12
|
|
|
|
|
32 | fn new(self) {}
|
|
| ^^^^
|
|
|
|
error: methods called `new` usually return `Self`
|
|
--> $DIR/methods.rs:32:5
|
|
|
|
|
32 | fn new(self) {}
|
|
| ^^^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D new-ret-no-self` implied by `-D warnings`
|
|
|
|
error: unnecessary structure name repetition
|
|
--> $DIR/methods.rs:76:24
|
|
|
|
|
76 | fn new() -> Option<V<T>> { None }
|
|
| ^^^^ help: use the applicable keyword: `Self`
|
|
|
|
error: unnecessary structure name repetition
|
|
--> $DIR/methods.rs:80:19
|
|
|
|
|
80 | type Output = T;
|
|
| ^ help: use the applicable keyword: `Self`
|
|
|
|
error: unnecessary structure name repetition
|
|
--> $DIR/methods.rs:81:25
|
|
|
|
|
81 | fn mul(self, other: T) -> T { self } // no error, obviously
|
|
| ^ help: use the applicable keyword: `Self`
|
|
|
|
error: unnecessary structure name repetition
|
|
--> $DIR/methods.rs:81:31
|
|
|
|
|
81 | fn mul(self, other: T) -> T { self } // no error, obviously
|
|
| ^ help: use the applicable keyword: `Self`
|
|
|
|
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
|
|
--> $DIR/methods.rs:100:13
|
|
|
|
|
100 | let _ = opt.map(|x| x + 1)
|
|
| _____________^
|
|
101 | |
|
|
102 | | .unwrap_or(0); // should lint even though this call is on a separate line
|
|
| |____________________________^
|
|
|
|
|
= note: `-D option-map-unwrap-or` implied by `-D warnings`
|
|
= note: replace `map(|x| x + 1).unwrap_or(0)` with `map_or(0, |x| x + 1)`
|
|
|
|
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
|
|
--> $DIR/methods.rs:104:13
|
|
|
|
|
104 | let _ = opt.map(|x| {
|
|
| _____________^
|
|
105 | | x + 1
|
|
106 | | }
|
|
107 | | ).unwrap_or(0);
|
|
| |____________________________^
|
|
|
|
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
|
|
--> $DIR/methods.rs:108:13
|
|
|
|
|
108 | let _ = opt.map(|x| x + 1)
|
|
| _____________^
|
|
109 | | .unwrap_or({
|
|
110 | | 0
|
|
111 | | });
|
|
| |__________________^
|
|
|
|
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
|
|
--> $DIR/methods.rs:113:13
|
|
|
|
|
113 | let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`
|
|
|
|
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
|
|
--> $DIR/methods.rs:115:13
|
|
|
|
|
115 | let _ = opt.map(|x| {
|
|
| _____________^
|
|
116 | | Some(x + 1)
|
|
117 | | }
|
|
118 | | ).unwrap_or(None);
|
|
| |_____________________^
|
|
|
|
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
|
|
--> $DIR/methods.rs:119:13
|
|
|
|
|
119 | let _ = opt
|
|
| _____________^
|
|
120 | | .map(|x| Some(x + 1))
|
|
121 | | .unwrap_or(None);
|
|
| |________________________^
|
|
|
|
|
= note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`
|
|
|
|
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
|
|
--> $DIR/methods.rs:127:13
|
|
|
|
|
127 | let _ = opt.map(|x| x + 1)
|
|
| _____________^
|
|
128 | |
|
|
129 | | .unwrap_or_else(|| 0); // should lint even though this call is on a separate line
|
|
| |____________________________________^
|
|
|
|
|
= note: `-D option-map-unwrap-or-else` implied by `-D warnings`
|
|
= note: replace `map(|x| x + 1).unwrap_or_else(|| 0)` with `map_or_else(|| 0, |x| x + 1)`
|
|
|
|
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
|
|
--> $DIR/methods.rs:131:13
|
|
|
|
|
131 | let _ = opt.map(|x| {
|
|
| _____________^
|
|
132 | | x + 1
|
|
133 | | }
|
|
134 | | ).unwrap_or_else(|| 0);
|
|
| |____________________________________^
|
|
|
|
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
|
|
--> $DIR/methods.rs:135:13
|
|
|
|
|
135 | let _ = opt.map(|x| x + 1)
|
|
| _____________^
|
|
136 | | .unwrap_or_else(||
|
|
137 | | 0
|
|
138 | | );
|
|
| |_________________^
|
|
|
|
error: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
|
|
--> $DIR/methods.rs:144:13
|
|
|
|
|
144 | let _ = opt.map_or(None, |x| Some(x + 1));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `opt.and_then(|x| Some(x + 1))`
|
|
|
|
|
= note: `-D option-map-or-none` implied by `-D warnings`
|
|
|
|
error: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
|
|
--> $DIR/methods.rs:146:13
|
|
|
|
|
146 | let _ = opt.map_or(None, |x| {
|
|
| _____________^
|
|
147 | | Some(x + 1)
|
|
148 | | }
|
|
149 | | );
|
|
| |_________________^
|
|
|
|
|
help: try using and_then instead
|
|
|
|
|
146 | let _ = opt.and_then(|x| {
|
|
147 | Some(x + 1)
|
|
148 | });
|
|
|
|
|
|
|
error: unnecessary structure name repetition
|
|
--> $DIR/methods.rs:173:24
|
|
|
|
|
173 | fn filter(self) -> IteratorFalsePositives {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self`
|
|
|
|
error: unnecessary structure name repetition
|
|
--> $DIR/methods.rs:177:22
|
|
|
|
|
177 | fn next(self) -> IteratorFalsePositives {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self`
|
|
|
|
error: unnecessary structure name repetition
|
|
--> $DIR/methods.rs:197:32
|
|
|
|
|
197 | fn skip(self, _: usize) -> IteratorFalsePositives {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self`
|
|
|
|
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
|
|
--> $DIR/methods.rs:207:13
|
|
|
|
|
207 | let _ = v.iter().filter(|&x| *x < 0).next();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D filter-next` implied by `-D warnings`
|
|
= note: replace `filter(|&x| *x < 0).next()` with `find(|&x| *x < 0)`
|
|
|
|
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
|
|
--> $DIR/methods.rs:210:13
|
|
|
|
|
210 | let _ = v.iter().filter(|&x| {
|
|
| _____________^
|
|
211 | | *x < 0
|
|
212 | | }
|
|
213 | | ).next();
|
|
| |___________________________^
|
|
|
|
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:225:13
|
|
|
|
|
225 | let _ = v.iter().find(|&x| *x < 0).is_some();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D search-is-some` implied by `-D warnings`
|
|
= note: replace `find(|&x| *x < 0).is_some()` with `any(|&x| *x < 0)`
|
|
|
|
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:228:13
|
|
|
|
|
228 | let _ = v.iter().find(|&x| {
|
|
| _____________^
|
|
229 | | *x < 0
|
|
230 | | }
|
|
231 | | ).is_some();
|
|
| |______________________________^
|
|
|
|
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:234:13
|
|
|
|
|
234 | let _ = v.iter().position(|&x| x < 0).is_some();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: replace `position(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
|
|
|
|
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:237:13
|
|
|
|
|
237 | let _ = v.iter().position(|&x| {
|
|
| _____________^
|
|
238 | | x < 0
|
|
239 | | }
|
|
240 | | ).is_some();
|
|
| |______________________________^
|
|
|
|
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:243:13
|
|
|
|
|
243 | let _ = v.iter().rposition(|&x| x < 0).is_some();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: replace `rposition(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
|
|
|
|
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:246:13
|
|
|
|
|
246 | let _ = v.iter().rposition(|&x| {
|
|
| _____________^
|
|
247 | | x < 0
|
|
248 | | }
|
|
249 | | ).is_some();
|
|
| |______________________________^
|
|
|
|
error: unnecessary structure name repetition
|
|
--> $DIR/methods.rs:263:21
|
|
|
|
|
263 | fn new() -> Foo { Foo }
|
|
| ^^^ help: use the applicable keyword: `Self`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/methods.rs:281:5
|
|
|
|
|
281 | with_constructor.unwrap_or(make());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_constructor.unwrap_or_else(make)`
|
|
|
|
|
= note: `-D or-fun-call` implied by `-D warnings`
|
|
|
|
error: use of `unwrap_or` followed by a call to `new`
|
|
--> $DIR/methods.rs:284:5
|
|
|
|
|
284 | with_new.unwrap_or(Vec::new());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_new.unwrap_or_default()`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/methods.rs:287:5
|
|
|
|
|
287 | with_const_args.unwrap_or(Vec::with_capacity(12));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_const_args.unwrap_or_else(|| Vec::with_capacity(12))`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/methods.rs:290:5
|
|
|
|
|
290 | with_err.unwrap_or(make());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_err.unwrap_or_else(|_| make())`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/methods.rs:293:5
|
|
|
|
|
293 | with_err_args.unwrap_or(Vec::with_capacity(12));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_err_args.unwrap_or_else(|_| Vec::with_capacity(12))`
|
|
|
|
error: use of `unwrap_or` followed by a call to `default`
|
|
--> $DIR/methods.rs:296:5
|
|
|
|
|
296 | with_default_trait.unwrap_or(Default::default());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_trait.unwrap_or_default()`
|
|
|
|
error: use of `unwrap_or` followed by a call to `default`
|
|
--> $DIR/methods.rs:299:5
|
|
|
|
|
299 | with_default_type.unwrap_or(u64::default());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_type.unwrap_or_default()`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/methods.rs:302:5
|
|
|
|
|
302 | with_vec.unwrap_or(vec![]);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_vec.unwrap_or_else(|| < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ))`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/methods.rs:307:5
|
|
|
|
|
307 | without_default.unwrap_or(Foo::new());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `without_default.unwrap_or_else(Foo::new)`
|
|
|
|
error: use of `or_insert` followed by a function call
|
|
--> $DIR/methods.rs:310:5
|
|
|
|
|
310 | map.entry(42).or_insert(String::new());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `map.entry(42).or_insert_with(String::new)`
|
|
|
|
error: use of `or_insert` followed by a function call
|
|
--> $DIR/methods.rs:313:5
|
|
|
|
|
313 | btree.entry(42).or_insert(String::new());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `btree.entry(42).or_insert_with(String::new)`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/methods.rs:316:13
|
|
|
|
|
316 | let _ = stringy.unwrap_or("".to_owned());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `stringy.unwrap_or_else(|| "".to_owned())`
|
|
|
|
error: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable
|
|
--> $DIR/methods.rs:327:23
|
|
|
|
|
327 | let bad_vec = some_vec.iter().nth(3);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D iter-nth` implied by `-D warnings`
|
|
|
|
error: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
|
|
--> $DIR/methods.rs:328:26
|
|
|
|
|
328 | let bad_slice = &some_vec[..].iter().nth(3);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
|
|
--> $DIR/methods.rs:329:31
|
|
|
|
|
329 | let bad_boxed_slice = boxed_slice.iter().nth(3);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: called `.iter().nth()` on a VecDeque. Calling `.get()` is both faster and more readable
|
|
--> $DIR/methods.rs:330:29
|
|
|
|
|
330 | let bad_vec_deque = some_vec_deque.iter().nth(3);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: called `.iter_mut().nth()` on a Vec. Calling `.get_mut()` is both faster and more readable
|
|
--> $DIR/methods.rs:335:23
|
|
|
|
|
335 | let bad_vec = some_vec.iter_mut().nth(3);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: called `.iter_mut().nth()` on a slice. Calling `.get_mut()` is both faster and more readable
|
|
--> $DIR/methods.rs:338:26
|
|
|
|
|
338 | let bad_slice = &some_vec[..].iter_mut().nth(3);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: called `.iter_mut().nth()` on a VecDeque. Calling `.get_mut()` is both faster and more readable
|
|
--> $DIR/methods.rs:341:29
|
|
|
|
|
341 | let bad_vec_deque = some_vec_deque.iter_mut().nth(3);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
|
|
--> $DIR/methods.rs:353:13
|
|
|
|
|
353 | let _ = some_vec.iter().skip(42).next();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D iter-skip-next` implied by `-D warnings`
|
|
|
|
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
|
|
--> $DIR/methods.rs:354:13
|
|
|
|
|
354 | let _ = some_vec.iter().cycle().skip(42).next();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
|
|
--> $DIR/methods.rs:355:13
|
|
|
|
|
355 | let _ = (1..10).skip(10).next();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
|
|
--> $DIR/methods.rs:356:14
|
|
|
|
|
356 | let _ = &some_vec[..].iter().skip(3).next();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: used unwrap() on an Option value. If you don't want to handle the None case gracefully, consider using expect() to provide a better panic message
|
|
--> $DIR/methods.rs:365:13
|
|
|
|
|
365 | let _ = opt.unwrap();
|
|
| ^^^^^^^^^^^^
|
|
|
|
|
= note: `-D option-unwrap-used` implied by `-D warnings`
|
|
|