bors b52fb5234c Auto merge of #9446 - mikerite:fix-9431-2, r=giraffate ...

Fix `range_{plus,minus}_one` bad suggestions

Fixes #9431.

The current `range_plus_one` and `range_minus_one` suggestions are completely incorrect when macros are involved.

This commit resolves this by disabling the lints for any range expression that is expanded from a macro. The reasons for this are that it is very difficult to create a correct suggestion in this case and that false negatives are less important for pedantic lints.

changelog: Fix `range_{plus,minus}_one` bad suggestions

2022-09-08 23:48:08 +00:00

..

cargo

…

casts

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

functions

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

loops

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

matches

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

methods

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

misc_early

clippy: BindingAnnotation change

2022-09-02 13:03:11 -05:00

operators

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

transmute

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

types

…

unit_types

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

utils

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

almost_complete_letter_range.rs

…

approx_const.rs

…

as_conversions.rs

…

asm_syntax.rs

…

assertions_on_constants.rs

…

assertions_on_result_states.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

async_yields_async.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

attrs.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

await_holding_invalid.rs

…

blocks_in_if_conditions.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

bool_assert_comparison.rs

…

bool_to_int_with_if.rs

New lint bool_to_int_with_if

2022-09-01 23:23:56 +02:00

booleans.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

borrow_deref_ref.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

checked_conversions.rs

…

cognitive_complexity.rs

…

collapsible_if.rs

…

comparison_chain.rs

…

copies.rs

…

copy_iterator.rs

…

crate_in_macro_def.rs

Shrink ast::Attribute.

2022-08-16 11:10:13 +10:00

create_dir.rs

…

dbg_macro.rs

…

default_instead_of_iter_empty.rs

…

default_numeric_fallback.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

default_union_representation.rs

…

default.rs

…

deprecated_lints.rs

…

dereference.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

derivable_impls.rs

fix wording for derivable_impls

2022-09-04 17:20:54 +02:00

derive.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

disallowed_methods.rs

…

disallowed_names.rs

…

disallowed_script_idents.rs

…

disallowed_types.rs

…

doc_link_with_quotes.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

doc.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

double_parens.rs

…

drop_forget_ref.rs

…

duplicate_mod.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

else_if_without_else.rs

…

empty_drop.rs

…

empty_enum.rs

…

empty_structs_with_brackets.rs

…

entry.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

enum_clike.rs

…

enum_variants.rs

…

equatable_if_let.rs

…

escape.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

eta_reduction.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

excessive_bools.rs

…

exhaustive_items.rs

…

exit.rs

…

explicit_write.rs

Auto merge of #101241 - camsteffen:refactor-binding-annotations, r=cjgillot

2022-09-06 03:16:29 +00:00

fallible_impl_from.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

float_literal.rs

…

floating_point_arithmetic.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

format_args.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

format_impl.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

format_push_string.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

format.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

formatting.rs

…

from_over_into.rs

…

from_str_radix_10.rs

…

future_not_send.rs

…

if_let_mutex.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

if_not_else.rs

…

if_then_some_else_none.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

implicit_hasher.rs

…

implicit_return.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

implicit_saturating_sub.rs

…

inconsistent_struct_constructor.rs

…

index_refutable_slice.rs

clippy: BindingAnnotation change

2022-09-02 13:03:11 -05:00

indexing_slicing.rs

…

infinite_iter.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

inherent_impl.rs

…

inherent_to_string.rs

…

init_numbered_fields.rs

…

inline_fn_without_body.rs

…

int_plus_one.rs

…

invalid_upcast_comparisons.rs

…

invalid_utf8_in_unchecked.rs

…

items_after_statements.rs

…

iter_not_returning_iterator.rs

…

large_const_arrays.rs

…

large_enum_variant.rs

Use approx_ty_size for large_enum_variant

2022-09-03 00:16:28 +02:00

large_include_file.rs

…

large_stack_arrays.rs

…

len_zero.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

let_if_seq.rs

clippy: BindingAnnotation change

2022-09-02 13:03:11 -05:00

let_underscore.rs

…

lib.deprecated.rs

…

lib.register_all.rs

New lint bool_to_int_with_if

2022-09-01 23:23:56 +02:00

lib.register_cargo.rs

…

lib.register_complexity.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

lib.register_correctness.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

lib.register_internal.rs

…

lib.register_lints.rs

Rename the arithmetic lint

2022-09-08 12:04:55 -03:00

lib.register_nursery.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

lib.register_pedantic.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

lib.register_perf.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

lib.register_restriction.rs

Rename the arithmetic lint

2022-09-08 12:04:55 -03:00

lib.register_style.rs

New lint bool_to_int_with_if

2022-09-01 23:23:56 +02:00

lib.register_suspicious.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

lib.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

lifetimes.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

literal_representation.rs

…

macro_use.rs

…

main_recursion.rs

…

manual_assert.rs

…

manual_async_fn.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

manual_bits.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

manual_instant_elapsed.rs

…

manual_non_exhaustive.rs

…

manual_rem_euclid.rs

…

manual_retain.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

manual_string_new.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

manual_strip.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

map_unit_fn.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

match_result_ok.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

mem_forget.rs

…

mem_replace.rs

…

minmax.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

misc.rs

clippy: BindingAnnotation change

2022-09-02 13:03:11 -05:00

mismatching_type_param_order.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

missing_const_for_fn.rs

…

missing_doc.rs

…

missing_enforced_import_rename.rs

…

missing_inline.rs

…

mixed_read_write_in_expression.rs

…

module_style.rs

…

multi_assignments.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

mut_key.rs

…

mut_mut.rs

…

mut_reference.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

mutable_debug_assertion.rs

…

mutex_atomic.rs

…

needless_arbitrary_self_type.rs

clippy: BindingAnnotation change

2022-09-02 13:03:11 -05:00

needless_bool.rs

…

needless_borrowed_ref.rs

clippy: BindingAnnotation change

2022-09-02 13:03:11 -05:00

needless_continue.rs

…

needless_for_each.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

needless_late_init.rs

clippy: BindingAnnotation change

2022-09-02 13:03:11 -05:00

needless_parens_on_range_literals.rs

…

needless_pass_by_value.rs

clippy: BindingAnnotation change

2022-09-02 13:03:11 -05:00

needless_question_mark.rs

…

needless_update.rs

…

neg_cmp_op_on_partial_ord.rs

…

neg_multiply.rs

…

new_without_default.rs

…

no_effect.rs

…

non_copy_const.rs

…

non_expressive_names.rs

…

non_octal_unix_permissions.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

non_send_fields_in_send_ty.rs

…

nonstandard_macro_braces.rs

…

octal_escapes.rs

Rename some things related to literals.

2022-08-16 13:41:34 +10:00

only_used_in_recursion.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

option_env_unwrap.rs

…

option_if_let_else.rs

clippy: BindingAnnotation change

2022-09-02 13:03:11 -05:00

overflow_check_conditional.rs

…

panic_in_result_fn.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

panic_unimplemented.rs

…

partialeq_ne_impl.rs

…

partialeq_to_none.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

pass_by_ref_or_value.rs

clippy: BindingAnnotation change

2022-09-02 13:03:11 -05:00

pattern_type_mismatch.rs

…

precedence.rs

…

ptr_offset_with_cast.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

ptr.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

pub_use.rs

…

question_mark.rs

Auto merge of #101241 - camsteffen:refactor-binding-annotations, r=cjgillot

2022-09-06 03:16:29 +00:00

ranges.rs

Fix range_{plus,minus}_one bad suggestions

2022-09-08 20:04:43 +02:00

rc_clone_in_vec_init.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

read_zero_byte_vec.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

redundant_clone.rs

Replace Body::basic_blocks() with field access

2022-08-26 14:27:08 +02:00

redundant_closure_call.rs

…

redundant_else.rs

…

redundant_field_names.rs

…

redundant_pub_crate.rs

…

redundant_slicing.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

redundant_static_lifetimes.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

ref_option_ref.rs

Make hir::PathSegment::res non-optional.

2022-09-05 14:20:25 +10:00

reference.rs

…

regex.rs

…

renamed_lints.rs

…

return_self_not_must_use.rs

…

returns.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

same_name_method.rs

…

self_named_constructors.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

semicolon_if_nothing_returned.rs

…

serde_api.rs

…

shadow.rs

…

single_char_lifetime_names.rs

…

single_component_path_imports.rs

…

size_of_in_element_count.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

slow_vector_initialization.rs

Auto merge of #101241 - camsteffen:refactor-binding-annotations, r=cjgillot

2022-09-06 03:16:29 +00:00

std_instead_of_core.rs

…

strings.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

strlen_on_c_strings.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

suspicious_operation_groupings.rs

…

suspicious_trait_impl.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

swap_ptr_to_ref.rs

…

swap.rs

…

tabs_in_doc_comments.rs

…

temporary_assignment.rs

…

to_digit_is_some.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

trailing_empty_array.rs

…

trait_bounds.rs

Make hir::PathSegment::res non-optional.

2022-09-05 14:20:25 +10:00

undocumented_unsafe_blocks.rs

…

unicode.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

uninit_vec.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

unit_return_expecting_ord.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

unnamed_address.rs

…

unnecessary_owned_empty_strings.rs

…

unnecessary_self_imports.rs

…

unnecessary_wraps.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

unnested_or_patterns.rs

clippy: BindingAnnotation change

2022-09-02 13:03:11 -05:00

unsafe_removed_from_name.rs

…

unused_async.rs

…

unused_io_amount.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

unused_peekable.rs

refactor: remove unnecessary variables

2022-09-05 22:31:02 +09:00

unused_rounding.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

unused_self.rs

…

unused_unit.rs

…

unwrap_in_result.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

unwrap.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

upper_case_acronyms.rs

…

use_self.rs

…

useless_conversion.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

vec_init_then_push.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

vec.rs

…

wildcard_imports.rs

…

write.rs

Merge remote-tracking branch 'upstream/auto' into rustup

2022-09-08 21:27:09 +02:00

zero_div_zero.rs

…

zero_sized_map_values.rs

…