rust/codegen at 53e5fd6a61b42eb4a401a8d0de58eb6f6b39b9d4 - rust

History

bors abd3637e42 Auto merge of #105545 - erikdesjardins:ptrclean, r=bjorn3

cleanup: remove pointee types

This can't be merged until the oldest LLVM version we support uses opaque pointers, which will be the case after #114148. (Also note `-Cllvm-args="-opaque-pointers=0"` can technically be used in LLVM 15, though I don't think we should support that configuration.)

I initially hoped this would provide some minor perf win, but in https://github.com/rust-lang/rust/pull/105412#issuecomment-1341224450 it had very little impact, so this is only valuable as a cleanup.

As a followup, this will enable #96242 to be resolved.

r? `@ghost`

`@rustbot` label S-blocked

2023-08-01 19:44:17 +00:00

auxiliary

…

avr

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

dllimports

…

instrument-xray

…

intrinsics

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

issues

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

loongarch-abi

…

non-terminate

…

remap_path_prefix

…

repr

Replace ignore-everything with only-arch

2023-07-29 15:49:07 -07:00

riscv-abi

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

simd-intrinsic

cg_llvm: simplify llvm.masked.gather/scatter naming with opaque pointers

2023-07-29 16:56:27 -04:00

src-hash-algorithm

…

unwind-abis

codegen: add needs-unwind to tests that require it

2023-05-23 16:54:35 +02:00

aarch64-struct-align-128.rs

aarch64-linux: properly handle 128bit aligned aggregates

2023-07-10 19:19:40 -04:00

abi-efiapi.rs

…

abi-main-signature-16bit-c-int.rs

Replace ignore-everything with only-arch

2023-07-29 15:49:07 -07:00

abi-main-signature-32bit-c-int.rs

Ignore an AVR-inapplicable test

2023-07-29 15:21:49 -07:00

abi-repr-ext.rs

…

abi-sysv64.rs

…

abi-x86_64_sysv.rs

…

abi-x86-interrupt.rs

…

addr-of-mutate.rs

Update the minimum external LLVM to 15

2023-07-27 14:07:08 -07:00

adjustments.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

align-byval-vector.rs

implement vector-containing aggregate alignment for x86 darwin

2023-07-10 19:19:36 -04:00

align-byval.rs

i686-windows: make requested alignment > 4 special case apply transitively

2023-07-14 17:48:13 -04:00

align-enum.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

align-fn.rs

…

align-offset.rs

Update the minimum external LLVM to 15

2023-07-27 14:07:08 -07:00

align-struct.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

alloc-optimisation.rs

Prevent insta-stable no alloc shim support

2023-05-11 14:35:09 +00:00

array-clone.rs

…

array-codegen.rs

Update the minimum external LLVM to 15

2023-07-27 14:07:08 -07:00

array-equality.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

array-map.rs

update array-map test for removed alloca

2023-07-10 19:19:35 -04:00

ascii-char.rs

…

asm-clobber_abi.rs

…

asm-clobbers.rs

…

asm-may_unwind.rs

…

asm-multiple-options.rs

…

asm-options.rs

…

asm-powerpc-clobbers.rs

…

asm-sanitize-llvm.rs

…

asm-target-clobbers.rs

…

async-fn-debug-awaitee-field.rs

…

async-fn-debug-msvc.rs

…

async-fn-debug.rs

…

atomic-operations.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

autovectorize-f32x4.rs

Test from_fn autovectorizes

2023-05-30 20:45:40 -07:00

binary-search-index-no-bound-check.rs

Stop checking for the absense of something that doesn't exist

2023-05-12 21:59:26 -07:00

bool-cmp.rs

…

box-maybe-uninit-llvm14.rs

codegen: allow the dso_local attribute

2023-05-23 16:54:33 +02:00

box-maybe-uninit.rs

Update the minimum external LLVM to 15

2023-07-27 14:07:08 -07:00

bpf-alu32.rs

…

branch-protection.rs

…

c-variadic-copy.rs

…

c-variadic-opt.rs

…

c-variadic.rs

…

call-llvm-intrinsics.rs

…

call-metadata.rs

codegen: allow extra attributes to functions when panic=abort

2023-05-23 16:54:30 +02:00

catch-unwind.rs

…

cdylib-external-inline-fns.rs

…

cf-protection.rs

…

cfguard-checks.rs

…

cfguard-disabled.rs

…

cfguard-nochecks.rs

…

cfguard-non-msvc.rs

…

codemodels.rs

…

coercions.rs

…

cold-call-declare-and-call.rs

…

comparison-operators-2-tuple.rs

Update the minimum external LLVM to 15

2023-07-27 14:07:08 -07:00

comparison-operators-newtype.rs

Update the minimum external LLVM to 15

2023-07-27 14:07:08 -07:00

const_scalar_pair.rs

Explain the reason for why a test exists

2023-05-31 14:07:16 +00:00

consts.rs

Update the minimum external LLVM to 15

2023-07-27 14:07:08 -07:00

dealloc-no-unwind.rs

…

debug-alignment.rs

…

debug-column-msvc.rs

…

debug-column.rs

codegen: allow extra attributes to functions when panic=abort

2023-05-23 16:54:30 +02:00

debug-compile-unit-path.rs

…

debug-limited.rs

…

debug-line-directives-only.rs

…

debug-line-tables-only.rs

…

debug-linkage-name.rs

…

debug-vtable.rs

Fix test

2023-05-11 14:35:10 +00:00

debuginfo-constant-locals.rs

…

debuginfo-generic-closure-env-names.rs

…

deduced-param-attrs.rs

…

default-requires-uwtable.rs

…

drop-in-place-noalias.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

drop.rs

codegen: add needs-unwind to tests that require it

2023-05-23 16:54:35 +02:00

dst-vtable-align-nonzero.rs

…

dst-vtable-size-range.rs

…

enable-lto-unit-splitting.rs

…

enum-bounds-check-derived-idx.rs

…

enum-bounds-check-issue-13926.rs

…

enum-bounds-check-issue-82871.rs

…

enum-bounds-check.rs

…

enum-debug-clike.rs

…

enum-debug-niche-2.rs

Fix codegen tests

2023-06-10 08:31:06 +00:00

enum-debug-niche.rs

…

enum-debug-tagged.rs

…

enum-discriminant-value.rs

…

enum-match.rs

Always name the return place.

2023-07-08 15:38:40 +02:00

enum-u128.rs

Add test

2023-06-10 16:58:51 +00:00

export-no-mangle.rs

…

external-no-mangle-fns.rs

…

external-no-mangle-statics.rs

codegen: allow the dso_local attribute

2023-05-23 16:54:33 +02:00

fastcall-inreg.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

fatptr.rs

…

fewer-names.rs

Always name the return place.

2023-07-08 15:38:40 +02:00

ffi-const.rs

…

ffi-out-of-bounds-loads.rs

…

ffi-pure.rs

…

ffi-returns-twice.rs

…

float_math.rs

…

fn-impl-trait-self.rs

…

foo.s

…

force-frame-pointers.rs

…

force-no-unwind-tables.rs

…

force-unwind-tables.rs

…

frame-pointer.rs

…

function-arguments-noopt.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

function-arguments.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

gdb_debug_script_load.rs

…

generator-debug-msvc.rs

…

generator-debug.rs

…

generic-debug.rs

…

global_asm_include.rs

Replace ignore-everything with only-arch

2023-07-29 15:49:07 -07:00

global_asm_x2.rs

Replace ignore-everything with only-arch

2023-07-29 15:49:07 -07:00

global_asm.rs

Replace ignore-everything with only-arch

2023-07-29 15:49:07 -07:00

i686-macosx-deployment-target.rs

…

i686-no-macosx-deployment-target.rs

…

inherit_overflow.rs

…

inline-always-works-always.rs

…

inline-debuginfo.rs

…

inline-function-args-debug-info.rs

…

inline-hint.rs

…

instrument-coverage.rs

…

instrument-mcount.rs

…

integer-cmp.rs

…

integer-overflow.rs

…

internalize-closures.rs

…

intrinsic-no-unnamed-attr.rs

…

iter-repeat-n-trivial-drop.rs

Get !nonnull metadata consistently in slice iterators, without needing assumes

2023-07-20 11:33:49 -07:00

layout-size-checks.rs

…

lifetime_start_end.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

link_section.rs

codegen: allow the dso_local attribute

2023-05-23 16:54:33 +02:00

link-dead-code.rs

…

llvm-ident.rs

Support .comment section like GCC/Clang (!llvm.ident)

2023-07-21 22:01:50 +02:00

loads.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

local-generics-in-exe-internalized.rs

…

lto-removes-invokes.rs

…

mainsubprogram.rs

…

mainsubprogramstart.rs

…

match-optimized.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

match-optimizes-away.rs

…

match-unoptimized.rs

…

mem-replace-big-type.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

mem-replace-simple-type.rs

Update the minimum external LLVM to 15

2023-07-27 14:07:08 -07:00

merge-functions.rs

…

mir_zst_stores.rs

…

mir-inlined-line-numbers.rs

codegen: allow extra attributes to functions when panic=abort

2023-05-23 16:54:30 +02:00

move-operands.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

naked-functions.rs

…

naked-nocoverage.rs

update codegent test to be independent of panic strategy

2023-06-14 12:52:02 +02:00

naked-noinline.rs

codegen: allow the dso_local attribute

2023-05-23 16:54:33 +02:00

no_builtins-at-crate.rs

Add the no-builtins attribute to functions when no_builtins is applied at the crate level.

2023-07-18 22:15:47 +08:00

no-assumes-on-casts.rs

…

no-dllimport-w-cross-lang-lto.rs

…

no-jump-tables.rs

…

no-plt.rs

…

noalias-box-off.rs

make noalias-box-off filecheck more precise

2023-05-20 19:41:28 -04:00

noalias-box.rs

…

noalias-flag.rs

…

noalias-refcell.rs

…

noalias-rwlockreadguard.rs

…

noalias-unpin.rs

…

noreturn-uninhabited.rs

…

noreturnflag.rs

…

nounwind.rs

…

nrvo.rs

…

optimize-attr-1.rs

…

option-as-slice.rs

…

option-nonzero-eq.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

packed.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

panic-abort-windows.rs

…

panic-in-drop-abort.rs

…

panic-unwind-default-uwtable.rs

…

personality_lifetimes.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

pgo-counter-bias.rs

…

pgo-instrumentation.rs

…

pic-relocation-model.rs

…

pie-relocation-model.rs

…

ptr-read-metadata.rs

codegen: allow the dso_local attribute

2023-05-23 16:54:33 +02:00

README.md

…

refs.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

repeat-trusted-len.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

sanitizer_memtag_attr_check.rs

…

sanitizer_scs_attr_check.rs

…

sanitizer-cfi-add-canonical-jump-tables-flag.rs

…

sanitizer-cfi-add-enable-split-lto-unit-flag.rs

…

sanitizer-cfi-emit-type-checks-attr-no-sanitize.rs

…

sanitizer-cfi-emit-type-checks.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

sanitizer-cfi-emit-type-metadata-attr-cfi-encoding.rs

…

sanitizer-cfi-emit-type-metadata-id-itanium-cxx-abi.rs

Fix a codegen test

2023-06-22 15:36:46 +00:00

sanitizer-cfi-emit-type-metadata-itanium-cxx-abi-generalized.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

sanitizer-cfi-emit-type-metadata-itanium-cxx-abi-normalized-generalized.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

sanitizer-cfi-emit-type-metadata-itanium-cxx-abi-normalized.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

sanitizer-cfi-emit-type-metadata-itanium-cxx-abi.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

sanitizer-cfi-emit-type-metadata-trait-objects.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

sanitizer-cfi-generalize-pointers.rs

…

sanitizer-cfi-normalize-integers.rs

…

sanitizer-kasan-emits-instrumentation.rs

…

sanitizer-kcfi-add-kcfi-flag.rs

…

sanitizer-kcfi-emit-kcfi-operand-bundle-attr-no-sanitize.rs

…

sanitizer-kcfi-emit-kcfi-operand-bundle-itanium-cxx-abi-generalized.rs

…

sanitizer-kcfi-emit-kcfi-operand-bundle-itanium-cxx-abi-normalized-generalized.rs

…

sanitizer-kcfi-emit-kcfi-operand-bundle-itanium-cxx-abi-normalized.rs

…

sanitizer-kcfi-emit-kcfi-operand-bundle-itanium-cxx-abi.rs

…

sanitizer-kcfi-emit-kcfi-operand-bundle.rs

…

sanitizer-kcfi-emit-type-metadata-trait-objects.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

sanitizer-memory-track-orgins.rs

…

sanitizer-no-sanitize-inlining.rs

…

sanitizer-no-sanitize.rs

…

sanitizer-recover.rs

…

sanitizer-safestack-attr-check.rs

Add SafeStack support to rustc

2023-05-26 15:18:54 -04:00

scalar-pair-bool.rs

…

set-discriminant-invalid.rs

…

simd_arith_offset.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

simd-wide-sum.rs

Reenable all cases of simd-wide-sum

2023-07-11 20:21:32 -07:00

slice_as_from_ptr_range.rs

Update the minimum external LLVM to 15

2023-07-27 14:07:08 -07:00

slice-as_chunks.rs

…

slice-indexing.rs

…

slice-init.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

slice-iter-fold.rs

add codegen test for slice::Iter::fold

2023-06-12 23:47:08 +02:00

slice-iter-len-eq-zero.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

slice-iter-nonnull.rs

Get !nonnull metadata consistently in slice iterators, without needing assumes

2023-07-20 11:33:49 -07:00

slice-position-bounds-check.rs

…

slice-ref-equality.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

slice-reverse.rs

…

slice-windows-no-bounds-check.rs

…

some-abis-do-extend-params-to-32-bits.rs

…

some-global-nonnull.rs

…

sparc-struct-abi.rs

…

split-lto-unit.rs

…

sse42-implies-crc32.rs

…

stack-probes-call.rs

…

stack-probes-inline.rs

…

stack-protector.rs

tests: be even more permissive on attributes in one test

2023-06-23 09:48:00 -04:00

static-relocation-model-msvc.rs

…

staticlib-external-inline-fns.rs

…

stores.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

swap-large-types.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

swap-simd-types.rs

Use load-store instead of memcpy for short integer arrays

2023-06-04 00:51:49 -07:00

swap-small-types.rs

Use load-store instead of memcpy for short integer arrays

2023-06-04 00:51:49 -07:00

target-cpu-on-functions.rs

…

target-feature-inline-closure.rs

Add codegen test ensuring always-inline closures don't bypass target features

2023-07-16 21:26:08 -04:00

target-feature-overrides.rs

…

thread-local.rs

…

tied-features-strength.rs

Create a structure to define the features from to_llvm_features.

2023-05-22 14:46:40 +01:00

to_vec.rs

…

transmute-optimized.rs

Update the minimum external LLVM to 15

2023-07-27 14:07:08 -07:00

transmute-scalar.rs

Update the minimum external LLVM to 15

2023-07-27 14:07:08 -07:00

try_identity.rs

…

try_question_mark_nop.rs

Update the minimum external LLVM to 15

2023-07-27 14:07:08 -07:00

tune-cpu-on-functions.rs

…

tuple-layout-opt.rs

codegen: allow the dso_local attribute

2023-05-23 16:54:33 +02:00

unchecked_shifts.rs

Update the minimum external LLVM to 15

2023-07-27 14:07:08 -07:00

unchecked-float-casts.rs

…

uninit-consts.rs

Update the minimum external LLVM to 15

2023-07-27 14:07:08 -07:00

union-abi.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

unpadded-simd.rs

…

unwind-and-panic-abort.rs

…

unwind-extern-exports.rs

codegen: add needs-unwind to tests that require it

2023-05-23 16:54:35 +02:00

unwind-extern-imports.rs

codegen: add needs-unwind to tests that require it

2023-05-23 16:54:35 +02:00

used_with_arg.rs

…

var-names.rs

Always name the return place.

2023-07-08 15:38:40 +02:00

vec-as-ptr.rs

CHECK only for opaque ptr

2023-07-27 14:44:13 -07:00

vec-calloc-llvm14.rs

…

vec-calloc.rs

Update the minimum external LLVM to 15

2023-07-27 14:07:08 -07:00

vec-in-place.rs

…

vec-iter-collect-len.rs

…

vec-optimizes-away.rs

Prevent insta-stable no alloc shim support

2023-05-11 14:35:09 +00:00

vec-shrink-panik.rs

use indexed loop instead of ptr bumping

2023-06-14 22:22:41 +02:00

vecdeque_no_panic.rs

…

virtual-function-elimination-32bit.rs

…

virtual-function-elimination.rs

…

wasm_casts_trapping.rs

…

wasm_exceptions.rs

add codegen-test: wasm-exceptions

2023-07-01 20:24:15 +02:00

x86_64-macosx-deployment-target.rs

…

x86_64-no-macosx-deployment-target.rs

…

zip.rs

…

zst-offset.rs

…

README.md

The files here use the LLVM FileCheck framework, documented at https://llvm.org/docs/CommandGuide/FileCheck.html.

One extension worth noting is the use of revisions as custom prefixes for FileCheck. If your codegen test has different behavior based on the chosen target or different compiler flags that you want to exercise, you can use a revisions annotation, like so:

// revisions: aaa bbb
// [bbb] compile-flags: --flags-for-bbb

After specifying those variations, you can write different expected, or explicitly unexpected output by using <prefix>-SAME: and <prefix>-NOT:, like so:

// CHECK: expected code
// aaa-SAME: emitted-only-for-aaa
// aaa-NOT:                        emitted-only-for-bbb
// bbb-NOT:  emitted-only-for-aaa
// bbb-SAME:                       emitted-only-for-bbb