rust/codegen at 5350edb9e8f4e194a2cad9a41b81d97a8ed52fab - rust

History

bors 039d887928 Auto merge of #119911 - NCGThompson:is-statically-known, r=oli-obk

Replacement of #114390: Add new intrinsic `is_var_statically_known` and optimize pow for powers of two

This adds a new intrinsic `is_val_statically_known` that lowers to [``@llvm.is.constant.*`](https://llvm.org/docs/LangRef.html#llvm-is-constant-intrinsic).` It also applies the intrinsic in the int_pow methods to recognize and optimize the idiom `2isize.pow(x)`. See #114390 for more discussion.

While I have extended the scope of the power of two optimization from #114390, I haven't added any new uses for the intrinsic. That can be done in later pull requests.

Note: When testing or using the library, be sure to use `--stage 1` or higher. Otherwise, the intrinsic will be a noop and the doctests will be skipped. If you are trying out edits, you may be interested in [`--keep-stage 0`](https://rustc-dev-guide.rust-lang.org/building/suggested.html#faster-builds-with---keep-stage).

Fixes #47234
Resolves #114390
`@Centri3`

2024-01-25 05:16:53 +00:00

auxiliary

…

avr

…

cffi

…

cross-crate-inlining

Add -Zcross-crate-inline-threshold=yes

2023-11-07 18:45:11 -05:00

debug-accessibility

Adapt debug-accessibility tests for msvc-style enums

2023-12-15 11:45:03 +00:00

dllimports

…

enum

…

instrument-xray

Automatically enable cross-crate inlining for small functions

2023-10-17 19:53:51 -04:00

intrinsics

Separate immediate and in-memory ScalarPair representation

2023-12-15 17:42:05 +01:00

issues

Remove uses of no-system-llvm

2024-01-23 10:31:07 +01:00

lib-optimizations

…

loongarch-abi

…

macos

…

naked-fn

…

non-terminate

…

remap_path_prefix

…

repr

…

riscv-abi

…

sanitizer

CFI: Add char to CFI integer normalization

2023-12-07 11:28:16 -08:00

simd

Update std::simd usage and test outputs

2023-11-26 09:02:25 -05:00

simd-intrinsic

Fix alignment passed down to LLVM for simd_masked_load

2023-12-12 13:11:59 +01:00

src-hash-algorithm

Automatically enable cross-crate inlining for small functions

2023-10-17 19:53:51 -04:00

unwind-abis

…

aarch64-struct-align-128.rs

…

abi-efiapi.rs

…

abi-main-signature-16bit-c-int.rs

…

abi-main-signature-32bit-c-int.rs

llvm: Allow noundef in codegen tests

2024-01-02 18:02:17 +00:00

abi-repr-ext.rs

…

abi-sysv64.rs

…

abi-x86_64_sysv.rs

…

abi-x86-interrupt.rs

…

addr-of-mutate.rs

…

adjustments.rs

…

align-byval-vector.rs

…

align-byval.rs

Separate immediate and in-memory ScalarPair representation

2023-12-15 17:42:05 +01:00

align-enum.rs

…

align-fn.rs

…

align-offset.rs

…

align-struct.rs

Separate immediate and in-memory ScalarPair representation

2023-12-15 17:42:05 +01:00

alloc-optimisation.rs

Remove uses of no-system-llvm

2024-01-23 10:31:07 +01:00

array-clone.rs

…

array-codegen.rs

Copy 1-element arrays as scalars, not vectors

2023-10-07 00:10:32 -07:00

array-equality.rs

…

array-map.rs

Remove uses of no-system-llvm

2024-01-23 10:31:07 +01:00

array-optimized.rs

Copy 1-element arrays as scalars, not vectors

2023-10-07 00:10:32 -07:00

ascii-char.rs

update test for new LLVM 18 codegen

2023-11-28 12:10:59 +00:00

asm-clobber_abi.rs

…

asm-clobbers.rs

…

asm-may_unwind.rs

…

asm-maybe-uninit.rs

…

asm-multiple-options.rs

…

asm-options.rs

…

asm-powerpc-clobbers.rs

…

asm-sanitize-llvm.rs

Automatically enable cross-crate inlining for small functions

2023-10-17 19:53:51 -04:00

asm-target-clobbers.rs

…

async-fn-debug-awaitee-field.rs

s/generator/coroutine/

2023-10-20 21:14:01 +00:00

async-fn-debug-msvc.rs

s/generator/coroutine/

2023-10-20 21:14:01 +00:00

async-fn-debug.rs

…

atomic-operations.rs

…

autovectorize-f32x4.rs

…

binary-search-index-no-bound-check.rs

…

bool-cmp.rs

…

box-uninit-bytes.rs

…

bpf-alu32.rs

…

branch-protection.rs

…

call-llvm-intrinsics.rs

…

call-metadata.rs

…

catch-unwind.rs

…

cdylib-external-inline-fns.rs

…

cf-protection.rs

…

cfguard-checks.rs

…

cfguard-disabled.rs

…

cfguard-nochecks.rs

…

cfguard-non-msvc.rs

…

char-ascii-branchless.rs

Refactor some char, u8 ascii functions to be branchless

2023-10-26 21:48:36 -04:00

codemodels.rs

…

coercions.rs

…

cold-call-declare-and-call.rs

…

comparison-operators-2-tuple.rs

…

comparison-operators-newtype.rs

…

const_scalar_pair.rs

…

consts.rs

…

coroutine-debug-msvc.rs

Rename lots of files that had generator in their name

2023-10-20 21:14:02 +00:00

coroutine-debug.rs

Rename lots of files that had generator in their name

2023-10-20 21:14:02 +00:00

dealloc-no-unwind.rs

Remove uses of no-system-llvm

2024-01-23 10:31:07 +01:00

debug-alignment.rs

…

debug-column-msvc.rs

…

debug-column.rs

…

debug-compile-unit-path.rs

…

debug-fndef-size.rs

Ignore MSVC in test.

2023-10-08 16:45:45 +00:00

debug-limited.rs

…

debug-line-directives-only.rs

…

debug-line-tables-only.rs

…

debug-linkage-name.rs

Automatically enable cross-crate inlining for small functions

2023-10-17 19:53:51 -04:00

debug-vtable.rs

…

debuginfo-constant-locals.rs

…

debuginfo-generic-closure-env-names.rs

…

debuginfo-inline-callsite-location.rs

Split out option::unwrap_failed like we have result::unwrap_failed

2024-01-14 12:45:01 -08:00

deduced-param-attrs.rs

…

default-hidden-visibility.rs

Add unstable -Zdefault-hidden-visibility cmdline flag for rustc.

2023-12-13 21:14:23 +00:00

default-requires-uwtable.rs

Automatically enable cross-crate inlining for small functions

2023-10-17 19:53:51 -04:00

drop-in-place-noalias.rs

…

drop.rs

Automatically enable cross-crate inlining for small functions

2023-10-17 19:53:51 -04:00

dst-vtable-align-nonzero.rs

…

dst-vtable-size-range.rs

…

ehcontguard_disabled.rs

Add support for generating the EHCont section

2023-11-21 13:41:23 -08:00

ehcontguard_enabled.rs

convert ehcont-guard to an unstable option

2023-11-21 14:24:23 -08:00

enable-lto-unit-splitting.rs

…

export-no-mangle.rs

…

external-no-mangle-fns.rs

…

external-no-mangle-statics.rs

…

fastcall-inreg.rs

…

fatptr.rs

…

fewer-names.rs

Remove uses of no-system-llvm

2024-01-23 10:31:07 +01:00

float_math.rs

…

fn-impl-trait-self.rs

…

foo.s

…

force-frame-pointers.rs

Automatically enable cross-crate inlining for small functions

2023-10-17 19:53:51 -04:00

force-no-unwind-tables.rs

…

force-unwind-tables.rs

Automatically enable cross-crate inlining for small functions

2023-10-17 19:53:51 -04:00

frame-pointer.rs

…

function-arguments-noopt.rs

Separate immediate and in-memory ScalarPair representation

2023-12-15 17:42:05 +01:00

function-arguments.rs

Separate immediate and in-memory ScalarPair representation

2023-12-15 17:42:05 +01:00

function-return.rs

Add -Zfunction-return={keep,thunk-extern} option

2023-11-30 20:21:31 +01:00

gdb_debug_script_load.rs

…

generic-debug.rs

…

global_asm_include.rs

…

global_asm_x2.rs

…

global_asm.rs

…

i128-x86-align.rs

Directly use volatile_load intrinsic

2024-01-19 10:52:01 +01:00

infallible-unwrap-in-opt-z.rs

Tune the inlinability of Result::unwrap

2024-01-12 10:57:58 -08:00

inherit_overflow.rs

Replace legacy ConstProp by GVN.

2023-12-24 20:08:57 +00:00

inline-always-works-always.rs

…

inline-debuginfo.rs

…

inline-function-args-debug-info.rs

Automatically enable cross-crate inlining for small functions

2023-10-17 19:53:51 -04:00

inline-hint.rs

…

instrument-coverage-off.rs

coverage: Add UI tests for values accepted by -Cinstrument-coverage

2023-10-23 17:41:40 +11:00

instrument-coverage.rs

coverage: Add UI tests for values accepted by -Cinstrument-coverage

2023-10-23 17:41:40 +11:00

instrument-mcount.rs

Automatically enable cross-crate inlining for small functions

2023-10-17 19:53:51 -04:00

integer-cmp.rs

…

integer-overflow.rs

Remove uses of no-system-llvm

2024-01-23 10:31:07 +01:00

internalize-closures.rs

…

intrinsic-no-unnamed-attr.rs

…

is_val_statically_known.rs

Further Implement is_val_statically_known

2024-01-23 12:02:31 -05:00

issue-97217.rs

Limit to LLVM 17.0.2 to work around WinEH codegen bug

2023-10-02 11:06:38 +02:00

iter-repeat-n-trivial-drop.rs

…

layout-size-checks.rs

…

lifetime_start_end.rs

…

link_section.rs

…

link-dead-code.rs

…

llvm_module_flags.rs

Add -Z llvm_module_flag

2023-11-11 19:48:47 -08:00

llvm-ident.rs

…

loads.rs

…

local-generics-in-exe-internalized.rs

…

lto-removes-invokes.rs

…

mainsubprogram.rs

…

mainsubprogramstart.rs

…

match-optimized.rs

…

match-optimizes-away.rs

Remove uses of no-system-llvm

2024-01-23 10:31:07 +01:00

match-unoptimized.rs

…

maybeuninit-rvo.rs

Add codegen test for RVO on MaybeUninit

2024-01-03 21:18:07 +01:00

mem-replace-big-type.rs

…

mem-replace-simple-type.rs

…

merge-functions.rs

…

method-declaration.rs

…

mir_zst_stores.rs

…

mir-inlined-line-numbers.rs

…

move-before-nocapture-ref-arg.rs

…

move-operands.rs

…

no_builtins-at-crate.rs

…

no-assumes-on-casts.rs

…

no-dllimport-w-cross-lang-lto.rs

…

no-jump-tables.rs

…

no-plt.rs

…

noalias-box-off.rs

…

noalias-box.rs

…

noalias-flag.rs

…

noalias-refcell.rs

…

noalias-rwlockreadguard.rs

…

noalias-unpin.rs

…

noreturn-uninhabited.rs

…

noreturnflag.rs

…

nounwind.rs

…

nrvo.rs

…

optimize-attr-1.rs

…

option-as-slice.rs

…

option-nonzero-eq.rs

…

overaligned-constant.rs

tests: fix overaligned-constant to not over-specify getelementptr instr

2023-12-21 15:53:28 -05:00

packed.rs

…

panic-abort-windows.rs

…

panic-in-drop-abort.rs

…

panic-unwind-default-uwtable.rs

Automatically enable cross-crate inlining for small functions

2023-10-17 19:53:51 -04:00

personality_lifetimes.rs

Make test compatible with 32-bit as well

2024-01-05 11:45:57 +01:00

pgo-counter-bias.rs

…

pgo-instrumentation.rs

…

pic-relocation-model.rs

…

pie-relocation-model.rs

…

pow_of_two.rs

Further Implement Power of Two Optimization

2024-01-23 12:03:50 -05:00

ptr-arithmetic.rs

…

ptr-read-metadata.rs

Remove uses of no-system-llvm

2024-01-23 10:31:07 +01:00

README.md

…

refs.rs

Separate immediate and in-memory ScalarPair representation

2023-12-15 17:42:05 +01:00

repeat-trusted-len.rs

…

scalar-pair-bool.rs

Separate immediate and in-memory ScalarPair representation

2023-12-15 17:42:05 +01:00

set-discriminant-invalid.rs

…

slice_as_from_ptr_range.rs

…

slice-as_chunks.rs

Remove uses of no-system-llvm

2024-01-23 10:31:07 +01:00

slice-indexing.rs

…

slice-init.rs

…

slice-iter-fold.rs

Update the minimum external LLVM to 16.

2023-11-21 22:40:16 +01:00

slice-iter-len-eq-zero.rs

Remove uses of no-system-llvm

2024-01-23 10:31:07 +01:00

slice-iter-nonnull.rs

Remove uses of no-system-llvm

2024-01-23 10:31:07 +01:00

slice-position-bounds-check.rs

Remove uses of no-system-llvm

2024-01-23 10:31:07 +01:00

slice-ref-equality.rs

…

slice-reverse.rs

…

slice-windows-no-bounds-check.rs

…

some-abis-do-extend-params-to-32-bits.rs

…

some-global-nonnull.rs

…

sparc-struct-abi.rs

llvm: Allow noundef in codegen tests

2024-01-02 18:02:17 +00:00

split-lto-unit.rs

…

sroa-fragment-debuginfo.rs

…

sse42-implies-crc32.rs

…

stack-probes-inline.rs

Enable stack probes on aarch64 for LLVM 18

2023-12-07 17:17:00 -08:00

stack-protector.rs

…

static-relocation-model-msvc.rs

…

staticlib-external-inline-fns.rs

…

stores.rs

…

swap-large-types.rs

…

swap-small-types.rs

Tweak the threshold for chunked swapping

2024-01-19 23:00:34 -08:00

target-cpu-on-functions.rs

Automatically enable cross-crate inlining for small functions

2023-10-17 19:53:51 -04:00

target-feature-inline-closure.rs

Don't accidentally detect the commit hash as an fadd instruction

2023-10-10 16:59:49 +11:00

target-feature-overrides.rs

…

thin-lto.rs

Add thinlto support to codegen, assembly and coverage tests

2023-11-30 18:48:03 +08:00

thread-local.rs

…

tied-features-strength.rs

Automatically enable cross-crate inlining for small functions

2023-10-17 19:53:51 -04:00

to_vec.rs

…

trailing_zeros.rs

…

transmute-optimized.rs

…

transmute-scalar.rs

…

try_identity.rs

…

try_question_mark_nop.rs

…

tune-cpu-on-functions.rs

Automatically enable cross-crate inlining for small functions

2023-10-17 19:53:51 -04:00

tuple-layout-opt.rs

…

unchecked_shifts.rs

tests: update check for inferred nneg on zext

2023-11-13 10:43:33 -05:00

unchecked-float-casts.rs

…

uninit-consts.rs

…

union-abi.rs

…

unwind-and-panic-abort.rs

…

unwind-extern-exports.rs

…

unwind-extern-imports.rs

…

unwind-landingpad-cold.rs

Limit to LLVM 17.0.2 to work around WinEH codegen bug

2023-10-02 11:06:38 +02:00

unwind-landingpad-inline.rs

Limit to LLVM 17.0.2 to work around WinEH codegen bug

2023-10-02 11:06:38 +02:00

used_with_arg.rs

…

var-names.rs

…

vec_pop_push_noop.rs

update codegen tests

2024-01-22 15:46:32 +01:00

vec-as-ptr.rs

…

vec-calloc.rs

…

vec-in-place.rs

Update the minimum external LLVM to 16.

2023-11-21 22:40:16 +01:00

vec-iter-collect-len.rs

Remove uses of no-system-llvm

2024-01-23 10:31:07 +01:00

vec-iter.rs

mark vec::IntoIter pointers as !nonnull

2024-01-07 03:44:04 +01:00

vec-optimizes-away.rs

Remove uses of no-system-llvm

2024-01-23 10:31:07 +01:00

vec-reserve-extend.rs

update codegen tests

2024-01-22 15:46:32 +01:00

vec-shrink-panik.rs

…

vecdeque_no_panic.rs

…

vecdeque-nonempty-get-no-panic.rs

…

virtual-function-elimination-32bit.rs

…

virtual-function-elimination.rs

…

wasm_casts_trapping.rs

…

wasm_exceptions.rs

…

zip.rs

…

zst-offset.rs

Address review comments

2024-01-02 15:03:14 +01:00

README.md

The files here use the LLVM FileCheck framework, documented at https://llvm.org/docs/CommandGuide/FileCheck.html.

One extension worth noting is the use of revisions as custom prefixes for FileCheck. If your codegen test has different behavior based on the chosen target or different compiler flags that you want to exercise, you can use a revisions annotation, like so:

// revisions: aaa bbb
// [bbb] compile-flags: --flags-for-bbb

After specifying those variations, you can write different expected, or explicitly unexpected output by using <prefix>-SAME: and <prefix>-NOT:, like so:

// CHECK: expected code
// aaa-SAME: emitted-only-for-aaa
// aaa-NOT:                        emitted-only-for-bbb
// bbb-NOT:  emitted-only-for-aaa
// bbb-SAME:                       emitted-only-for-bbb