168 lines
2.8 KiB
Rust
168 lines
2.8 KiB
Rust
//@run-rustfix
|
|
|
|
#![warn(clippy::bool_comparison)]
|
|
|
|
fn main() {
|
|
let x = true;
|
|
if x {
|
|
"yes"
|
|
} else {
|
|
"no"
|
|
};
|
|
if !x {
|
|
"yes"
|
|
} else {
|
|
"no"
|
|
};
|
|
if x {
|
|
"yes"
|
|
} else {
|
|
"no"
|
|
};
|
|
if !x {
|
|
"yes"
|
|
} else {
|
|
"no"
|
|
};
|
|
if !x {
|
|
"yes"
|
|
} else {
|
|
"no"
|
|
};
|
|
if x {
|
|
"yes"
|
|
} else {
|
|
"no"
|
|
};
|
|
if !x {
|
|
"yes"
|
|
} else {
|
|
"no"
|
|
};
|
|
if x {
|
|
"yes"
|
|
} else {
|
|
"no"
|
|
};
|
|
if !x {
|
|
"yes"
|
|
} else {
|
|
"no"
|
|
};
|
|
if x {
|
|
"yes"
|
|
} else {
|
|
"no"
|
|
};
|
|
if x {
|
|
"yes"
|
|
} else {
|
|
"no"
|
|
};
|
|
if !x {
|
|
"yes"
|
|
} else {
|
|
"no"
|
|
};
|
|
let y = true;
|
|
if !x & y {
|
|
"yes"
|
|
} else {
|
|
"no"
|
|
};
|
|
if x & !y {
|
|
"yes"
|
|
} else {
|
|
"no"
|
|
};
|
|
}
|
|
|
|
#[allow(dead_code)]
|
|
fn issue3703() {
|
|
struct Foo;
|
|
impl PartialEq<bool> for Foo {
|
|
fn eq(&self, _: &bool) -> bool {
|
|
true
|
|
}
|
|
}
|
|
impl PartialEq<Foo> for bool {
|
|
fn eq(&self, _: &Foo) -> bool {
|
|
true
|
|
}
|
|
}
|
|
impl PartialOrd<bool> for Foo {
|
|
fn partial_cmp(&self, _: &bool) -> Option<std::cmp::Ordering> {
|
|
None
|
|
}
|
|
}
|
|
impl PartialOrd<Foo> for bool {
|
|
fn partial_cmp(&self, _: &Foo) -> Option<std::cmp::Ordering> {
|
|
None
|
|
}
|
|
}
|
|
|
|
if Foo == true {}
|
|
if true == Foo {}
|
|
if Foo != true {}
|
|
if true != Foo {}
|
|
if Foo == false {}
|
|
if false == Foo {}
|
|
if Foo != false {}
|
|
if false != Foo {}
|
|
if Foo < false {}
|
|
if false < Foo {}
|
|
}
|
|
|
|
#[allow(dead_code)]
|
|
fn issue4983() {
|
|
let a = true;
|
|
let b = false;
|
|
|
|
if a != b {};
|
|
if a != b {};
|
|
if a == b {};
|
|
if !a == !b {};
|
|
|
|
if b != a {};
|
|
if b != a {};
|
|
if b == a {};
|
|
if !b == !a {};
|
|
}
|
|
|
|
macro_rules! m {
|
|
($func:ident) => {
|
|
$func()
|
|
};
|
|
}
|
|
|
|
fn func() -> bool {
|
|
true
|
|
}
|
|
|
|
#[allow(dead_code)]
|
|
fn issue3973() {
|
|
// ok, don't lint on `cfg` invocation
|
|
if false == cfg!(feature = "debugging") {}
|
|
if cfg!(feature = "debugging") == false {}
|
|
if true == cfg!(feature = "debugging") {}
|
|
if cfg!(feature = "debugging") == true {}
|
|
|
|
// lint, could be simplified
|
|
if !m!(func) {}
|
|
if !m!(func) {}
|
|
if m!(func) {}
|
|
if m!(func) {}
|
|
|
|
// no lint with a variable
|
|
let is_debug = false;
|
|
if is_debug == cfg!(feature = "debugging") {}
|
|
if cfg!(feature = "debugging") == is_debug {}
|
|
if is_debug == m!(func) {}
|
|
if m!(func) == is_debug {}
|
|
let is_debug = true;
|
|
if is_debug == cfg!(feature = "debugging") {}
|
|
if cfg!(feature = "debugging") == is_debug {}
|
|
if is_debug == m!(func) {}
|
|
if m!(func) == is_debug {}
|
|
}
|