d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
90 lines
2.6 KiB
Rust
90 lines
2.6 KiB
Rust
//! lint when items are used after statements
|
|
|
|
use clippy_utils::diagnostics::span_lint;
|
|
use rustc_ast::ast::{Block, ItemKind, StmtKind};
|
|
use rustc_lint::{EarlyContext, EarlyLintPass};
|
|
use rustc_middle::lint::in_external_macro;
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for items declared after some statement in a block.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// Items live for the entire scope they are declared
|
|
/// in. But statements are processed in order. This might cause confusion as
|
|
/// it's hard to figure out which item is meant in a statement.
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// // Bad
|
|
/// fn foo() {
|
|
/// println!("cake");
|
|
/// }
|
|
///
|
|
/// fn main() {
|
|
/// foo(); // prints "foo"
|
|
/// fn foo() {
|
|
/// println!("foo");
|
|
/// }
|
|
/// foo(); // prints "foo"
|
|
/// }
|
|
/// ```
|
|
///
|
|
/// ```rust
|
|
/// // Good
|
|
/// fn foo() {
|
|
/// println!("cake");
|
|
/// }
|
|
///
|
|
/// fn main() {
|
|
/// fn foo() {
|
|
/// println!("foo");
|
|
/// }
|
|
/// foo(); // prints "foo"
|
|
/// foo(); // prints "foo"
|
|
/// }
|
|
/// ```
|
|
#[clippy::version = "pre 1.29.0"]
|
|
pub ITEMS_AFTER_STATEMENTS,
|
|
pedantic,
|
|
"blocks where an item comes after a statement"
|
|
}
|
|
|
|
declare_lint_pass!(ItemsAfterStatements => [ITEMS_AFTER_STATEMENTS]);
|
|
|
|
impl EarlyLintPass for ItemsAfterStatements {
|
|
fn check_block(&mut self, cx: &EarlyContext<'_>, item: &Block) {
|
|
if in_external_macro(cx.sess, item.span) {
|
|
return;
|
|
}
|
|
|
|
// skip initial items and trailing semicolons
|
|
let stmts = item
|
|
.stmts
|
|
.iter()
|
|
.map(|stmt| &stmt.kind)
|
|
.skip_while(|s| matches!(**s, StmtKind::Item(..) | StmtKind::Empty));
|
|
|
|
// lint on all further items
|
|
for stmt in stmts {
|
|
if let StmtKind::Item(ref it) = *stmt {
|
|
if in_external_macro(cx.sess, it.span) {
|
|
return;
|
|
}
|
|
if let ItemKind::MacroDef(..) = it.kind {
|
|
// do not lint `macro_rules`, but continue processing further statements
|
|
continue;
|
|
}
|
|
span_lint(
|
|
cx,
|
|
ITEMS_AFTER_STATEMENTS,
|
|
it.span,
|
|
"adding items after statements is confusing, since items exist from the \
|
|
start of the scope",
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|