d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
83 lines
3.2 KiB
Rust
83 lines
3.2 KiB
Rust
//! lint on C-like enums that are `repr(isize/usize)` and have values that
|
|
//! don't fit into an `i32`
|
|
|
|
use clippy_utils::consts::{miri_to_const, Constant};
|
|
use clippy_utils::diagnostics::span_lint;
|
|
use rustc_hir::{Item, ItemKind};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_middle::ty::util::IntTypeExt;
|
|
use rustc_middle::ty::{self, IntTy, UintTy};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
use std::convert::TryFrom;
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for C-like enumerations that are
|
|
/// `repr(isize/usize)` and have values that don't fit into an `i32`.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// This will truncate the variant value on 32 bit
|
|
/// architectures, but works fine on 64 bit.
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// # #[cfg(target_pointer_width = "64")]
|
|
/// #[repr(usize)]
|
|
/// enum NonPortable {
|
|
/// X = 0x1_0000_0000,
|
|
/// Y = 0,
|
|
/// }
|
|
/// ```
|
|
#[clippy::version = "pre 1.29.0"]
|
|
pub ENUM_CLIKE_UNPORTABLE_VARIANT,
|
|
correctness,
|
|
"C-like enums that are `repr(isize/usize)` and have values that don't fit into an `i32`"
|
|
}
|
|
|
|
declare_lint_pass!(UnportableVariant => [ENUM_CLIKE_UNPORTABLE_VARIANT]);
|
|
|
|
impl<'tcx> LateLintPass<'tcx> for UnportableVariant {
|
|
#[allow(clippy::cast_possible_truncation, clippy::cast_possible_wrap, clippy::cast_sign_loss)]
|
|
fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx Item<'_>) {
|
|
if cx.tcx.data_layout.pointer_size.bits() != 64 {
|
|
return;
|
|
}
|
|
if let ItemKind::Enum(def, _) = &item.kind {
|
|
for var in def.variants {
|
|
if let Some(anon_const) = &var.disr_expr {
|
|
let def_id = cx.tcx.hir().body_owner_def_id(anon_const.body);
|
|
let mut ty = cx.tcx.type_of(def_id.to_def_id());
|
|
let constant = cx
|
|
.tcx
|
|
.const_eval_poly(def_id.to_def_id())
|
|
.ok()
|
|
.map(|val| rustc_middle::ty::Const::from_value(cx.tcx, val, ty));
|
|
if let Some(Constant::Int(val)) = constant.and_then(miri_to_const) {
|
|
if let ty::Adt(adt, _) = ty.kind() {
|
|
if adt.is_enum() {
|
|
ty = adt.repr.discr_type().to_ty(cx.tcx);
|
|
}
|
|
}
|
|
match ty.kind() {
|
|
ty::Int(IntTy::Isize) => {
|
|
let val = ((val as i128) << 64) >> 64;
|
|
if i32::try_from(val).is_ok() {
|
|
continue;
|
|
}
|
|
},
|
|
ty::Uint(UintTy::Usize) if val > u128::from(u32::MAX) => {},
|
|
_ => continue,
|
|
}
|
|
span_lint(
|
|
cx,
|
|
ENUM_CLIKE_UNPORTABLE_VARIANT,
|
|
var.span,
|
|
"C-like enum variant discriminant is not portable to 32-bit targets",
|
|
);
|
|
};
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|