7f928d150e
declared with the same name in the same scope.
This breaks several common patterns. First are unused imports:
use foo::bar;
use baz::bar;
Change this code to the following:
use baz::bar;
Second, this patch breaks globs that import names that are shadowed by
subsequent imports. For example:
use foo::*; // including `bar`
use baz::bar;
Change this code to remove the glob:
use foo::{boo, quux};
use baz::bar;
Or qualify all uses of `bar`:
use foo::{boo, quux};
use baz;
... baz::bar ...
Finally, this patch breaks code that, at top level, explicitly imports
`std` and doesn't disable the prelude.
extern crate std;
Because the prelude imports `std` implicitly, there is no need to
explicitly import it; just remove such directives.
The old behavior can be opted into via the `import_shadowing` feature
gate. Use of this feature gate is discouraged.
This implements RFC #116.
Closes #16464.
[breaking-change]
88 lines
2.9 KiB
Rust
88 lines
2.9 KiB
Rust
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
|
|
// file at the top-level directory of this distribution and at
|
|
// http://rust-lang.org/COPYRIGHT.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
// option. This file may not be copied, modified, or distributed
|
|
// except according to those terms.
|
|
|
|
use llvm::*;
|
|
use middle::trans::cabi::{ArgType, FnType};
|
|
use middle::trans::type_::Type;
|
|
use super::common::*;
|
|
use super::machine::*;
|
|
use syntax::abi::{OsWindows, OsMacos, OsiOS};
|
|
|
|
pub fn compute_abi_info(ccx: &CrateContext,
|
|
atys: &[Type],
|
|
rty: Type,
|
|
ret_def: bool) -> FnType {
|
|
let mut arg_tys = Vec::new();
|
|
|
|
let ret_ty;
|
|
if !ret_def {
|
|
ret_ty = ArgType::direct(Type::void(ccx), None, None, None);
|
|
} else if rty.kind() == Struct {
|
|
// Returning a structure. Most often, this will use
|
|
// a hidden first argument. On some platforms, though,
|
|
// small structs are returned as integers.
|
|
//
|
|
// Some links:
|
|
// http://www.angelcode.com/dev/callconv/callconv.html
|
|
// Clang's ABI handling is in lib/CodeGen/TargetInfo.cpp
|
|
|
|
enum Strategy { RetValue(Type), RetPointer }
|
|
let strategy = match ccx.sess().targ_cfg.os {
|
|
OsWindows | OsMacos | OsiOS => {
|
|
match llsize_of_alloc(ccx, rty) {
|
|
1 => RetValue(Type::i8(ccx)),
|
|
2 => RetValue(Type::i16(ccx)),
|
|
4 => RetValue(Type::i32(ccx)),
|
|
8 => RetValue(Type::i64(ccx)),
|
|
_ => RetPointer
|
|
}
|
|
}
|
|
_ => {
|
|
RetPointer
|
|
}
|
|
};
|
|
|
|
match strategy {
|
|
RetValue(t) => {
|
|
ret_ty = ArgType::direct(rty, Some(t), None, None);
|
|
}
|
|
RetPointer => {
|
|
ret_ty = ArgType::indirect(rty, Some(StructRetAttribute));
|
|
}
|
|
}
|
|
} else {
|
|
let attr = if rty == Type::i1(ccx) { Some(ZExtAttribute) } else { None };
|
|
ret_ty = ArgType::direct(rty, None, None, attr);
|
|
}
|
|
|
|
for &t in atys.iter() {
|
|
let ty = match t.kind() {
|
|
Struct => {
|
|
let size = llsize_of_alloc(ccx, t);
|
|
if size == 0 {
|
|
ArgType::ignore(t)
|
|
} else {
|
|
ArgType::indirect(t, Some(ByValAttribute))
|
|
}
|
|
}
|
|
_ => {
|
|
let attr = if t == Type::i1(ccx) { Some(ZExtAttribute) } else { None };
|
|
ArgType::direct(t, None, None, attr)
|
|
}
|
|
};
|
|
arg_tys.push(ty);
|
|
}
|
|
|
|
return FnType {
|
|
arg_tys: arg_tys,
|
|
ret_ty: ret_ty,
|
|
};
|
|
}
|