e444cbe5d6
* Finding pattern slices for `avoidable_slice_indexing` * `avoidable_slice_indexing` analysing slice usage * Add configuration to `avoidable_slice_indexing` * Emitting `avoidable_slice_indexing` with suggestions * Dogfooding and fixing bugs * Add ui-toml test for `avoidable_slice_indexing` * Correctly suggest `ref` keywords for `avoidable_slice_indexing` * Test and document `mut` for `avoid_slice_indexing` * Handle macros with `avoidable_slice_indexing` lint * Ignore slices with sub patterns in `avoidable_slice_indexing` * Update lint description for `avoidable_slice_indexing` * Move `avoidable_slice_indexing` to nursery * Added more tests for `avoidable_slice_indexing` * Update documentation and message for `avoidable_slice_indexing` * Teach `avoidable_slice_indexing` about `HirId`s and `Visitors` * Rename lint to `index_refutable_slice` and connected config
79 lines
1.6 KiB
Rust
79 lines
1.6 KiB
Rust
#![allow(clippy::redundant_clone)]
|
|
#![warn(clippy::manual_non_exhaustive)]
|
|
|
|
use std::ops::Deref;
|
|
|
|
mod enums {
|
|
enum E {
|
|
A,
|
|
B,
|
|
#[doc(hidden)]
|
|
_C,
|
|
}
|
|
|
|
// user forgot to remove the marker
|
|
#[non_exhaustive]
|
|
enum Ep {
|
|
A,
|
|
B,
|
|
#[doc(hidden)]
|
|
_C,
|
|
}
|
|
}
|
|
|
|
fn option_as_ref_deref() {
|
|
let mut opt = Some(String::from("123"));
|
|
|
|
let _ = opt.as_ref().map(String::as_str);
|
|
let _ = opt.as_ref().map(|x| x.as_str());
|
|
let _ = opt.as_mut().map(String::as_mut_str);
|
|
let _ = opt.as_mut().map(|x| x.as_mut_str());
|
|
}
|
|
|
|
fn match_like_matches() {
|
|
let _y = match Some(5) {
|
|
Some(0) => true,
|
|
_ => false,
|
|
};
|
|
}
|
|
|
|
fn match_same_arms() {
|
|
match (1, 2, 3) {
|
|
(1, .., 3) => 42,
|
|
(.., 3) => 42, //~ ERROR match arms have same body
|
|
_ => 0,
|
|
};
|
|
}
|
|
|
|
fn match_same_arms2() {
|
|
let _ = match Some(42) {
|
|
Some(_) => 24,
|
|
None => 24, //~ ERROR match arms have same body
|
|
};
|
|
}
|
|
|
|
fn manual_strip_msrv() {
|
|
let s = "hello, world!";
|
|
if s.starts_with("hello, ") {
|
|
assert_eq!(s["hello, ".len()..].to_uppercase(), "WORLD!");
|
|
}
|
|
}
|
|
|
|
fn check_index_refutable_slice() {
|
|
// This shouldn't trigger `clippy::index_refutable_slice` as the suggestion
|
|
// would only be valid from 1.42.0 onward
|
|
let slice: Option<&[u32]> = Some(&[1]);
|
|
if let Some(slice) = slice {
|
|
println!("{}", slice[0]);
|
|
}
|
|
}
|
|
|
|
fn main() {
|
|
option_as_ref_deref();
|
|
match_like_matches();
|
|
match_same_arms();
|
|
match_same_arms2();
|
|
manual_strip_msrv();
|
|
check_index_refutable_slice();
|
|
}
|