de48274c50
Fix #3192. r? anyone There are 4 different new tests, to check some different scenarios for what the parse context is at the time of recovery, becasue our compile-fail infrastructure does not appear to handle verifying error-recovery situations. Differentiate between unit-like struct definition item and unit-like struct construction in the error message. ---- More generally, outlines a more generic strategy for parse error recovery: By committing to an expression/statement at set points in the parser, we can then do some look-ahead to catch common mistakes and skip over them. One detail about this strategy is that you want to avoid emitting the "helpful" message unless the input is reasonably close to the case of interest. (E.g. do not warn about a potential unit struct for an input of the form `let hmm = do foo { } { };`) To accomplish this, I added (partial) last_token tracking; used for `commit_stmt` support. The check_for_erroneous_unit_struct_expecting fn returns bool to signal whether it "made progress"; currently unused; this is meant for use to compose several such recovery checks together in a loop. |
||
|---|---|---|
| .. | ||
| ext | ||
| parse | ||
| util | ||
| abi.rs | ||
| ast_map.rs | ||
| ast_util.rs | ||
| ast.rs | ||
| attr.rs | ||
| codemap.rs | ||
| diagnostic.rs | ||
| fold.rs | ||
| oldvisit.rs | ||
| opt_vec.rs | ||
| syntax.rs | ||
| visit.rs | ||