af46699f81
Instead of updating global state to mark attributes as used, we now explicitly emit a warning when an attribute is used in an unsupported position. As a side effect, we are to emit more detailed warning messages (instead of just a generic "unused" message). `Session.check_name` is removed, since its only purpose was to mark the attribute as used. All of the callers are modified to use `Attribute.has_name` Additionally, `AttributeType::AssumedUsed` is removed - an 'assumed used' attribute is implemented by simply not performing any checks in `CheckAttrVisitor` for a particular attribute. We no longer emit unused attribute warnings for the `#[rustc_dummy]` attribute - it's an internal attribute used for tests, so it doesn't mark sense to treat it as 'unused'. With this commit, a large source of global untracked state is removed.
79 lines
2.9 KiB
Rust
79 lines
2.9 KiB
Rust
//! Walks the crate looking for items/impl-items/trait-items that have
|
|
//! either a `rustc_symbol_name` or `rustc_def_path` attribute and
|
|
//! generates an error giving, respectively, the symbol name or
|
|
//! def-path. This is used for unit testing the code that generates
|
|
//! paths etc in all kinds of annoying scenarios.
|
|
|
|
use rustc_hir as hir;
|
|
use rustc_hir::def_id::LocalDefId;
|
|
use rustc_middle::ty::print::with_no_trimmed_paths;
|
|
use rustc_middle::ty::{subst::InternalSubsts, Instance, TyCtxt};
|
|
use rustc_span::symbol::{sym, Symbol};
|
|
|
|
const SYMBOL_NAME: Symbol = sym::rustc_symbol_name;
|
|
const DEF_PATH: Symbol = sym::rustc_def_path;
|
|
|
|
pub fn report_symbol_names(tcx: TyCtxt<'_>) {
|
|
// if the `rustc_attrs` feature is not enabled, then the
|
|
// attributes we are interested in cannot be present anyway, so
|
|
// skip the walk.
|
|
if !tcx.features().rustc_attrs {
|
|
return;
|
|
}
|
|
|
|
tcx.dep_graph.with_ignore(|| {
|
|
let mut visitor = SymbolNamesTest { tcx };
|
|
tcx.hir().krate().visit_all_item_likes(&mut visitor);
|
|
})
|
|
}
|
|
|
|
struct SymbolNamesTest<'tcx> {
|
|
tcx: TyCtxt<'tcx>,
|
|
}
|
|
|
|
impl SymbolNamesTest<'tcx> {
|
|
fn process_attrs(&mut self, def_id: LocalDefId) {
|
|
let tcx = self.tcx;
|
|
for attr in tcx.get_attrs(def_id.to_def_id()).iter() {
|
|
if attr.has_name(SYMBOL_NAME) {
|
|
let def_id = def_id.to_def_id();
|
|
let instance = Instance::new(
|
|
def_id,
|
|
tcx.erase_regions(InternalSubsts::identity_for_item(tcx, def_id)),
|
|
);
|
|
let mangled = tcx.symbol_name(instance);
|
|
tcx.sess.span_err(attr.span, &format!("symbol-name({})", mangled));
|
|
if let Ok(demangling) = rustc_demangle::try_demangle(mangled.name) {
|
|
tcx.sess.span_err(attr.span, &format!("demangling({})", demangling));
|
|
tcx.sess.span_err(attr.span, &format!("demangling-alt({:#})", demangling));
|
|
}
|
|
} else if attr.has_name(DEF_PATH) {
|
|
let path = with_no_trimmed_paths(|| tcx.def_path_str(def_id.to_def_id()));
|
|
tcx.sess.span_err(attr.span, &format!("def-path({})", path));
|
|
}
|
|
|
|
// (*) The formatting of `tag({})` is chosen so that tests can elect
|
|
// to test the entirety of the string, if they choose, or else just
|
|
// some subset.
|
|
}
|
|
}
|
|
}
|
|
|
|
impl hir::itemlikevisit::ItemLikeVisitor<'tcx> for SymbolNamesTest<'tcx> {
|
|
fn visit_item(&mut self, item: &'tcx hir::Item<'tcx>) {
|
|
self.process_attrs(item.def_id);
|
|
}
|
|
|
|
fn visit_trait_item(&mut self, trait_item: &'tcx hir::TraitItem<'tcx>) {
|
|
self.process_attrs(trait_item.def_id);
|
|
}
|
|
|
|
fn visit_impl_item(&mut self, impl_item: &'tcx hir::ImplItem<'tcx>) {
|
|
self.process_attrs(impl_item.def_id);
|
|
}
|
|
|
|
fn visit_foreign_item(&mut self, foreign_item: &'tcx hir::ForeignItem<'tcx>) {
|
|
self.process_attrs(foreign_item.def_id);
|
|
}
|
|
}
|