bb1ee8746e
`os_local` impl of `thread_local` — regardless of whether it is const and unlike other implementations — includes an `fn __init(): EXPR`. Existing implementation of the lint checked for the presence of said function and whether the expr can be made const. Because for `os_local` we always have an `__init()`, it triggers for const implementations. The solution is to check whether the `__init()` function is already const. If it is `const`, there is nothing to do. Otherwise, we verify that we can make it const. Co-authored-by: Alejandra González <blyxyas@gmail.com>
42 lines
2.1 KiB
Plaintext
42 lines
2.1 KiB
Plaintext
error: initializer for `thread_local` value can be made `const`
|
|
--> tests/ui/thread_local_initializer_can_be_made_const.rs:8:41
|
|
|
|
|
LL | static BUF_1: RefCell<String> = RefCell::new(String::new());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `const { RefCell::new(String::new()) }`
|
|
|
|
|
= note: `-D clippy::thread-local-initializer-can-be-made-const` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::thread_local_initializer_can_be_made_const)]`
|
|
|
|
error: initializer for `thread_local` value can be made `const`
|
|
--> tests/ui/thread_local_initializer_can_be_made_const.rs:18:29
|
|
|
|
|
LL | static SIMPLE:i32 = 1;
|
|
| ^ help: replace with: `const { 1 }`
|
|
|
|
error: initializer for `thread_local` value can be made `const`
|
|
--> tests/ui/thread_local_initializer_can_be_made_const.rs:24:59
|
|
|
|
|
LL | static BUF_3_CAN_BE_MADE_CONST: RefCell<String> = RefCell::new(String::new());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `const { RefCell::new(String::new()) }`
|
|
|
|
error: initializer for `thread_local` value can be made `const`
|
|
--> tests/ui/thread_local_initializer_can_be_made_const.rs:26:59
|
|
|
|
|
LL | static BUF_4_CAN_BE_MADE_CONST: RefCell<String> = RefCell::new(String::new());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `const { RefCell::new(String::new()) }`
|
|
|
|
error: initializer for `thread_local` value can be made `const`
|
|
--> tests/ui/thread_local_initializer_can_be_made_const.rs:32:31
|
|
|
|
|
LL | static PEEL_ME: i32 = { 1 };
|
|
| ^^^^^ help: replace with: `const { 1 }`
|
|
|
|
error: initializer for `thread_local` value can be made `const`
|
|
--> tests/ui/thread_local_initializer_can_be_made_const.rs:34:36
|
|
|
|
|
LL | static PEEL_ME_MANY: i32 = { let x = 1; x * x };
|
|
| ^^^^^^^^^^^^^^^^^^^^ help: replace with: `const { { let x = 1; x * x } }`
|
|
|
|
error: aborting due to 6 previous errors
|
|
|