Matthias Krüger 363d158cd8 Rollup merge of #111215 - BoxyUwU:resolve_anon_consts_differently, r=cjgillot ... Various changes to name resolution of anon consts Sorry this PR is kind of all over the place ^^' Fixes #111012 - Rewrites anon const nameres to all go through `fn resolve_anon_const` explicitly instead of `visit_anon_const` to ensure that we do not accidentally resolve anon consts as if they are allowed to use generics when they aren't. Also means that we dont have bits of code for resolving anon consts that will get out of sync (i.e. legacy const generics and resolving path consts that were parsed as type arguments) - Renames two of the `LifetimeRibKind`, `AnonConst -> ConcreteAnonConst` and `ConstGeneric -> ConstParamTy` - Noticed while doing this that under `generic_const_exprs` all lifetimes currently get resolved to errors without any error being emitted which was causing a bunch of tests to pass without their bugs having been fixed, incidentally fixed that in this PR and marked those tests as `// known-bug:`. I'm fine to break those since `generic_const_exprs` is a very unstable incomplete feature and this PR _does_ make generic_const_exprs "less broken" as a whole, also I can't be assed to figure out what the underlying causes of all of them are. This PR reopens #77357 #83993 - Changed `generics_of` to stop providing generics and predicates to enum variant discriminant anon consts since those are not allowed to use generic parameters - Updated the error for non 'static lifetime in const arguments and the error for non 'static lifetime in const param tys to use `derive(Diagnostic)` I have a vague idea why const-arg-in-const-arg.rs, in-closure.rs and simple.rs have started failing which is unfortunate since these were deliberately made to work, I think lifetime resolution being broken just means this regressed at some point and nobody noticed because the tests were not testing anything :( I'm fine breaking these too for the same reason as the tests for #77357 #83993. I couldn't get `// known-bug` to work for these ICEs and just kept getting different stderr between CI and local `--bless` so I just removed them and will create an issue to track re-adding (and fixing) the bugs if this PR lands. r? `@cjgillot` cc `@compiler-errors`		2023-05-09 20:49:32 +02:00
..
adt_const_params	--bless ConstParamTy ui tests	2023-04-27 17:26:59 +00:00
array-impls
auxiliary
backcompat
defaults	update tests/ui	2023-04-07 18:07:11 +10:00
early	const generic -> const parameter in err msg	2023-02-20 12:58:11 +01:00
generic_arg_infer
generic_const_exprs	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
infer	diagnostics: update test cases to refer to assoc fn with self as method	2023-02-22 08:40:47 -07:00
issues	Rollup merge of #111215 - BoxyUwU:resolve_anon_consts_differently, r=cjgillot	2023-05-09 20:49:32 +02:00
late-bound-vars	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
min_const_generics	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
occurs-check	vars are ?	2023-04-25 19:53:09 +00:00
parser-error-recovery	diagnostics: remove inconsistent English article "this" from E0107	2023-02-23 10:27:06 -07:00
std
type-dependent
apit-with-const-param.rs
arg-in-pat-1.rs
arg-in-pat-2.rs
arg-in-pat-3.rs
argument_order.rs
argument_order.stderr
array-wrapper-struct-ctor.rs
assoc_const_as_type_argument.rs	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
assoc_const_as_type_argument.stderr	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
assoc_const_eq_diagnostic.rs	Don't use implied trait predicates in gather_explicit_predicates_of	2023-05-01 15:45:28 +00:00
assoc_const_eq_diagnostic.stderr	Don't use implied trait predicates in gather_explicit_predicates_of	2023-05-01 15:45:28 +00:00
associated-type-bound-fail.rs
associated-type-bound-fail.stderr
associated-type-bound.rs
bad-const-generic-exprs.rs
bad-const-generic-exprs.stderr
bad-generic-in-copy-impl.rs	Suppress copy impl error when post-normalized type references errors	2023-03-08 00:12:33 +00:00
bad-generic-in-copy-impl.stderr	Suppress copy impl error when post-normalized type references errors	2023-03-08 00:12:33 +00:00
bad-subst-const-kind.rs	Constrain const vars to error if const types are mismatched	2023-03-19 03:45:47 +00:00
bad-subst-const-kind.stderr	Constrain const vars to error if const types are mismatched	2023-03-19 03:45:47 +00:00
broken-mir-1.rs
broken-mir-2.rs
cannot-infer-type-for-const-param.rs
coerce_unsized_array.rs
concrete-const-as-fn-arg.rs
concrete-const-impl-method.rs
condition-in-trait-const-arg.rs
const_trait_fn-issue-88433.rs
const-arg-in-const-arg.min.stderr	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
const-arg-in-const-arg.rs	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
const-arg-in-fn.rs
const-arg-type-arg-misordered.rs
const-arg-type-arg-misordered.stderr
const-argument-cross-crate-mismatch.rs
const-argument-cross-crate-mismatch.stderr
const-argument-cross-crate.rs
const-argument-if-length.full.stderr
const-argument-if-length.min.stderr
const-argument-if-length.rs
const-argument-non-static-lifetime.min.stderr	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
const-argument-non-static-lifetime.rs	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
const-fn-with-const-param.rs
const-generic-default-wont-borrowck.rs
const-generic-default-wont-borrowck.stderr
const-generic-function.rs
const-generic-function.stderr
const-generic-type_name.rs
const-param-after-const-literal-arg.rs
const-param-before-other-params.rs
const-param-before-other-params.stderr
const-param-elided-lifetime.full.stderr
const-param-elided-lifetime.min.stderr
const-param-elided-lifetime.rs
const-param-in-async.rs
const-param-type-depends-on-const-param.full.stderr	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
const-param-type-depends-on-const-param.min.stderr	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
const-param-type-depends-on-const-param.rs
const-param-type-depends-on-type-param-ungated.rs	Remove save-analysis.	2023-02-16 15:14:45 +11:00
const-param-type-depends-on-type-param-ungated.stderr	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
const-param-type-depends-on-type-param.full.stderr	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
const-param-type-depends-on-type-param.min.stderr	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
const-param-type-depends-on-type-param.rs
const-parameter-uppercase-lint.rs
const-parameter-uppercase-lint.stderr
core-types.rs
cross_crate_complex.rs
deref-into-array-generic.rs
different_generic_args_array.rs
different_generic_args_array.stderr
different_generic_args.full.stderr
different_generic_args.min.stderr
different_generic_args.rs
dont-evaluate-array-len-on-err-1.rs
dont-evaluate-array-len-on-err-1.stderr
dyn-supertraits.rs
ensure_is_evaluatable.rs
ensure_is_evaluatable.stderr	Specify what 'this' actually is	2023-02-21 05:21:07 +00:00
enum-variants.rs
exhaustive-value.rs
exhaustive-value.stderr
expose-default-substs-param-env.rs
float-generic.adt_const_params.stderr
float-generic.rs
float-generic.simple.stderr
fn_with_two_const_inputs.rs
fn_with_two_const_inputs.stderr	Specify what 'this' actually is	2023-02-21 05:21:07 +00:00
fn_with_two_same_const_inputs.rs
fn-const-param-call.full.stderr
fn-const-param-call.min.stderr
fn-const-param-call.rs
fn-const-param-infer.full.stderr
fn-const-param-infer.min.stderr
fn-const-param-infer.rs
forbid-non-structural_match-types.rs
forbid-non-structural_match-types.stderr
foreign-item-const-parameter.rs
foreign-item-const-parameter.stderr
generic-param-mismatch.rs
generic-param-mismatch.stderr
ice-68875.rs
ice-68875.stderr
ice-const-generic-function-return-ty.rs
ice-const-generic-function-return-ty.stderr
impl-const-generic-struct.rs
incorrect-number-of-const-args.rs
incorrect-number-of-const-args.stderr	diagnostics: remove inconsistent English article "this" from E0107	2023-02-23 10:27:06 -07:00
infer_arg_from_pat.rs
infer_arr_len_from_pat.rs
inhabited-assoc-ty-ice-1.rs
inhabited-assoc-ty-ice-2.rs
integer-literal-generic-arg-in-where-clause.rs
intrinsics-type_name-as-const-argument.min.stderr
intrinsics-type_name-as-const-argument.rs
invalid-const-arg-for-type-param.rs	diagnostics: remove inconsistent English article "this" from E0107	2023-02-23 10:27:06 -07:00
invalid-const-arg-for-type-param.stderr	diagnostics: remove inconsistent English article "this" from E0107	2023-02-23 10:27:06 -07:00
invalid-constant-in-args.rs	diagnostics: remove inconsistent English article "this" from E0107	2023-02-23 10:27:06 -07:00
invalid-constant-in-args.stderr	diagnostics: remove inconsistent English article "this" from E0107	2023-02-23 10:27:06 -07:00
invalid-enum.rs
invalid-enum.stderr
invariant.rs
invariant.stderr
issue-46511.rs	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
issue-46511.stderr	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
issue-66451.rs
issue-66451.stderr
issue-70408.rs
issue-80471.rs
issue-80471.stderr
issue-93647.rs	Move const trait bounds checks to MIR constck	2023-03-28 08:39:55 +00:00
issue-93647.stderr	Move const trait bounds checks to MIR constck	2023-03-28 08:39:55 +00:00
issue-97007.rs
issue-102124.rs
issue-105689.rs
issue-106419-struct-with-multiple-const-params.rs
legacy-const-generics-bad.rs
legacy-const-generics-bad.stderr
legacy-const-generics.rs
nested-type.full.stderr
nested-type.min.stderr	add predicate evaluation logic	2023-02-17 09:32:39 +00:00
nested-type.rs	fixup tests wrt new normalization	2023-04-28 11:56:02 +00:00
outer-lifetime-in-const-generic-default.rs	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
outer-lifetime-in-const-generic-default.stderr	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
overlapping_impls.rs
params-in-ct-in-ty-param-lazy-norm.full.stderr
params-in-ct-in-ty-param-lazy-norm.min.stderr
params-in-ct-in-ty-param-lazy-norm.rs
parent_generics_of_encoding_impl_trait.rs
parent_generics_of_encoding_impl_trait.stderr
parent_generics_of_encoding.rs
projection-as-arg-const.rs
projection-as-arg-const.stderr
promotion.rs
raw-ptr-const-param-deref.full.stderr
raw-ptr-const-param-deref.min.stderr
raw-ptr-const-param-deref.rs
raw-ptr-const-param.full.stderr
raw-ptr-const-param.min.stderr
raw-ptr-const-param.rs
slice-const-param-mismatch.full.stderr
slice-const-param-mismatch.min.stderr
slice-const-param-mismatch.rs
slice-const-param.rs
sneaky-array-repeat-expr.rs	check array type of repeat exprs is wf	2023-05-04 11:22:40 +01:00
sneaky-array-repeat-expr.stderr	check array type of repeat exprs is wf	2023-05-04 11:22:40 +01:00
struct-with-invalid-const-param.rs
struct-with-invalid-const-param.stderr
suggest_const_for_array.rs
suggest_const_for_array.stderr
trait-const-args.rs
transmute_no_gate.rs	Add feature gate	2023-04-07 11:18:07 -07:00
transmute_no_gate.stderr	Add feature gate	2023-04-07 11:18:07 -07:00
transmute-const-param-static-reference.min.stderr
transmute-const-param-static-reference.rs
transmute-fail.rs	Add feature gate	2023-04-07 11:18:07 -07:00
transmute-fail.stderr	Add feature gate	2023-04-07 11:18:07 -07:00
transmute.rs	Add feature gate	2023-04-07 11:18:07 -07:00
transparent-maybeunit-array-wrapper.rs
try_unify_ignore_lifetimes.rs
two_matching_preds.rs
type_mismatch.rs	Use param's real type in try_eval_lit_or_param	2023-03-09 20:49:11 +00:00
type_mismatch.stderr	Note type mismatch on ConstArgHasType	2023-03-23 19:09:34 +00:00
type_not_in_scope.rs	Use param's real type in try_eval_lit_or_param	2023-03-09 20:49:11 +00:00
type_not_in_scope.stderr	Use param's real type in try_eval_lit_or_param	2023-03-09 20:49:11 +00:00
type_of_anon_const.rs
type-after-const-ok.rs
types-mismatch-const-args.full.stderr
types-mismatch-const-args.min.stderr
types-mismatch-const-args.rs
unify_with_nested_expr.rs
unify_with_nested_expr.stderr	Specify what 'this' actually is	2023-02-21 05:21:07 +00:00
uninferred-consts-during-codegen-1.rs
uninferred-consts-during-codegen-2.rs
unknown_adt.rs
unknown_adt.stderr
unused_braces.fixed
unused_braces.full.fixed
unused_braces.min.fixed
unused_braces.rs
unused_braces.stderr
unused-const-param.rs
unused-type-param-suggestion.rs
unused-type-param-suggestion.stderr
variant-discrimiant-no-generics.full.stderr	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
variant-discrimiant-no-generics.min.stderr	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
variant-discrimiant-no-generics.rs	improve diagnostics and bless tests	2023-05-05 21:42:54 +01:00
where-clauses.rs
wrong-normalization.rs
wrong-normalization.stderr	Tighter spans for bad inherent impl types	2023-02-13 18:41:18 +00:00