eb3970285b
In order to switch `clippy::uninlined_format_args` from pedantic to style, all existing tests must not raise a warning. I did not want to change the actual tests, so this is a relatively minor change that: * add `#![allow(clippy::uninlined_format_args)]` where needed * normalizes all allow/deny/warn attributes * all allow attributes are grouped together * sorted alphabetically * the `clippy::*` attributes are listed separate from the other ones. * deny and warn attributes are listed before the allowed ones changelog: none
104 lines
2.9 KiB
Rust
104 lines
2.9 KiB
Rust
// run-rustfix
|
|
#![warn(clippy::expect_fun_call)]
|
|
#![allow(clippy::to_string_in_format_args, clippy::uninlined_format_args)]
|
|
|
|
/// Checks implementation of the `EXPECT_FUN_CALL` lint
|
|
|
|
macro_rules! one {
|
|
() => {
|
|
1
|
|
};
|
|
}
|
|
|
|
fn main() {
|
|
struct Foo;
|
|
|
|
impl Foo {
|
|
fn new() -> Self {
|
|
Foo
|
|
}
|
|
|
|
fn expect(&self, msg: &str) {
|
|
panic!("{}", msg)
|
|
}
|
|
}
|
|
|
|
let with_some = Some("value");
|
|
with_some.expect("error");
|
|
|
|
let with_none: Option<i32> = None;
|
|
with_none.expect("error");
|
|
|
|
let error_code = 123_i32;
|
|
let with_none_and_format: Option<i32> = None;
|
|
with_none_and_format.unwrap_or_else(|| panic!("Error {}: fake error", error_code));
|
|
|
|
let with_none_and_as_str: Option<i32> = None;
|
|
with_none_and_as_str.unwrap_or_else(|| panic!("Error {}: fake error", error_code));
|
|
|
|
let with_none_and_format_with_macro: Option<i32> = None;
|
|
with_none_and_format_with_macro.unwrap_or_else(|| panic!("Error {}: fake error", one!()));
|
|
|
|
let with_ok: Result<(), ()> = Ok(());
|
|
with_ok.expect("error");
|
|
|
|
let with_err: Result<(), ()> = Err(());
|
|
with_err.expect("error");
|
|
|
|
let error_code = 123_i32;
|
|
let with_err_and_format: Result<(), ()> = Err(());
|
|
with_err_and_format.unwrap_or_else(|_| panic!("Error {}: fake error", error_code));
|
|
|
|
let with_err_and_as_str: Result<(), ()> = Err(());
|
|
with_err_and_as_str.unwrap_or_else(|_| panic!("Error {}: fake error", error_code));
|
|
|
|
let with_dummy_type = Foo::new();
|
|
with_dummy_type.expect("another test string");
|
|
|
|
let with_dummy_type_and_format = Foo::new();
|
|
with_dummy_type_and_format.expect(&format!("Error {}: fake error", error_code));
|
|
|
|
let with_dummy_type_and_as_str = Foo::new();
|
|
with_dummy_type_and_as_str.expect(format!("Error {}: fake error", error_code).as_str());
|
|
|
|
//Issue #2937
|
|
Some("foo").unwrap_or_else(|| panic!("{} {}", 1, 2));
|
|
|
|
//Issue #2979 - this should not lint
|
|
{
|
|
let msg = "bar";
|
|
Some("foo").expect(msg);
|
|
}
|
|
|
|
{
|
|
fn get_string() -> String {
|
|
"foo".to_string()
|
|
}
|
|
|
|
fn get_static_str() -> &'static str {
|
|
"foo"
|
|
}
|
|
|
|
fn get_non_static_str(_: &u32) -> &str {
|
|
"foo"
|
|
}
|
|
|
|
Some("foo").unwrap_or_else(|| { panic!("{}", get_string()) });
|
|
Some("foo").unwrap_or_else(|| { panic!("{}", get_string()) });
|
|
Some("foo").unwrap_or_else(|| { panic!("{}", get_string()) });
|
|
|
|
Some("foo").unwrap_or_else(|| { panic!("{}", get_static_str()) });
|
|
Some("foo").unwrap_or_else(|| { panic!("{}", get_non_static_str(&0).to_string()) });
|
|
}
|
|
|
|
//Issue #3839
|
|
Some(true).unwrap_or_else(|| panic!("key {}, {}", 1, 2));
|
|
|
|
//Issue #4912 - the receiver is a &Option
|
|
{
|
|
let opt = Some(1);
|
|
let opt_ref = &opt;
|
|
opt_ref.unwrap_or_else(|| panic!("{:?}", opt_ref));
|
|
}
|
|
}
|