eb3970285b
In order to switch `clippy::uninlined_format_args` from pedantic to style, all existing tests must not raise a warning. I did not want to change the actual tests, so this is a relatively minor change that: * add `#![allow(clippy::uninlined_format_args)]` where needed * normalizes all allow/deny/warn attributes * all allow attributes are grouped together * sorted alphabetically * the `clippy::*` attributes are listed separate from the other ones. * deny and warn attributes are listed before the allowed ones changelog: none
122 lines
3.6 KiB
Plaintext
122 lines
3.6 KiB
Plaintext
error: all if blocks contain the same code at the start
|
|
--> $DIR/shared_at_top.rs:11:5
|
|
|
|
|
LL | / if true {
|
|
LL | | println!("Hello World!");
|
|
| |_________________________________^
|
|
|
|
|
note: the lint level is defined here
|
|
--> $DIR/shared_at_top.rs:1:9
|
|
|
|
|
LL | #![deny(clippy::branches_sharing_code, clippy::if_same_then_else)]
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
help: consider moving these statements before the if
|
|
|
|
|
LL ~ println!("Hello World!");
|
|
LL + if true {
|
|
|
|
|
|
|
error: all if blocks contain the same code at the start
|
|
--> $DIR/shared_at_top.rs:20:5
|
|
|
|
|
LL | / if x == 0 {
|
|
LL | | let y = 9;
|
|
LL | | println!("The value y was set to: `{}`", y);
|
|
LL | | let _z = y;
|
|
| |___________________^
|
|
|
|
|
= warning: some moved values might need to be renamed to avoid wrong references
|
|
help: consider moving these statements before the if
|
|
|
|
|
LL ~ let y = 9;
|
|
LL + println!("The value y was set to: `{}`", y);
|
|
LL + let _z = y;
|
|
LL + if x == 0 {
|
|
|
|
|
|
|
error: all if blocks contain the same code at the start
|
|
--> $DIR/shared_at_top.rs:41:5
|
|
|
|
|
LL | / let _ = if x == 7 {
|
|
LL | | let y = 16;
|
|
| |___________________^
|
|
|
|
|
help: consider moving these statements before the if
|
|
|
|
|
LL ~ let y = 16;
|
|
LL + let _ = if x == 7 {
|
|
|
|
|
|
|
error: all if blocks contain the same code at the start
|
|
--> $DIR/shared_at_top.rs:59:5
|
|
|
|
|
LL | / if x == 10 {
|
|
LL | | let used_value_name = "Different type";
|
|
LL | | println!("Str: {}", used_value_name);
|
|
| |_____________________________________________^
|
|
|
|
|
= warning: some moved values might need to be renamed to avoid wrong references
|
|
help: consider moving these statements before the if
|
|
|
|
|
LL ~ let used_value_name = "Different type";
|
|
LL + println!("Str: {}", used_value_name);
|
|
LL + if x == 10 {
|
|
|
|
|
|
|
error: all if blocks contain the same code at the start
|
|
--> $DIR/shared_at_top.rs:73:5
|
|
|
|
|
LL | / if x == 11 {
|
|
LL | | let can_be_overridden = "Move me";
|
|
LL | | println!("I'm also moveable");
|
|
| |______________________________________^
|
|
|
|
|
= warning: some moved values might need to be renamed to avoid wrong references
|
|
help: consider moving these statements before the if
|
|
|
|
|
LL ~ let can_be_overridden = "Move me";
|
|
LL + println!("I'm also moveable");
|
|
LL + if x == 11 {
|
|
|
|
|
|
|
error: all if blocks contain the same code at the start
|
|
--> $DIR/shared_at_top.rs:89:5
|
|
|
|
|
LL | / if x == 2020 {
|
|
LL | | println!("This should trigger the `SHARED_CODE_IN_IF_BLOCKS` lint.");
|
|
LL | | println!("Because `IF_SAME_THEN_ELSE` is allowed here");
|
|
| |________________________________________________________________^
|
|
|
|
|
help: consider moving these statements before the if
|
|
|
|
|
LL ~ println!("This should trigger the `SHARED_CODE_IN_IF_BLOCKS` lint.");
|
|
LL + println!("Because `IF_SAME_THEN_ELSE` is allowed here");
|
|
LL + if x == 2020 {
|
|
|
|
|
|
|
error: this `if` has identical blocks
|
|
--> $DIR/shared_at_top.rs:97:18
|
|
|
|
|
LL | if x == 2019 {
|
|
| __________________^
|
|
LL | | println!("This should trigger `IS_SAME_THAN_ELSE` as usual");
|
|
LL | | } else {
|
|
| |_____^
|
|
|
|
|
note: the lint level is defined here
|
|
--> $DIR/shared_at_top.rs:1:40
|
|
|
|
|
LL | #![deny(clippy::branches_sharing_code, clippy::if_same_then_else)]
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
note: same as this
|
|
--> $DIR/shared_at_top.rs:99:12
|
|
|
|
|
LL | } else {
|
|
| ____________^
|
|
LL | | println!("This should trigger `IS_SAME_THAN_ELSE` as usual");
|
|
LL | | }
|
|
| |_____^
|
|
|
|
error: aborting due to 7 previous errors
|
|
|