109 lines
2.2 KiB
Rust
109 lines
2.2 KiB
Rust
// run-rustfix
|
|
#![warn(clippy::option_if_let_else)]
|
|
#![allow(clippy::redundant_closure)]
|
|
#![allow(clippy::ref_option_ref)]
|
|
|
|
fn bad1(string: Option<&str>) -> (bool, &str) {
|
|
if let Some(x) = string {
|
|
(true, x)
|
|
} else {
|
|
(false, "hello")
|
|
}
|
|
}
|
|
|
|
fn else_if_option(string: Option<&str>) -> Option<(bool, &str)> {
|
|
if string.is_none() {
|
|
None
|
|
} else if let Some(x) = string {
|
|
Some((true, x))
|
|
} else {
|
|
Some((false, ""))
|
|
}
|
|
}
|
|
|
|
fn unop_bad(string: &Option<&str>, mut num: Option<i32>) {
|
|
let _ = if let Some(s) = *string { s.len() } else { 0 };
|
|
let _ = if let Some(s) = &num { s } else { &0 };
|
|
let _ = if let Some(s) = &mut num {
|
|
*s += 1;
|
|
s
|
|
} else {
|
|
&mut 0
|
|
};
|
|
let _ = if let Some(ref s) = num { s } else { &0 };
|
|
let _ = if let Some(mut s) = num {
|
|
s += 1;
|
|
s
|
|
} else {
|
|
0
|
|
};
|
|
let _ = if let Some(ref mut s) = num {
|
|
*s += 1;
|
|
s
|
|
} else {
|
|
&mut 0
|
|
};
|
|
}
|
|
|
|
fn longer_body(arg: Option<u32>) -> u32 {
|
|
if let Some(x) = arg {
|
|
let y = x * x;
|
|
y * y
|
|
} else {
|
|
13
|
|
}
|
|
}
|
|
|
|
fn impure_else(arg: Option<i32>) {
|
|
let side_effect = || {
|
|
println!("return 1");
|
|
1
|
|
};
|
|
let _ = if let Some(x) = arg {
|
|
x
|
|
} else {
|
|
// map_or_else must be suggested
|
|
side_effect()
|
|
};
|
|
}
|
|
|
|
fn test_map_or_else(arg: Option<u32>) {
|
|
let _ = if let Some(x) = arg {
|
|
x * x * x * x
|
|
} else {
|
|
let mut y = 1;
|
|
y = (y + 2 / y) / 2;
|
|
y = (y + 2 / y) / 2;
|
|
y
|
|
};
|
|
}
|
|
|
|
fn negative_tests(arg: Option<u32>) -> u32 {
|
|
let _ = if let Some(13) = arg { "unlucky" } else { "lucky" };
|
|
for _ in 0..10 {
|
|
let _ = if let Some(x) = arg {
|
|
x
|
|
} else {
|
|
continue;
|
|
};
|
|
}
|
|
let _ = if let Some(x) = arg {
|
|
return x;
|
|
} else {
|
|
5
|
|
};
|
|
7
|
|
}
|
|
|
|
fn main() {
|
|
let optional = Some(5);
|
|
let _ = if let Some(x) = optional { x + 2 } else { 5 };
|
|
let _ = bad1(None);
|
|
let _ = else_if_option(None);
|
|
unop_bad(&None, None);
|
|
let _ = longer_body(None);
|
|
test_map_or_else(None);
|
|
let _ = negative_tests(None);
|
|
let _ = impure_else(None);
|
|
}
|