07e7823c01
If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
33 lines
1.0 KiB
Rust
33 lines
1.0 KiB
Rust
// RFC 736 (and Issue 21407): functional struct update should respect privacy.
|
|
|
|
// The `foo` module attempts to maintains an invariant that each `S`
|
|
// has a unique `u64` id.
|
|
use self::foo::S;
|
|
mod foo {
|
|
use std::cell::{UnsafeCell};
|
|
|
|
static mut COUNT : UnsafeCell<u64> = UnsafeCell::new(1);
|
|
|
|
pub struct S { pub a: u8, pub b: String, secret_uid: u64 }
|
|
|
|
pub fn make_secrets(a: u8, b: String) -> S {
|
|
let val = unsafe { let p = COUNT.get(); let val = *p; *p = val + 1; val };
|
|
println!("creating {}, uid {}", b, val);
|
|
S { a: a, b: b, secret_uid: val }
|
|
}
|
|
|
|
impl Drop for S {
|
|
fn drop(&mut self) {
|
|
println!("dropping {}, uid {}", self.b, self.secret_uid);
|
|
}
|
|
}
|
|
}
|
|
|
|
fn main() {
|
|
let s_1 = foo::make_secrets(3, format!("ess one"));
|
|
let s_2 = foo::S { b: format!("ess two"), ..s_1 }; // FRU ...
|
|
//~^ ERROR field `secret_uid` of struct `S` is private
|
|
println!("main forged an S named: {}", s_2.b);
|
|
// at end of scope, ... both s_1 *and* s_2 get dropped. Boom!
|
|
}
|