d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
60 lines
2.0 KiB
Rust
60 lines
2.0 KiB
Rust
use clippy_utils::diagnostics::span_lint_hir;
|
|
use clippy_utils::is_automatically_derived;
|
|
use if_chain::if_chain;
|
|
use rustc_hir::{Impl, Item, ItemKind};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
use rustc_span::sym;
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for manual re-implementations of `PartialEq::ne`.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// `PartialEq::ne` is required to always return the
|
|
/// negated result of `PartialEq::eq`, which is exactly what the default
|
|
/// implementation does. Therefore, there should never be any need to
|
|
/// re-implement it.
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// struct Foo;
|
|
///
|
|
/// impl PartialEq for Foo {
|
|
/// fn eq(&self, other: &Foo) -> bool { true }
|
|
/// fn ne(&self, other: &Foo) -> bool { !(self == other) }
|
|
/// }
|
|
/// ```
|
|
#[clippy::version = "pre 1.29.0"]
|
|
pub PARTIALEQ_NE_IMPL,
|
|
complexity,
|
|
"re-implementing `PartialEq::ne`"
|
|
}
|
|
|
|
declare_lint_pass!(PartialEqNeImpl => [PARTIALEQ_NE_IMPL]);
|
|
|
|
impl<'tcx> LateLintPass<'tcx> for PartialEqNeImpl {
|
|
fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx Item<'_>) {
|
|
if_chain! {
|
|
if let ItemKind::Impl(Impl { of_trait: Some(ref trait_ref), items: impl_items, .. }) = item.kind;
|
|
let attrs = cx.tcx.hir().attrs(item.hir_id());
|
|
if !is_automatically_derived(attrs);
|
|
if let Some(eq_trait) = cx.tcx.lang_items().eq_trait();
|
|
if trait_ref.path.res.def_id() == eq_trait;
|
|
then {
|
|
for impl_item in impl_items {
|
|
if impl_item.ident.name == sym::ne {
|
|
span_lint_hir(
|
|
cx,
|
|
PARTIALEQ_NE_IMPL,
|
|
impl_item.id.hir_id(),
|
|
impl_item.span,
|
|
"re-implementing `PartialEq::ne` is unnecessary",
|
|
);
|
|
}
|
|
}
|
|
}
|
|
};
|
|
}
|
|
}
|