d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
61 lines
1.7 KiB
Rust
61 lines
1.7 KiB
Rust
use clippy_utils::diagnostics::span_lint_and_help;
|
|
use if_chain::if_chain;
|
|
use rustc_hir as hir;
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for division of integers
|
|
///
|
|
/// ### Why is this bad?
|
|
/// When outside of some very specific algorithms,
|
|
/// integer division is very often a mistake because it discards the
|
|
/// remainder.
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// // Bad
|
|
/// let x = 3 / 2;
|
|
/// println!("{}", x);
|
|
///
|
|
/// // Good
|
|
/// let x = 3f32 / 2f32;
|
|
/// println!("{}", x);
|
|
/// ```
|
|
#[clippy::version = "1.37.0"]
|
|
pub INTEGER_DIVISION,
|
|
restriction,
|
|
"integer division may cause loss of precision"
|
|
}
|
|
|
|
declare_lint_pass!(IntegerDivision => [INTEGER_DIVISION]);
|
|
|
|
impl<'tcx> LateLintPass<'tcx> for IntegerDivision {
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx hir::Expr<'_>) {
|
|
if is_integer_division(cx, expr) {
|
|
span_lint_and_help(
|
|
cx,
|
|
INTEGER_DIVISION,
|
|
expr.span,
|
|
"integer division",
|
|
None,
|
|
"division of integers may cause loss of precision. consider using floats",
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
fn is_integer_division<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx hir::Expr<'_>) -> bool {
|
|
if_chain! {
|
|
if let hir::ExprKind::Binary(binop, left, right) = &expr.kind;
|
|
if binop.node == hir::BinOpKind::Div;
|
|
then {
|
|
let (left_ty, right_ty) = (cx.typeck_results().expr_ty(left), cx.typeck_results().expr_ty(right));
|
|
return left_ty.is_integral() && right_ty.is_integral();
|
|
}
|
|
}
|
|
|
|
false
|
|
}
|