de7abd8824
This unifies the `non_snake_case_functions` and `uppercase_variables` lints into one lint, `non_snake_case`. It also now checks for non-snake-case modules. This also extends the non-camel-case types lint to check type parameters, and merges the `non_uppercase_pattern_statics` lint into the `non_uppercase_statics` lint. Because the `uppercase_variables` lint is now part of the `non_snake_case` lint, all non-snake-case variables that start with lowercase characters (such as `fooBar`) will now trigger the `non_snake_case` lint. New code should be updated to use the new `non_snake_case` lint instead of the previous `non_snake_case_functions` and `uppercase_variables` lints. All use of the `non_uppercase_pattern_statics` should be replaced with the `non_uppercase_statics` lint. Any code that previously contained non-snake-case module or variable names should be updated to use snake case names or disable the `non_snake_case` lint. Any code with non-camel-case type parameters should be changed to use camel case or disable the `non_camel_case_types` lint. [breaking-change]
62 lines
1.5 KiB
Rust
62 lines
1.5 KiB
Rust
// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT
|
|
// file at the top-level directory of this distribution and at
|
|
// http://rust-lang.org/COPYRIGHT.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
// option. This file may not be copied, modified, or distributed
|
|
// except according to those terms.
|
|
|
|
// Issue #7526: lowercase static constants in patterns look like bindings
|
|
|
|
#![allow(dead_code)]
|
|
#![deny(non_uppercase_statics)]
|
|
|
|
#[allow(non_uppercase_statics)]
|
|
pub static a : int = 97;
|
|
|
|
fn f() {
|
|
let r = match (0,0) {
|
|
(0, a) => 0,
|
|
//~^ ERROR static constant in pattern `a` should have an uppercase name such as `A`
|
|
(x, y) => 1 + x + y,
|
|
};
|
|
assert!(r == 1);
|
|
}
|
|
|
|
mod m {
|
|
#[allow(non_uppercase_statics)]
|
|
pub static aha : int = 7;
|
|
}
|
|
|
|
fn g() {
|
|
use self::m::aha;
|
|
let r = match (0,0) {
|
|
(0, aha) => 0,
|
|
//~^ ERROR static constant in pattern `aha` should have an uppercase name such as `AHA`
|
|
(x, y) => 1 + x + y,
|
|
};
|
|
assert!(r == 1);
|
|
}
|
|
|
|
mod n {
|
|
pub static OKAY : int = 8;
|
|
}
|
|
|
|
fn h() {
|
|
use self::n::OKAY as not_okay;
|
|
let r = match (0,0) {
|
|
(0, not_okay) => 0,
|
|
//~^ ERROR static constant in pattern `not_okay` should have an uppercase name such as `NOT_OKAY`
|
|
(x, y) => 1 + x + y,
|
|
};
|
|
assert!(r == 1);
|
|
}
|
|
|
|
fn main () {
|
|
f();
|
|
g();
|
|
h();
|
|
}
|