6b22bba902
Fix tests after no_effect update Add a drop testcase Don't lint _ variables in macro expansion Address review comments and update tests Don't shadow unnecessary operation lint if no_effect is allowed Revert shadowing change and remove no_effect allows Update clippy_lints/src/no_effect.rs Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com> Update clippy_lints/src/no_effect.rs Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com> Address review comments
112 lines
1.8 KiB
Rust
112 lines
1.8 KiB
Rust
#![feature(box_syntax)]
|
|
#![warn(clippy::no_effect_underscore_binding)]
|
|
#![allow(dead_code)]
|
|
#![allow(path_statements)]
|
|
#![allow(clippy::deref_addrof)]
|
|
#![allow(clippy::redundant_field_names)]
|
|
#![feature(untagged_unions)]
|
|
|
|
struct Unit;
|
|
struct Tuple(i32);
|
|
struct Struct {
|
|
field: i32,
|
|
}
|
|
enum Enum {
|
|
Tuple(i32),
|
|
Struct { field: i32 },
|
|
}
|
|
struct DropUnit;
|
|
impl Drop for DropUnit {
|
|
fn drop(&mut self) {}
|
|
}
|
|
struct DropStruct {
|
|
field: i32,
|
|
}
|
|
impl Drop for DropStruct {
|
|
fn drop(&mut self) {}
|
|
}
|
|
struct DropTuple(i32);
|
|
impl Drop for DropTuple {
|
|
fn drop(&mut self) {}
|
|
}
|
|
enum DropEnum {
|
|
Tuple(i32),
|
|
Struct { field: i32 },
|
|
}
|
|
impl Drop for DropEnum {
|
|
fn drop(&mut self) {}
|
|
}
|
|
struct FooString {
|
|
s: String,
|
|
}
|
|
union Union {
|
|
a: u8,
|
|
b: f64,
|
|
}
|
|
|
|
fn get_number() -> i32 {
|
|
0
|
|
}
|
|
fn get_struct() -> Struct {
|
|
Struct { field: 0 }
|
|
}
|
|
fn get_drop_struct() -> DropStruct {
|
|
DropStruct { field: 0 }
|
|
}
|
|
|
|
unsafe fn unsafe_fn() -> i32 {
|
|
0
|
|
}
|
|
|
|
fn main() {
|
|
let s = get_struct();
|
|
let s2 = get_struct();
|
|
|
|
0;
|
|
s2;
|
|
Unit;
|
|
Tuple(0);
|
|
Struct { field: 0 };
|
|
Struct { ..s };
|
|
Union { a: 0 };
|
|
Enum::Tuple(0);
|
|
Enum::Struct { field: 0 };
|
|
5 + 6;
|
|
*&42;
|
|
&6;
|
|
(5, 6, 7);
|
|
box 42;
|
|
..;
|
|
5..;
|
|
..5;
|
|
5..6;
|
|
5..=6;
|
|
[42, 55];
|
|
[42, 55][1];
|
|
(42, 55).1;
|
|
[42; 55];
|
|
[42; 55][13];
|
|
let mut x = 0;
|
|
|| x += 5;
|
|
let s: String = "foo".into();
|
|
FooString { s: s };
|
|
let _unused = 1;
|
|
let _penguin = || println!("Some helpful closure");
|
|
let _duck = Struct { field: 0 };
|
|
let _cat = [2, 4, 6, 8][2];
|
|
|
|
#[allow(clippy::no_effect)]
|
|
0;
|
|
|
|
// Do not warn
|
|
get_number();
|
|
unsafe { unsafe_fn() };
|
|
let _used = get_struct();
|
|
let _x = vec![1];
|
|
DropUnit;
|
|
DropStruct { field: 0 };
|
|
DropTuple(0);
|
|
DropEnum::Tuple(0);
|
|
DropEnum::Struct { field: 0 };
|
|
}
|