bors 176778fe92 Auto merge of #3556 - lucasloisp:bool-ord-comparison, r=oli-obk ...

Implements lint for order comparisons against bool (#3438)

As described on issue #3438, this change implements linting for `>` and `<` comparisons against both `boolean` literals and between expressions.

2018-12-18 10:11:08 +00:00

..

methods

Do not mark as_ref as useless if it's followed by a method call

2018-12-17 21:33:50 +01:00

utils

Changes lint sugg to bitwise and operator &

2018-12-17 15:32:24 -03:00

approx_const.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

arithmetic.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

assign_ops.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

attrs.rs

Apply redundant_clone on clippy

2018-12-10 08:48:14 +09:00

bit_mask.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

blacklisted_name.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

block_in_if_condition.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

booleans.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

bytecount.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

cargo_common_metadata.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

collapsible_if.rs

rustup rust-lang/rust#52994

2018-12-14 12:35:44 +01:00

const_static_lifetime.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

consts.rs

Fix ty::TyKind usage

2018-12-05 12:47:19 +01:00

copies.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

copy_iterator.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

cyclomatic_complexity.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

default_trait_access.rs

Fix TyKind::<kind> usage in codebase

2018-12-05 12:47:10 +01:00

deprecated_lints.rs

Remove unsafe_vector_initialization lint

2018-12-03 02:48:37 -08:00

derive.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

doc.rs

rustup rust-lang/rust#52994

2018-12-14 12:35:44 +01:00

double_comparison.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

double_parens.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

drop_forget_ref.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

duration_subsec.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

else_if_without_else.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

empty_enum.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

entry.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

enum_clike.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

enum_glob_use.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

enum_variants.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

eq_op.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

erasing_op.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

escape.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

eta_reduction.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

eval_order_dependence.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

excessive_precision.rs

Remove allow(doc_markdown) in excessive_precision.rs

2018-12-07 22:47:12 +01:00

explicit_write.rs

cargo fmt and remove stabilized feature

2018-12-12 07:31:04 +01:00

fallible_impl_from.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

format.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

formatting.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

functions.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

identity_conversion.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

identity_op.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

if_not_else.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

implicit_return.rs

Fix implicit_return false positives.

2018-12-16 15:42:02 +01:00

indexing_slicing.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

infallible_destructuring_match.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

infinite_iter.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

inherent_impl.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

inline_fn_without_body.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

int_plus_one.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

invalid_ref.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

items_after_statements.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

large_enum_variant.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

len_zero.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

let_if_seq.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

lib.rs

Remove references to sized for end users

2018-12-13 10:18:17 -08:00

lifetimes.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

literal_representation.rs

Downgrade large_digit_groups to pedantic

2018-12-01 17:08:42 -08:00

loops.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

map_clone.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

map_unit_fn.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

matches.rs

Extract single_match_else UI test

2018-12-04 07:20:13 +01:00

mem_discriminant.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

mem_forget.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

mem_replace.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

minmax.rs

Fix ty::TyKind usage

2018-12-05 12:47:19 +01:00

misc_early.rs

rustup rust-lang/rust#52994

2018-12-14 12:35:44 +01:00

misc.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

missing_doc.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

missing_inline.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

multiple_crate_versions.rs

…

mut_mut.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

mut_reference.rs

Fix some formatting issues

2018-11-27 21:49:09 +01:00

mutex_atomic.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

needless_bool.rs

Changes lint sugg to bitwise and operator &

2018-12-17 15:32:24 -03:00

needless_borrow.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

needless_borrowed_ref.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

needless_continue.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

needless_pass_by_value.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

needless_update.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

neg_cmp_op_on_partial_ord.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

neg_multiply.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

new_without_default.rs

new_without_default, partialeq_ne_impl: Use span_lint_node

2018-12-12 16:08:05 +09:00

no_effect.rs

Lint redundant clone of projection

2018-12-10 08:48:14 +09:00

non_copy_const.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

non_expressive_names.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

ok_if_let.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

open_options.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

overflow_check_conditional.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

panic_unimplemented.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

partialeq_ne_impl.rs

new_without_default, partialeq_ne_impl: Use span_lint_node

2018-12-12 16:08:05 +09:00

precedence.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

ptr_offset_with_cast.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

ptr.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

question_mark.rs

question_mark: Suggest Some(opt?) for if-else

2018-12-12 18:13:21 +09:00

ranges.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

redundant_clone.rs

Only check the assignment found at last

2018-12-10 15:59:21 +09:00

redundant_field_names.rs

redundant_field_names: Do not trigger on path with type params

2018-12-12 17:41:52 +09:00

redundant_pattern_matching.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

reference.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

regex.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

replace_consts.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

returns.rs

Fix some formatting issues

2018-11-27 21:49:09 +01:00

serde_api.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

shadow.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

slow_vector_initialization.rs

Remove unsafe_vector_initialization lint

2018-12-03 02:48:37 -08:00

strings.rs

Add applicability level to (nearly) every span_lint_and_sugg function

2018-11-27 15:29:23 +01:00

suspicious_trait_impl.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

swap.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

temporary_assignment.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

transmute.rs

Fix some formatting issues

2018-11-27 21:49:09 +01:00

trivially_copy_pass_by_ref.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

types.rs

Line length fix

2018-12-13 10:46:21 -08:00

unicode.rs

Fix some formatting issues

2018-11-27 21:49:09 +01:00

unsafe_removed_from_name.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

unused_io_amount.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

unused_label.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

unwrap.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

use_self.rs

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )

2018-12-08 12:05:09 +01:00

vec.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00

wildcard_dependencies.rs

cargo fmt

2018-12-04 06:47:41 +01:00

write.rs

Fix write_with_newline escaping false positive

2018-12-11 08:44:49 +02:00

zero_div_zero.rs

Run rustfmt on clippy_lints

2018-11-27 21:14:15 +01:00