fc061890d6
Key idea: ``` // before iter.cloned().filter(|x| unimplemented!() ) // after iter.filter(|&x| unimplemented!() ).cloned() // before iter.cloned().filter( foo ) // after iter.filter(|&x| foo(x) ).cloned() ```
86 lines
2.5 KiB
Rust
86 lines
2.5 KiB
Rust
#![warn(clippy::iter_overeager_cloned, clippy::redundant_clone, clippy::filter_next)]
|
|
#![allow(dead_code, clippy::let_unit_value, clippy::useless_vec)]
|
|
|
|
fn main() {
|
|
let vec = vec!["1".to_string(), "2".to_string(), "3".to_string()];
|
|
|
|
let _: Option<String> = vec.iter().cloned().last();
|
|
|
|
let _: Option<String> = vec.iter().chain(vec.iter()).cloned().next();
|
|
|
|
let _: usize = vec.iter().filter(|x| x == &"2").cloned().count();
|
|
|
|
let _: Vec<_> = vec.iter().cloned().take(2).collect();
|
|
|
|
let _: Vec<_> = vec.iter().cloned().skip(2).collect();
|
|
|
|
let _ = vec.iter().filter(|x| x == &"2").cloned().nth(2);
|
|
|
|
let _ = [Some(Some("str".to_string())), Some(Some("str".to_string()))]
|
|
.iter()
|
|
.cloned()
|
|
.flatten();
|
|
|
|
let _ = vec.iter().cloned().filter(|x| x.starts_with('2'));
|
|
|
|
let _ = vec.iter().cloned().find(|x| x == "2");
|
|
|
|
{
|
|
let f = |x: &String| x.starts_with('2');
|
|
let _ = vec.iter().cloned().filter(f);
|
|
let _ = vec.iter().cloned().find(f);
|
|
}
|
|
|
|
{
|
|
let vec: Vec<(String, String)> = vec![];
|
|
let f = move |x: &(String, String)| x.0.starts_with('2');
|
|
let _ = vec.iter().cloned().filter(f);
|
|
let _ = vec.iter().cloned().find(f);
|
|
}
|
|
|
|
fn test_move<'a>(
|
|
iter: impl Iterator<Item = &'a (&'a u32, String)> + 'a,
|
|
target: String,
|
|
) -> impl Iterator<Item = (&'a u32, String)> + 'a {
|
|
iter.cloned().filter(move |(&a, b)| a == 1 && b == &target)
|
|
}
|
|
|
|
{
|
|
#[derive(Clone)]
|
|
struct S<'a> {
|
|
a: &'a u32,
|
|
b: String,
|
|
}
|
|
|
|
fn bar<'a>(iter: impl Iterator<Item = &'a S<'a>> + 'a, target: String) -> impl Iterator<Item = S<'a>> + 'a {
|
|
iter.cloned().filter(move |S { a, b }| **a == 1 && b == &target)
|
|
}
|
|
}
|
|
|
|
// Not implemented yet
|
|
let _ = vec.iter().cloned().map(|x| x.len());
|
|
|
|
// This would fail if changed.
|
|
let _ = vec.iter().cloned().map(|x| x + "2");
|
|
|
|
// Not implemented yet
|
|
let _ = vec.iter().cloned().for_each(|x| assert!(!x.is_empty()));
|
|
|
|
// Not implemented yet
|
|
let _ = vec.iter().cloned().all(|x| x.len() == 1);
|
|
|
|
// Not implemented yet
|
|
let _ = vec.iter().cloned().any(|x| x.len() == 1);
|
|
|
|
// Should probably stay as it is.
|
|
let _ = [0, 1, 2, 3, 4].iter().cloned().take(10);
|
|
|
|
// `&Range<_>` doesn't implement `IntoIterator`
|
|
let _ = [0..1, 2..5].iter().cloned().flatten();
|
|
}
|
|
|
|
// #8527
|
|
fn cloned_flatten(x: Option<&Option<String>>) -> Option<String> {
|
|
x.cloned().flatten()
|
|
}
|