Philipp Hansch 1573d10325

tabs_in_doc_comments: Fix ICE due to char indexing ...

This is a quick-fix for an ICE in `tabs_in_doc_comments`. The problem
was that we we're indexing into possibly multi-byte characters, such as '位'.

More specifically `get_chunks_of_tabs` was returning indices into
multi-byte characters. Those were passed on to a `Span` creation that
then caused the ICE.

This fix makes sure that we don't return indices that point inside a
multi-byte character. *However*, we are still iterating over unicode
codepoints, not grapheme clusters. So a seemingly single character like y̆ ,
which actually consists of two codepoints, will probably still cause
incorrect spans in the output.

2021-04-06 07:20:55 +02:00

..

casts

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

functions

result_unit_err: Fix typo

2021-03-31 11:18:48 +09:00

loops

Improve needless_collect output

2021-04-02 10:10:54 -05:00

methods

Auto merge of #7016 - camsteffen:bind-map-paths, r=Manishearth

2021-04-02 15:10:24 +00:00

transmute

Eat dogfood

2021-03-31 14:06:27 -05:00

types

Merge type_complexity pass into types pass

2021-03-26 20:22:07 +09:00

unit_types

Eat dogfood

2021-03-31 14:06:27 -05:00

utils

Eat dogfood

2021-03-31 14:06:27 -05:00

absurd_extreme_comparisons.rs

Move absurd_extreme_comparisons to its own module

2021-03-26 20:18:37 +09:00

approx_const.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

arithmetic.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

as_conversions.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

asm_syntax.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

assertions_on_constants.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

assign_ops.rs

Add clippy_utils::paths imports

2021-03-17 09:31:20 -05:00

async_yields_async.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

atomic_ordering.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

attrs.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

await_holding_invalid.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

bit_mask.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

blacklisted_name.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

blocks_in_if_conditions.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

booleans.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

bytecount.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

cargo_common_metadata.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

case_sensitive_file_extension_comparisons.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

checked_conversions.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

cognitive_complexity.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

collapsible_if.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

collapsible_match.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

comparison_chain.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

consts.rs

…

copies.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

copy_iterator.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

create_dir.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

dbg_macro.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

default_numeric_fallback.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

default.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

deprecated_lints.rs

…

dereference.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

derive.rs

Improve expl_impl_clone_on_copy

2021-03-28 07:54:00 -04:00

disallowed_method.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

doc.rs

missing_panics_doc: Ignore usage of debug_assert family

2021-03-29 17:20:04 +09:00

double_comparison.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

double_parens.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

drop_forget_ref.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

duration_subsec.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

else_if_without_else.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

empty_enum.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

entry.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

enum_clike.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

enum_variants.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

eq_op.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

erasing_op.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

escape.rs

Merge remote-tracking branch 'upstream/master' into rustup

2021-03-25 18:38:13 +01:00

eta_reduction.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

eval_order_dependence.rs

Improvements to match_wildcard_for_single_variants and wildcard_enum_match_arm lints

2021-03-17 12:04:11 -04:00

excessive_bools.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

exhaustive_items.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

exit.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

explicit_write.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

fallible_impl_from.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

float_equality_without_abs.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

float_literal.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

floating_point_arithmetic.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

format.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

formatting.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

from_over_into.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

from_str_radix_10.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

future_not_send.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

get_last_with_len.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

identity_op.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

if_let_mutex.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

if_let_some_result.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

if_not_else.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

if_then_some_else_none.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

implicit_hasher.rs

Move implicit_hasher to its own module

2021-03-26 20:18:37 +09:00

implicit_return.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

implicit_saturating_sub.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

inconsistent_struct_constructor.rs

Merge remote-tracking branch 'upstream/master' into rustup

2021-03-25 18:38:13 +01:00

indexing_slicing.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

infinite_iter.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

inherent_impl.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

inherent_to_string.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

inline_fn_without_body.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

int_plus_one.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

integer_division.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

invalid_upcast_comparisons.rs

Move invalid_upcast_comparisons to its own module

2021-03-26 20:18:37 +09:00

items_after_statements.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

large_const_arrays.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

large_enum_variant.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

large_stack_arrays.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

len_zero.rs

len_without_is_empty improvements

2021-03-27 09:04:44 -04:00

let_if_seq.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

let_underscore.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

lib.rs

Auto merge of #6988 - mikerite:fix-6984, r=camsteffen

2021-04-02 12:42:40 +00:00

lifetimes.rs

Merge remote-tracking branch 'upstream/master' into rustup

2021-03-25 18:38:13 +01:00

literal_representation.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

macro_use.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

main_recursion.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

manual_async_fn.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

manual_map.rs

Don't lint manual_map in const functions

2021-03-30 10:56:08 -04:00

manual_non_exhaustive.rs

Auto merge of #6988 - mikerite:fix-6984, r=camsteffen

2021-04-02 12:42:40 +00:00

manual_ok_or.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

manual_strip.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

manual_unwrap_or.rs

Add clippy_utils::paths imports

2021-03-17 09:31:20 -05:00

map_clone.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

map_err_ignore.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

map_identity.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

map_unit_fn.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

match_on_vec_items.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

matches.rs

Fix ICE

2021-04-03 14:17:58 -05:00

mem_discriminant.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

mem_forget.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

mem_replace.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

minmax.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

misc_early.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

misc.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

missing_const_for_fn.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

missing_doc.rs

Fix hidden variant suggestion on single variant

2021-03-31 07:36:09 +02:00

missing_inline.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

modulo_arithmetic.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

multiple_crate_versions.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

mut_key.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

mut_mut.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

mut_mutex_lock.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

mut_reference.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

mutable_debug_assertion.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

mutex_atomic.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

needless_arbitrary_self_type.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

needless_bool.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

needless_borrow.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

needless_borrowed_ref.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

needless_continue.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

needless_for_each.rs

Tweak a suggestion message of needless_for_each

2021-04-01 00:08:59 +09:00

needless_pass_by_value.rs

Merge remote-tracking branch 'upstream/master' into rustup

2021-03-25 18:38:13 +01:00

needless_question_mark.rs

needless_question_mark: don't lint if Some(..) is inside a macro def and the ? is not.

2021-03-18 23:47:21 +01:00

needless_update.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

neg_cmp_op_on_partial_ord.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

neg_multiply.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

new_without_default.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

no_effect.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

non_copy_const.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

non_expressive_names.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

non_octal_unix_permissions.rs

Add non_octal_unix_permissions lint

2021-03-30 16:04:16 -07:00

open_options.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

option_env_unwrap.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

option_if_let_else.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

overflow_check_conditional.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

panic_in_result_fn.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

panic_unimplemented.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

partialeq_ne_impl.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

pass_by_ref_or_value.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

path_buf_push_overwrite.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

pattern_type_mismatch.rs

Merge remote-tracking branch 'upstream/master' into rustup

2021-03-25 18:38:13 +01:00

precedence.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

ptr_eq.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

ptr_offset_with_cast.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

ptr.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

question_mark.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

ranges.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

redundant_clone.rs

Fix redundant_clone fp where the cloned value is modified while the clone is in use.

2021-03-31 15:35:34 -04:00

redundant_closure_call.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

redundant_else.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

redundant_field_names.rs

Merge remote-tracking branch 'upstream/master' into rustup

2021-03-25 18:38:13 +01:00

redundant_pub_crate.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

redundant_slicing.rs

Improve redundant_slicing

2021-03-25 22:30:14 -04:00

redundant_static_lifetimes.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

ref_option_ref.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

reference.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

regex.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

repeat_once.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

returns.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

self_assignment.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

semicolon_if_nothing_returned.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

serde_api.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

shadow.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

single_component_path_imports.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

size_of_in_element_count.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

slow_vector_initialization.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

stable_sort_primitive.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

strings.rs

check for .to_string().into_bytes() in string_lit_to_bytes

2021-03-24 17:31:20 -07:00

suspicious_operation_groupings.rs

Merge remote-tracking branch 'upstream/master' into rustup

2021-03-25 18:38:13 +01:00

suspicious_trait_impl.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

swap.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

tabs_in_doc_comments.rs

tabs_in_doc_comments: Fix ICE due to char indexing

2021-04-06 07:20:55 +02:00

temporary_assignment.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

to_digit_is_some.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

to_string_in_display.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

trait_bounds.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

transmuting_null.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

try_err.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

undropped_manually_drops.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

unicode.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

unit_return_expecting_ord.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

unnamed_address.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

unnecessary_sort_by.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

unnecessary_wraps.rs

Improvements to match_wildcard_for_single_variants and wildcard_enum_match_arm lints

2021-03-17 12:04:11 -04:00

unnested_or_patterns.rs

Add MSRV option to unnested_or_patterns lint

2021-03-26 14:36:09 +01:00

unsafe_removed_from_name.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

unused_io_amount.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

unused_self.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

unused_unit.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

unwrap_in_result.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

unwrap.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

upper_case_acronyms.rs

upper_case_acronyms: add ui and ui-toml tests for private/public enums

2021-03-27 01:08:14 +01:00

use_self.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

useless_conversion.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

vec_init_then_push.rs

Eat dogfood

2021-03-31 14:06:27 -05:00

vec_resize_to_zero.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

vec.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

verbose_file_reads.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

wildcard_dependencies.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

wildcard_imports.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00

write.rs

Remove SmallVec

2021-03-16 12:27:21 -04:00

zero_div_zero.rs

Don't re-export clippy_utils::diagnostics::*

2021-03-15 20:06:01 -05:00

zero_sized_map_values.rs

Don't re-export clippy_utils::*

2021-03-17 09:13:52 -05:00