363d158cd8
Various changes to name resolution of anon consts Sorry this PR is kind of all over the place ^^' Fixes #111012 - Rewrites anon const nameres to all go through `fn resolve_anon_const` explicitly instead of `visit_anon_const` to ensure that we do not accidentally resolve anon consts as if they are allowed to use generics when they aren't. Also means that we dont have bits of code for resolving anon consts that will get out of sync (i.e. legacy const generics and resolving path consts that were parsed as type arguments) - Renames two of the `LifetimeRibKind`, `AnonConst -> ConcreteAnonConst` and `ConstGeneric -> ConstParamTy` - Noticed while doing this that under `generic_const_exprs` all lifetimes currently get resolved to errors without any error being emitted which was causing a bunch of tests to pass without their bugs having been fixed, incidentally fixed that in this PR and marked those tests as `// known-bug:`. I'm fine to break those since `generic_const_exprs` is a very unstable incomplete feature and this PR _does_ make generic_const_exprs "less broken" as a whole, also I can't be assed to figure out what the underlying causes of all of them are. This PR reopens #77357 #83993 - Changed `generics_of` to stop providing generics and predicates to enum variant discriminant anon consts since those are not allowed to use generic parameters - Updated the error for non 'static lifetime in const arguments and the error for non 'static lifetime in const param tys to use `derive(Diagnostic)` I have a vague idea why const-arg-in-const-arg.rs, in-closure.rs and simple.rs have started failing which is unfortunate since these were deliberately made to work, I think lifetime resolution being broken just means this regressed at some point and nobody noticed because the tests were not testing anything :( I'm fine breaking these too for the same reason as the tests for #77357 #83993. I couldn't get `// known-bug` to work for these ICEs and just kept getting different stderr between CI and local `--bless` so I just removed them and will create an issue to track re-adding (and fixing) the bugs if this PR lands. r? `@cjgillot` cc `@compiler-errors` |
||
|---|---|---|
| .. | ||
| enum-and-module-in-same-scope.rs | ||
| enum-and-module-in-same-scope.stderr | ||
| enum-discrim-autosizing.rs | ||
| enum-discrim-autosizing.stderr | ||
| enum-discrim-too-small2.rs | ||
| enum-discrim-too-small2.stderr | ||
| enum-discrim-too-small.rs | ||
| enum-discrim-too-small.stderr | ||
| enum-in-scope.rs | ||
| enum-in-scope.stderr | ||
| enum-size-variance.rs | ||
| enum-size-variance.stderr | ||
| enum-to-float-cast-2.rs | ||
| enum-to-float-cast-2.stderr | ||
| enum-to-float-cast.rs | ||
| enum-to-float-cast.stderr | ||
| enum-variant-type-2.rs | ||
| enum-variant-type-2.stderr | ||
| issue-1821.rs | ||
| issue-42747.rs | ||
| issue-67945-1.rs | ||
| issue-67945-1.stderr | ||
| issue-67945-2.rs | ||
| issue-67945-2.stderr | ||
| nested-enum.rs | ||
| nested-enum.stderr | ||
| suggest-default-attribute.rs | ||
| suggest-default-attribute.stderr | ||
| union-in-enum.rs | ||