bors fedce67cd2 Auto merge of #48326 - RalfJung:generic-bounds, r=petrochenkov ...

Warn about ignored generic bounds in `for`

This adds a new lint to fix #42181. For consistency and to avoid code duplication, I also moved the existing "bounds in type aliases are ignored" here.

Questions to the reviewer:
* Is it okay to just remove a diagnostic error code like this? Should I instead keep the warning about type aliases where it is? The old code provided a detailed explanation of what's going on when asked, that information is now lost. On the other hand, `span_warn!` seems deprecated (after this patch, it has exactly one user left!).
* Did I miss any syntactic construct that can appear as `for` in the surface syntax? I covered function types (`for<'a> fn(...)`), generic traits (`for <'a> Fn(...)`, can appear both as bounds as as trait objects) and bounds (`for<'a> F: ...`).
* For the sake of backwards compatibility, this adds a warning, not an error. @nikomatsakis suggested an error in https://github.com/rust-lang/rust/issues/42181#issuecomment-306924389, but I feel that can only happen in a new epoch -- right?

Cc @eddyb

2018-03-09 10:45:29 +00:00

..

ascii-only-character-escape.rs

…

assoc-oddities-1.rs

…

assoc-oddities-2.rs

…

associated-types-project-from-hrtb-explicit.rs

…

attr-bad-meta.rs

Liberalize attributes.

2017-03-14 04:39:21 +00:00

attr-before-eof.rs

…

attr-dangling-in-fn.rs

…

attr-dangling-in-mod.rs

…

attr.rs

…

attrs-after-extern-mod.rs

…

bad-char-literals.rs

Improve char escaping in lexer messages

2018-02-01 08:19:22 +11:00

bad-lit-suffixes.rs

…

bad-match.rs

…

bad-name.rs

…

bad-pointer-type.rs

…

bad-value-ident-false.rs

…

bad-value-ident-true.rs

…

better-expected.rs

…

bind-struct-early-modifiers.rs

…

bound-single-question-mark.rs

Fix issue with single question mark or paren

2017-04-21 21:32:44 +03:00

bounds-lifetime-1.rs

…

bounds-lifetime-2.rs

…

bounds-lifetime-where-1.rs

…

bounds-lifetime-where.rs

…

bounds-lifetime.rs

make bounds on higher-kinded lifetimes a hard error in ast_validation

2018-03-06 11:29:48 +01:00

bounds-type-where.rs

…

bounds-type.rs

make bounds on higher-kinded lifetimes a hard error in ast_validation

2018-03-06 11:29:48 +01:00

brace-after-qualified-path-in-match.rs

…

byte-literals.rs

…

byte-string-literals.rs

…

circular_modules_hello.rs

…

circular_modules_main.rs

…

class-implements-bad-trait.rs

…

closure-return-syntax.rs

Add tests

2018-01-27 22:37:30 +03:00

column-offset-1-based.rs

…

default.rs

Fix some doc/comment typos.

2017-07-23 22:48:01 +07:00

doc-after-struct-field.rs

Consume trailing doc comments to avoid parse errors

2017-11-24 08:32:01 -08:00

doc-before-attr.rs

…

doc-before-eof.rs

…

doc-before-extern-rbrace.rs

…

doc-before-fn-rbrace.rs

…

doc-before-identifier.rs

…

doc-before-mod-rbrace.rs

…

doc-before-rbrace.rs

…

doc-before-semi.rs

…

doc-before-struct-rbrace-1.rs

Suggest macro call when not sure that it is fn definition

2017-11-24 07:34:32 -08:00

doc-before-struct-rbrace-2.rs

Suggest macro call when not sure that it is fn definition

2017-11-24 07:34:32 -08:00

duplicate-visibility.rs

…

empty-impl-semicolon.rs

…

extern-crate-unexpected-token.rs

…

extern-expected-fn-or-brace.rs

…

extern-foreign-crate.rs

…

extern-no-fn.rs

…

impl-qpath.rs

syntax: Disambiguate generics and qualified paths

2018-01-14 18:10:19 +03:00

import-from-path.rs

…

import-from-rename.rs

…

import-glob-path.rs

…

import-glob-rename.rs

…

inner-attr-after-doc-comment.rs

…

inner-attr.rs

…

int-literal-too-large-span.rs

…

issue-1655.rs

…

issue-1802-1.rs

…

issue-1802-2.rs

…

issue-2354-1.rs

…

issue-2354.rs

…

issue-3036.rs

…

issue-5544-a.rs

…

issue-5544-b.rs

…

issue-5806.rs

…

issue-6610.rs

…

issue-8537.rs

…

issue-10392-2.rs

…

issue-10392.rs

…

issue-10636-1.rs

…

issue-14303-enum.rs

…

issue-14303-fn-def.rs

…

issue-14303-fncall.rs

…

issue-14303-impl.rs

…

issue-14303-path.rs

…

issue-14303-struct.rs

…

issue-14303-trait.rs

…

issue-15914.rs

…

issue-17383.rs

Update issue-17383.rs

2017-11-22 10:56:17 -07:00

issue-17718-const-mut.rs

…

issue-17904-2.rs

…

issue-17904.rs

Refactor parsing of trait object types

2017-03-21 23:01:53 +03:00

issue-19096.rs

…

issue-19398.rs

…

issue-20711-2.rs

crate shorthand visibility modifier

2017-10-22 23:58:13 -07:00

issue-20711.rs

crate shorthand visibility modifier

2017-10-22 23:58:13 -07:00

issue-21153.rs

libsyntax/parse: improve associated item error reporting

2017-04-17 21:25:35 +03:00

issue-22647.rs

Do not emit type errors on recovered blocks

2017-12-21 14:57:42 -08:00

issue-22712.rs

Revert to correct recovery behavior

2017-11-24 07:34:33 -08:00

issue-23620-invalid-escapes.rs

Accept underscores in unicode escapes

2017-08-17 20:03:32 +02:00

issue-24197.rs

Revert to correct recovery behavior

2017-11-24 07:34:33 -08:00

issue-24375.rs

…

issue-24780.rs

Add tests

2018-01-27 22:37:30 +03:00

issue-27255.rs

…

issue-30318.rs

…

issue-32214.rs

…

issue-32446.rs

…

issue-32501.rs

struct pattern parsing and diagnostic tweaks

2018-01-07 17:04:36 -08:00

issue-32505.rs

…

issue-33262.rs

…

issue-33413.rs

Detect = -> : typo in let bindings

2017-11-03 17:39:16 -07:00

issue-33455.rs

…

issue-33569.rs

Fix a couple of tests

2018-01-30 12:41:04 -06:00

issue-37113.rs

Add trailing newlines to files which have no trailing newlines.

2017-12-30 15:50:52 +08:00

issue-37234.rs

Consume trailing doc comments to avoid parse errors

2017-11-24 08:32:01 -08:00

issue-43692.rs

Accept underscores in unicode escapes

2017-08-17 20:03:32 +02:00

keyword-abstract.rs

…

keyword-as-as-identifier.rs

…

keyword-box-as-identifier.rs

…

keyword-break-as-identifier.rs

…

keyword-const-as-identifier.rs

…

keyword-continue-as-identifier.rs

…

keyword-else-as-identifier.rs

…

keyword-enum-as-identifier.rs

…

keyword-final.rs

…

keyword-fn-as-identifier.rs

…

keyword-for-as-identifier.rs

…

keyword-if-as-identifier.rs

…

keyword-impl-as-identifier.rs

…

keyword-in-as-identifier.rs

…

keyword-let-as-identifier.rs

…

keyword-loop-as-identifier.rs

…

keyword-match-as-identifier.rs

…

keyword-mod-as-identifier.rs

…

keyword-move-as-identifier.rs

…

keyword-mut-as-identifier.rs

…

keyword-override.rs

…

keyword-pub-as-identifier.rs

…

keyword-ref-as-identifier.rs

…

keyword-return-as-identifier.rs

…

keyword-static-as-identifier.rs

…

keyword-struct-as-identifier.rs

…

keyword-trait-as-identifier.rs

…

keyword-type-as-identifier.rs

…

keyword-typeof.rs

…

keyword-unsafe-as-identifier.rs

…

keyword-use-as-identifier.rs

…

keyword-where-as-identifier.rs

…

keyword-while-as-identifier.rs

…

keyword.rs

…

keywords-followed-by-double-colon.rs

Do not emit type errors on recovered blocks

2017-12-21 14:57:42 -08:00

lex-bad-binary-literal.rs

…

lex-bad-char-literals-1.rs

…

lex-bad-char-literals-2.rs

…

lex-bad-char-literals-3.rs

When attempting to write str with single quote suggest double quotes

2017-12-14 22:51:42 -08:00

lex-bad-char-literals-4.rs

…

lex-bad-char-literals-5.rs

When attempting to write str with single quote suggest double quotes

2017-12-14 22:51:42 -08:00

lex-bad-numeric-literals.rs

…

lex-bad-octal-literal.rs

…

lex-bad-token.rs

…

lex-bare-cr-string-literal-doc-comment.rs

Allow bare CR in ////-style comment.

2017-05-08 22:29:24 +09:00

lex-stray-backslash.rs

Improve char escaping in lexer messages

2018-02-01 08:19:22 +11:00

lifetime-in-pattern.rs

…

lifetime-semicolon.rs

…

macro-bad-delimiter-ident.rs

…

macro-doc-comments-1.rs

…

macro-doc-comments-2.rs

…

macro-keyword.rs

Change some terminology around keywords and reserved identifiers

2017-06-29 15:19:53 +03:00

macro-mismatched-delim-brace-paren.rs

…

macro-mismatched-delim-paren-brace.rs

…

macro-repeat.rs

…

macros-no-semicolon-items.rs

…

macros-no-semicolon.rs

…

match-arrows-block-then-binop.rs

…

match-refactor-to-expr.rs

Improve wording and spans for unexpected token

2017-03-25 15:36:59 -07:00

match-vec-invalid.rs

…

mod_file_not_exist_windows.rs

Add 'ignore-cloudabi' to tests that don't and won't build on CloudABI.

2018-01-02 14:11:41 +01:00

mod_file_not_exist.rs

Replace hardcoded forward slash with path::MAIN_SEPARATOR

2017-03-30 13:51:16 +02:00

mod_file_with_path_attr.rs

…

multiline-comment-line-tracking.rs

…

multitrait.rs

…

mut-patterns.rs

Do not emit type errors on recovered blocks

2017-12-21 14:57:42 -08:00

new-unicode-escapes-1.rs

…

new-unicode-escapes-2.rs

Accept underscores in unicode escapes

2017-08-17 20:03:32 +02:00

new-unicode-escapes-3.rs

Accept underscores in unicode escapes

2017-08-17 20:03:32 +02:00

new-unicode-escapes-4.rs

Accept underscores in unicode escapes

2017-08-17 20:03:32 +02:00

no-binary-float-literal.rs

…

no-hex-float-literal.rs

…

no-unsafe-self.rs

…

not-a-pred.rs

…

obsolete-proc.rs

…

omitted-arg-in-item-fn.rs

…

paamayim-nekudotayim.rs

…

paren-after-qualified-path-in-match.rs

…

pat-lt-bracket-1.rs

…

pat-lt-bracket-2.rs

…

pat-lt-bracket-3.rs

…

pat-lt-bracket-4.rs

…

pat-lt-bracket-5.rs

Revert to correct recovery behavior

2017-11-24 07:34:33 -08:00

pat-lt-bracket-6.rs

…

pat-lt-bracket-7.rs

…

pat-ranges-1.rs

Revert to correct recovery behavior

2017-11-24 07:34:33 -08:00

pat-ranges-2.rs

Revert to correct recovery behavior

2017-11-24 07:34:33 -08:00

pat-ranges-3.rs

Revert to correct recovery behavior

2017-11-24 07:34:33 -08:00

pat-ranges-4.rs

Revert to correct recovery behavior

2017-11-24 07:34:33 -08:00

pat-ref-enum.rs

…

pat-tuple-1.rs

…

pat-tuple-2.rs

Support parentheses in patterns under feature gate

2018-03-01 01:47:56 +03:00

pat-tuple-3.rs

…

pat-tuple-4.rs

…

pat-tuple-5.rs

…

pub-item-macro.rs

…

pub-macro-rules.rs

…

pub-method-macro.rs

…

range_inclusive_dotdotdot.rs

Test error for ... in expressions

2017-11-06 20:33:56 +01:00

range_inclusive_gate.rs

Remove excessive trailing newlines.

2017-12-30 15:50:52 +08:00

range_inclusive.rs

Add support for ..= syntax

2017-09-22 22:05:18 +02:00

range-3.rs

Revert to correct recovery behavior

2017-11-24 07:34:33 -08:00

range-4.rs

Revert to correct recovery behavior

2017-11-24 07:34:33 -08:00

raw-byte-string-eof.rs

…

raw-byte-string-literals.rs

…

raw-str-delim.rs

…

raw-str-unbalanced.rs

…

raw-str-unterminated.rs

…

recover-enum2.rs

…

recover-enum.rs

…

recover-struct.rs

…

regions-out-of-scope-slice.rs

…

removed-syntax-closure-lifetime.rs

…

removed-syntax-enum-newtype.rs

…

removed-syntax-extern-const.rs

Improve error message for const extern fn

2017-05-31 11:26:19 -07:00

removed-syntax-field-let.rs

…

removed-syntax-field-semicolon.rs

…

removed-syntax-fixed-vec.rs

…

removed-syntax-fn-pure.rs

…

removed-syntax-fn-sigil.rs

…

removed-syntax-mode.rs

…

removed-syntax-mut-vec-expr.rs

…

removed-syntax-mut-vec-ty.rs

…

removed-syntax-ptr-lifetime.rs

Refactor parsing of trait object types

2017-03-21 23:01:53 +03:00

removed-syntax-record.rs

…

removed-syntax-static-fn.rs

crate shorthand visibility modifier

2017-10-22 23:58:13 -07:00

removed-syntax-uniq-mut-expr.rs

…

removed-syntax-uniq-mut-ty.rs

Refactor parsing of trait object types

2017-03-21 23:01:53 +03:00

removed-syntax-with-1.rs

…

removed-syntax-with-2.rs

…

require-parens-for-chained-comparison.rs

output compiler message updated

2017-10-10 23:52:45 -03:00

struct-field-numeric-shorthand.rs

…

struct-literal-in-for.rs

…

struct-literal-in-if.rs

…

struct-literal-in-match-discriminant.rs

…

struct-literal-in-while.rs

…

struct-literal-restrictions-in-lamda.rs

Lambda expressions honor no struct literal restriction

2017-07-23 16:20:14 +03:00

tag-variant-disr-non-nullary.rs

Rename C-like enum to Field-less enum

2017-11-22 10:55:40 -07:00

trailing-carriage-return-in-string.rs

…

trait-bounds-not-on-impl.rs

syntax: Rewrite parsing of impls

2018-01-14 18:10:05 +03:00

trait-non-item-macros.rs

…

trait-object-bad-parens.rs

Fix whitespacing issues in pretty-printing of bounds

2017-12-20 00:23:18 +03:00

trait-object-lifetime-parens.rs

syntax: Support parentheses around trait bounds

2017-04-21 21:32:44 +03:00

trait-object-macro-matcher.rs

Refactor parsing of trait object types

2017-03-21 23:01:53 +03:00

trait-object-polytrait-priority.rs

Fix whitespacing issues in pretty-printing of bounds

2017-12-20 00:23:18 +03:00

trait-object-trait-parens.rs

syntax: Support parentheses around trait bounds

2017-04-21 21:32:44 +03:00

trait-pub-assoc-const.rs

libsyntax/parse: improve associated item error reporting

2017-04-17 21:25:35 +03:00

trait-pub-assoc-ty.rs

libsyntax/parse: improve associated item error reporting

2017-04-17 21:25:35 +03:00

trait-pub-method.rs

libsyntax/parse: improve associated item error reporting

2017-04-17 21:25:35 +03:00

type-parameters-in-field-exprs.rs

syntax: Relax path grammar

2017-08-11 02:06:27 +03:00

unbalanced-doublequote.rs

…

underscore-suffix-for-float.rs

Disallow ._ in float literal.

2017-05-12 22:00:06 +09:00

underscore-suffix-for-string.rs

Add warning cycle #42326.

2017-05-31 16:43:47 +09:00

unicode-chars.rs

remove "much" from unicode diagnostic

2017-05-20 11:18:26 -04:00

unsized2.rs

…

unsized.rs

…

use-as-where-use-ends-with-mod-sep.rs

…

use-ends-with-mod-sep.rs

…

variadic-ffi-3.rs

…

variadic-ffi-4.rs

…

virtual-structs.rs

…

where_with_bound.rs

syntax: Disambiguate generics and qualified paths

2018-01-14 18:10:19 +03:00

where-clauses-no-bounds-or-predicates.rs

…

wrong-escape-of-curly-braces.rs

…