Mazdak Farrokhzad 10b580a1d1
Rollup merge of #65316 - oconnor663:noninheritable, r=alexcrichton
make File::try_clone produce non-inheritable handles on Windows

~**NOT READY FOR REVIEW.** This PR is currently mainly to trigger CI so that I can see what happens. (Is there a better way to trigger CI?) I don't know whether this change makes sense yet.~ (Edit: @Mark-Simulacrum clarified that CI doesn't currently run on Windows.)

---

File handles shouldn't be inheritable in general.
`std::process::Command` takes care of making them inheritable when child
processes are spawned, and the `CREATE_PROCESS_LOCK` protects against
races in that section on Windows. But `File::try_clone` has been
creating inheritable file descriptors outside of that lock, which could
be leaking into other child processes unintentionally.

See also https://github.com/rust-lang/rust/pull/31069#discussion_r334117665.
2019-10-17 13:46:04 +02:00
..
2019-09-16 20:02:36 +08:00
2019-08-14 05:39:53 -04:00
2019-08-15 22:58:57 +03:00
2019-09-06 14:45:28 +02:00
2019-10-02 08:17:28 -04:00
2019-09-14 12:12:32 +02:00
2019-10-13 12:12:46 +02:00
2019-10-07 11:52:30 -07:00
2019-10-08 18:04:18 -04:00
2019-08-15 22:58:57 +03:00
2019-10-05 12:23:10 +02:00