0c1ffc1d1f
`possible_missing_comma` should only trigger when the binary operator has unary equivalent. Otherwise, it's not possible to insert a comma without breaking compilation. The operators identified were `+`, `&`, `*` and `-`. This fixes the specific examples given in issues #3244 and #3396 but doesn't address the conflict this lint has with the style of starting a line with a binary operator.
128 lines
2.1 KiB
Rust
128 lines
2.1 KiB
Rust
// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
|
|
// file at the top-level directory of this distribution.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
// option. This file may not be copied, modified, or distributed
|
|
// except according to those terms.
|
|
|
|
|
|
|
|
|
|
|
|
#![warn(clippy::all)]
|
|
#![allow(unused_variables)]
|
|
#![allow(unused_assignments)]
|
|
#![allow(clippy::if_same_then_else)]
|
|
#![allow(clippy::deref_addrof)]
|
|
|
|
fn foo() -> bool { true }
|
|
|
|
fn main() {
|
|
// weird `else if` formatting:
|
|
if foo() {
|
|
} if foo() {
|
|
}
|
|
|
|
let _ = { // if as the last expression
|
|
let _ = 0;
|
|
|
|
if foo() {
|
|
} if foo() {
|
|
}
|
|
else {
|
|
}
|
|
};
|
|
|
|
let _ = { // if in the middle of a block
|
|
if foo() {
|
|
} if foo() {
|
|
}
|
|
else {
|
|
}
|
|
|
|
let _ = 0;
|
|
};
|
|
|
|
if foo() {
|
|
} else
|
|
if foo() { // the span of the above error should continue here
|
|
}
|
|
|
|
if foo() {
|
|
}
|
|
else
|
|
if foo() { // the span of the above error should continue here
|
|
}
|
|
|
|
// those are ok:
|
|
if foo() {
|
|
}
|
|
if foo() {
|
|
}
|
|
|
|
if foo() {
|
|
} else if foo() {
|
|
}
|
|
|
|
if foo() {
|
|
}
|
|
else if foo() {
|
|
}
|
|
|
|
if foo() {
|
|
}
|
|
else if
|
|
foo() {}
|
|
|
|
// weird op_eq formatting:
|
|
let mut a = 42;
|
|
a =- 35;
|
|
a =* &191;
|
|
|
|
let mut b = true;
|
|
b =! false;
|
|
|
|
// those are ok:
|
|
a = -35;
|
|
a = *&191;
|
|
b = !false;
|
|
|
|
// possible missing comma in an array
|
|
let _ = &[
|
|
-1, -2, -3 // <= no comma here
|
|
-4, -5, -6
|
|
];
|
|
let _ = &[
|
|
-1, -2, -3 // <= no comma here
|
|
*4, -5, -6
|
|
];
|
|
|
|
// those are ok:
|
|
let _ = &[
|
|
-1, -2, -3,
|
|
-4, -5, -6
|
|
];
|
|
let _ = &[
|
|
-1, -2, -3,
|
|
-4, -5, -6,
|
|
];
|
|
let _ = &[
|
|
1 + 2, 3 +
|
|
4, 5 + 6,
|
|
];
|
|
|
|
// don't lint for bin op without unary equiv
|
|
// issue 3244
|
|
vec![
|
|
1
|
|
/ 2,
|
|
];
|
|
// issue 3396
|
|
vec![
|
|
true
|
|
| false,
|
|
];
|
|
}
|