d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
82 lines
3.2 KiB
Rust
82 lines
3.2 KiB
Rust
use clippy_utils::diagnostics::span_lint_and_sugg;
|
|
use clippy_utils::paths;
|
|
use clippy_utils::source::snippet_with_macro_callsite;
|
|
use clippy_utils::ty::{is_type_diagnostic_item, is_type_ref_to_diagnostic_item};
|
|
use if_chain::if_chain;
|
|
use rustc_errors::Applicability;
|
|
use rustc_hir as hir;
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
use rustc_span::symbol::{sym, Symbol};
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for usage of `libc::strlen` on a `CString` or `CStr` value,
|
|
/// and suggest calling `as_bytes().len()` or `to_bytes().len()` respectively instead.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// This avoids calling an unsafe `libc` function.
|
|
/// Currently, it also avoids calculating the length.
|
|
///
|
|
/// ### Example
|
|
/// ```rust, ignore
|
|
/// use std::ffi::CString;
|
|
/// let cstring = CString::new("foo").expect("CString::new failed");
|
|
/// let len = unsafe { libc::strlen(cstring.as_ptr()) };
|
|
/// ```
|
|
/// Use instead:
|
|
/// ```rust, no_run
|
|
/// use std::ffi::CString;
|
|
/// let cstring = CString::new("foo").expect("CString::new failed");
|
|
/// let len = cstring.as_bytes().len();
|
|
/// ```
|
|
#[clippy::version = "1.55.0"]
|
|
pub STRLEN_ON_C_STRINGS,
|
|
complexity,
|
|
"using `libc::strlen` on a `CString` or `CStr` value, while `as_bytes().len()` or `to_bytes().len()` respectively can be used instead"
|
|
}
|
|
|
|
declare_lint_pass!(StrlenOnCStrings => [STRLEN_ON_C_STRINGS]);
|
|
|
|
impl LateLintPass<'tcx> for StrlenOnCStrings {
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx hir::Expr<'_>) {
|
|
if expr.span.from_expansion() {
|
|
return;
|
|
}
|
|
|
|
if_chain! {
|
|
if let hir::ExprKind::Call(func, [recv]) = expr.kind;
|
|
if let hir::ExprKind::Path(hir::QPath::Resolved(_, path)) = func.kind;
|
|
|
|
if (&paths::LIBC_STRLEN).iter().map(|x| Symbol::intern(x)).eq(
|
|
path.segments.iter().map(|seg| seg.ident.name));
|
|
if let hir::ExprKind::MethodCall(path, _, args, _) = recv.kind;
|
|
if args.len() == 1;
|
|
if !args.iter().any(|e| e.span.from_expansion());
|
|
if path.ident.name == sym::as_ptr;
|
|
then {
|
|
let cstring = &args[0];
|
|
let ty = cx.typeck_results().expr_ty(cstring);
|
|
let val_name = snippet_with_macro_callsite(cx, cstring.span, "..");
|
|
let sugg = if is_type_diagnostic_item(cx, ty, sym::cstring_type){
|
|
format!("{}.as_bytes().len()", val_name)
|
|
} else if is_type_ref_to_diagnostic_item(cx, ty, sym::CStr){
|
|
format!("{}.to_bytes().len()", val_name)
|
|
} else {
|
|
return;
|
|
};
|
|
|
|
span_lint_and_sugg(
|
|
cx,
|
|
STRLEN_ON_C_STRINGS,
|
|
expr.span,
|
|
"using `libc::strlen` on a `CString` or `CStr` value",
|
|
"try this (you might also need to get rid of `unsafe` block in some cases):",
|
|
sugg,
|
|
Applicability::Unspecified // Sometimes unnecessary `unsafe` block
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|