7828c3dd28
https://github.com/rust-lang/rfcs/pull/221 The current terminology of "task failure" often causes problems when writing or speaking about code. You often want to talk about the possibility of an operation that returns a Result "failing", but cannot because of the ambiguity with task failure. Instead, you have to speak of "the failing case" or "when the operation does not succeed" or other circumlocutions. Likewise, we use a "Failure" header in rustdoc to describe when operations may fail the task, but it would often be helpful to separate out a section describing the "Err-producing" case. We have been steadily moving away from task failure and toward Result as an error-handling mechanism, so we should optimize our terminology accordingly: Result-producing functions should be easy to describe. To update your code, rename any call to `fail!` to `panic!` instead. Assuming you have not created your own macro named `panic!`, this will work on UNIX based systems: grep -lZR 'fail!' . | xargs -0 -l sed -i -e 's/fail!/panic!/g' You can of course also do this by hand. [breaking-change]
48 lines
1.2 KiB
Rust
48 lines
1.2 KiB
Rust
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
|
|
// file at the top-level directory of this distribution and at
|
|
// http://rust-lang.org/COPYRIGHT.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
// option. This file may not be copied, modified, or distributed
|
|
// except according to those terms.
|
|
|
|
// ignore-pretty
|
|
|
|
// Don't panic on blocks without results
|
|
// There are several tests in this run-pass that raised
|
|
// when this bug was opened. The cases where the compiler
|
|
// panics before the fix have a comment.
|
|
|
|
struct S {x:()}
|
|
|
|
|
|
fn test(slot: &mut Option<proc() -> proc()>, _: proc()) -> () {
|
|
let a = slot.take();
|
|
let _a = match a {
|
|
// `{let .. a(); }` would break
|
|
Some(a) => { let _a = a(); },
|
|
None => (),
|
|
};
|
|
}
|
|
|
|
fn not(b: bool) -> bool {
|
|
if b {
|
|
!b
|
|
} else {
|
|
// `panic!(...)` would break
|
|
panic!("Break the compiler");
|
|
}
|
|
}
|
|
|
|
pub fn main() {
|
|
// {} would break
|
|
let _r = {};
|
|
let mut slot = None;
|
|
// `{ test(...); }` would break
|
|
let _s : S = S{ x: { test(&mut slot, proc() {}); } };
|
|
|
|
let _b = not(true);
|
|
}
|