c9dd1d9983
This makes it possible to mutably borrow different fields of the MIR body without resorting to methods like `basic_blocks_local_decls_mut_and_var_debug_info`. To preserve validity of control flow graph caches in the presence of modifications, a new struct `BasicBlocks` wraps together basic blocks and control flow graph caches. The `BasicBlocks` dereferences to `IndexVec<BasicBlock, BasicBlockData>`. On the other hand a mutable access requires explicit `as_mut()` call.
46 lines
1.7 KiB
Rust
46 lines
1.7 KiB
Rust
//! This pass replaces a drop of a type that does not need dropping, with a goto.
|
|
//!
|
|
//! When the MIR is built, we check `needs_drop` before emitting a `Drop` for a place. This pass is
|
|
//! useful because (unlike MIR building) it runs after type checking, so it can make use of
|
|
//! `Reveal::All` to provide more precise type information.
|
|
|
|
use crate::MirPass;
|
|
use rustc_middle::mir::*;
|
|
use rustc_middle::ty::TyCtxt;
|
|
|
|
use super::simplify::simplify_cfg;
|
|
|
|
pub struct RemoveUnneededDrops;
|
|
|
|
impl<'tcx> MirPass<'tcx> for RemoveUnneededDrops {
|
|
fn run_pass(&self, tcx: TyCtxt<'tcx>, body: &mut Body<'tcx>) {
|
|
trace!("Running RemoveUnneededDrops on {:?}", body.source);
|
|
|
|
let did = body.source.def_id();
|
|
let param_env = tcx.param_env_reveal_all_normalized(did);
|
|
let mut should_simplify = false;
|
|
|
|
for block in body.basic_blocks.as_mut() {
|
|
let terminator = block.terminator_mut();
|
|
if let TerminatorKind::Drop { place, target, .. } = terminator.kind {
|
|
let ty = place.ty(&body.local_decls, tcx);
|
|
if ty.ty.needs_drop(tcx, param_env) {
|
|
continue;
|
|
}
|
|
if !tcx.consider_optimizing(|| format!("RemoveUnneededDrops {:?} ", did)) {
|
|
continue;
|
|
}
|
|
debug!("SUCCESS: replacing `drop` with goto({:?})", target);
|
|
terminator.kind = TerminatorKind::Goto { target };
|
|
should_simplify = true;
|
|
}
|
|
}
|
|
|
|
// if we applied optimizations, we potentially have some cfg to cleanup to
|
|
// make it easier for further passes
|
|
if should_simplify {
|
|
simplify_cfg(tcx, body);
|
|
}
|
|
}
|
|
}
|