Diagnostic renaming 2 A sequel to #121489. r? `@davidtwco`
For high-level intro to how type checking works in rustc, see the type checking chapter of the rustc dev guide.
