d1f0f04a48
Add a new lint, `manual-strip`, that suggests using the `str::strip_prefix` and `str::strip_suffix` methods introduced in Rust 1.45 when the same functionality is performed 'manually'. Closes #5734
133 lines
3.6 KiB
Plaintext
133 lines
3.6 KiB
Plaintext
error: stripping a prefix manually
|
|
--> $DIR/manual_strip.rs:7:24
|
|
|
|
|
LL | str::to_string(&s["ab".len()..]);
|
|
| ^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::manual-strip` implied by `-D warnings`
|
|
note: the prefix was tested here
|
|
--> $DIR/manual_strip.rs:6:5
|
|
|
|
|
LL | if s.starts_with("ab") {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^
|
|
help: try using the `strip_prefix` method
|
|
|
|
|
LL | if let Some(<stripped>) = s.strip_prefix("ab") {
|
|
LL | str::to_string(<stripped>);
|
|
LL | <stripped>.to_string();
|
|
LL |
|
|
LL | str::to_string(<stripped>);
|
|
LL | <stripped>.to_string();
|
|
|
|
|
|
|
error: stripping a suffix manually
|
|
--> $DIR/manual_strip.rs:15:24
|
|
|
|
|
LL | str::to_string(&s[..s.len() - "bc".len()]);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
note: the suffix was tested here
|
|
--> $DIR/manual_strip.rs:14:5
|
|
|
|
|
LL | if s.ends_with("bc") {
|
|
| ^^^^^^^^^^^^^^^^^^^^^
|
|
help: try using the `strip_suffix` method
|
|
|
|
|
LL | if let Some(<stripped>) = s.strip_suffix("bc") {
|
|
LL | str::to_string(<stripped>);
|
|
LL | <stripped>.to_string();
|
|
LL |
|
|
LL | str::to_string(<stripped>);
|
|
LL | <stripped>.to_string();
|
|
|
|
|
|
|
error: stripping a prefix manually
|
|
--> $DIR/manual_strip.rs:24:24
|
|
|
|
|
LL | str::to_string(&s[1..]);
|
|
| ^^^^^^^
|
|
|
|
|
note: the prefix was tested here
|
|
--> $DIR/manual_strip.rs:23:5
|
|
|
|
|
LL | if s.starts_with('a') {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
help: try using the `strip_prefix` method
|
|
|
|
|
LL | if let Some(<stripped>) = s.strip_prefix('a') {
|
|
LL | str::to_string(<stripped>);
|
|
LL | <stripped>.to_string();
|
|
|
|
|
|
|
error: stripping a prefix manually
|
|
--> $DIR/manual_strip.rs:31:24
|
|
|
|
|
LL | str::to_string(&s[prefix.len()..]);
|
|
| ^^^^^^^^^^^^^^^^^^
|
|
|
|
|
note: the prefix was tested here
|
|
--> $DIR/manual_strip.rs:30:5
|
|
|
|
|
LL | if s.starts_with(prefix) {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
help: try using the `strip_prefix` method
|
|
|
|
|
LL | if let Some(<stripped>) = s.strip_prefix(prefix) {
|
|
LL | str::to_string(<stripped>);
|
|
|
|
|
|
|
error: stripping a prefix manually
|
|
--> $DIR/manual_strip.rs:37:24
|
|
|
|
|
LL | str::to_string(&s[PREFIX.len()..]);
|
|
| ^^^^^^^^^^^^^^^^^^
|
|
|
|
|
note: the prefix was tested here
|
|
--> $DIR/manual_strip.rs:36:5
|
|
|
|
|
LL | if s.starts_with(PREFIX) {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
help: try using the `strip_prefix` method
|
|
|
|
|
LL | if let Some(<stripped>) = s.strip_prefix(PREFIX) {
|
|
LL | str::to_string(<stripped>);
|
|
LL | str::to_string(<stripped>);
|
|
|
|
|
|
|
error: stripping a prefix manually
|
|
--> $DIR/manual_strip.rs:44:24
|
|
|
|
|
LL | str::to_string(&TARGET[prefix.len()..]);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
note: the prefix was tested here
|
|
--> $DIR/manual_strip.rs:43:5
|
|
|
|
|
LL | if TARGET.starts_with(prefix) {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
help: try using the `strip_prefix` method
|
|
|
|
|
LL | if let Some(<stripped>) = TARGET.strip_prefix(prefix) {
|
|
LL | str::to_string(<stripped>);
|
|
|
|
|
|
|
error: stripping a prefix manually
|
|
--> $DIR/manual_strip.rs:50:9
|
|
|
|
|
LL | s1[2..].to_uppercase();
|
|
| ^^^^^^^
|
|
|
|
|
note: the prefix was tested here
|
|
--> $DIR/manual_strip.rs:49:5
|
|
|
|
|
LL | if s1.starts_with("ab") {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
help: try using the `strip_prefix` method
|
|
|
|
|
LL | if let Some(<stripped>) = s1.strip_prefix("ab") {
|
|
LL | <stripped>.to_uppercase();
|
|
|
|
|
|
|
error: aborting due to 7 previous errors
|
|
|