bors
dfb92532fa
Auto merge of #12870 - lrh2000:sig-drop-while, r=blyxyas
...
`significant_drop_in_scrutinee`: Trigger lint also for scrutinees in `while let` and `if let`
This lint should also work for `if let` and `while let`, so this PR makes it actually work.
For `while let`, I can't think of any reason why this lint shouldn't be enabled. The only problem is that the lint suggests moving the significant drop above the `while let`, which is clearly invalid in the case of `while let`. I don't know if this is fixable, but this PR simply disables the wrong suggestions.
For `if let`, it seems that another lint called `if_let_mutex` has some overlapping functionality. But `significant_drop_in_scrutinee` is a bit stricter, as it will trigger even if the `else` branch does not try to lock the same mutex.
changelog: [`significant_drop_in_scrutinee`]: Trigger lint also for scrutinees in `while let` and `if let`.
r? `@blyxyas` (the third PR as promised in https://github.com/rust-lang/rust-clippy/pull/12740#issuecomment-2094876350 , thanks for your review!)
2024-07-08 15:09:45 +00:00
..
2024-06-20 13:57:16 +00:00
2024-06-25 17:50:48 +02:00
2024-06-27 18:49:59 +02:00
2024-07-02 23:27:14 +02:00
2024-07-08 18:09:49 +08:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-20 04:25:17 +00:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-07-04 14:31:15 +02:00
2024-07-04 14:31:15 +02:00
2024-07-04 14:31:15 +02:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-27 18:49:59 +02:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-27 18:49:59 +02:00
2024-06-27 18:49:59 +02:00
2024-06-24 16:08:51 +03:00
2024-07-05 10:28:26 +02:00
2024-07-05 10:28:26 +02:00
2024-06-16 18:33:43 -04:00
2024-06-16 18:33:43 -04:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-07-05 02:17:24 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-07-03 21:25:43 +07:00
2024-07-03 21:25:43 +07:00
2024-07-03 21:25:43 +07:00
2024-06-16 15:54:48 -04:00
2024-06-16 15:54:48 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-27 18:49:59 +02:00
2024-06-27 18:49:59 +02:00
2024-06-27 18:49:59 +02:00
2024-07-07 20:15:19 -04:00
2024-07-07 20:15:19 -04:00
2024-07-07 20:15:19 -04:00
2024-07-01 19:00:10 -07:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-16 18:33:43 -04:00
2024-06-16 18:33:43 -04:00
2024-06-28 10:29:18 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-15 21:52:42 +02:00
2024-06-15 21:45:35 +02:00
2024-06-15 21:45:35 +02:00
2024-06-29 22:31:10 +02:00
2024-06-29 22:31:10 +02:00
2024-06-29 22:31:10 +02:00
2024-06-21 18:18:28 +02:00
2024-06-21 18:18:28 +02:00
2024-07-05 19:40:37 +05:00
2024-07-05 19:40:37 +05:00
2024-07-05 19:40:37 +05:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-20 04:25:17 +00:00
2024-06-20 04:25:17 +00:00
2024-07-02 19:30:01 +02:00
2024-07-02 19:30:01 +02:00
2024-07-02 19:30:01 +02:00
2024-07-02 19:30:01 +02:00
2024-07-02 19:30:01 +02:00
2024-07-03 20:58:21 +02:00
2024-07-03 20:58:21 +02:00
2024-07-03 20:58:21 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-16 22:36:24 -04:00
2024-06-16 22:36:24 -04:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-07-05 19:40:37 +05:00
2024-07-05 19:40:37 +05:00
2024-07-05 19:40:37 +05:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-07-03 19:42:34 +01:00
2024-07-03 19:42:34 +01:00
2024-07-04 13:18:38 +08:00
2024-07-04 13:18:38 +08:00
2024-06-24 16:08:51 +03:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-24 16:08:51 +03:00
2024-06-20 13:57:16 +00:00
2024-06-20 13:57:16 +00:00
2024-06-20 13:57:16 +00:00
2024-06-20 00:09:31 +02:00
2024-06-20 00:09:31 +02:00
2024-06-20 00:09:31 +02:00
2024-06-25 17:50:48 +02:00
2024-06-25 17:50:48 +02:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-19 13:30:21 -04:00
2024-06-25 17:50:48 +02:00
2024-07-05 02:17:24 -04:00
2024-07-05 02:17:24 -04:00
2024-07-05 02:17:24 -04:00
2024-07-05 02:17:24 -04:00
2024-07-05 02:17:24 -04:00
2024-07-05 02:17:24 -04:00
2024-07-05 02:17:24 -04:00
2024-07-05 02:17:24 -04:00