bors[bot] 04d2b7b256
Merge #5565
5565: SSR: Don't mix non-path-based rules with path-based r=matklad a=davidlattimore

If any rules contain paths, then we reject any rules that don't contain paths. Allowing a mix leads to strange semantics, since the path-based rules only match things where the path refers to semantically the same thing, whereas the non-path-based rules could match anything. Specifically, if we have a rule like `foo ==>> bar` we only want to match the `foo` that is in the current scope, not any `foo`. However "foo" can be parsed as a pattern (BIND_PAT -> NAME -> IDENT). Allowing such a rule through would result in renaming everything called `foo` to `bar`. It'd also be slow, since without a path, we'd have to use the slow-scan search mechanism.

Co-authored-by: David Lattimore <dml@google.com>
2020-07-29 08:55:34 +00:00
..
2020-07-21 10:50:24 +02:00
2020-07-23 16:53:12 +02:00
2020-07-21 17:17:21 +02:00
2020-07-24 16:30:12 +02:00
2020-07-23 16:53:12 +02:00
2020-07-24 17:38:18 +02:00
2020-07-24 20:18:01 +00:00
2020-07-29 01:03:19 +03:00
2020-07-28 20:59:48 +02:00
2020-07-16 14:29:57 +00:00
2020-07-25 10:35:45 +02:00
2020-07-28 20:59:48 +02:00
2020-07-28 10:31:08 +02:00
2020-07-14 14:58:10 +02:00
2020-07-26 11:05:28 +02:00
2020-07-18 16:40:10 +02:00