12dc24f460
This commit is a response to feedback on the displayed type signatures results, by making generics act stricter. Generics are tightened by making order significant. This means `Vec<Allocator>` now matches only with a true vector of allocators, instead of matching the second type param. It also makes unboxing within generics stricter, so `Result<A, B>` only matches if `B` is in the error type and `A` is in the success type. The top level of the function search is unaffected. Find the discussion on: * <https://rust-lang.zulipchat.com/#narrow/stream/393423-t-rustdoc.2Fmeetings/topic/meeting.202024-07-08/near/449965149> * <https://github.com/rust-lang/rust/pull/124544#issuecomment-2204272265> * <https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc/topic/deciding.20on.20semantics.20of.20generics.20in.20rustdoc.20search/near/476841363>
89 lines
3.1 KiB
JavaScript
89 lines
3.1 KiB
JavaScript
// ignore-order
|
|
// exact-check
|
|
|
|
// Make sure that results are order-agnostic, even when there's search items that only differ
|
|
// by generics.
|
|
|
|
const EXPECTED = [
|
|
{
|
|
'query': 'Wrap',
|
|
'in_args': [
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'bar' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'foo' },
|
|
],
|
|
},
|
|
{
|
|
'query': 'Wrap<i32>',
|
|
'in_args': [
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'bar' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'foo' },
|
|
],
|
|
},
|
|
{
|
|
'query': 'Wrap<i32>, Wrap<i32, u32>',
|
|
'others': [
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'bar' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'foo' },
|
|
],
|
|
},
|
|
{
|
|
'query': 'Wrap<i32, u32>, Wrap<i32>',
|
|
'others': [
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'bar' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'foo' },
|
|
],
|
|
},
|
|
{
|
|
'query': 'W3<i32>, W3<i32, u32>',
|
|
'others': [
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baaa' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baab' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baac' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baad' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baae' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baaf' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baag' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baah' },
|
|
],
|
|
},
|
|
{
|
|
'query': 'W3<i32, u32>, W3<i32>',
|
|
'others': [
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baaa' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baab' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baac' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baad' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baae' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baaf' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baag' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baah' },
|
|
],
|
|
},
|
|
{
|
|
// strict generics matching; W2<i32, u32> doesn't match W2<W3<i32, u32>>,
|
|
// even though W2<i32> works just fine (ignoring the W3)
|
|
'query': 'W2<i32>, W2<i32, u32>',
|
|
'others': [],
|
|
},
|
|
{
|
|
'query': 'W2<i32, u32>, W2<i32>',
|
|
'others': [],
|
|
},
|
|
{
|
|
'query': 'W2<i32>, W3<i32, u32>',
|
|
'others': [
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baac' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baaf' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baag' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baah' },
|
|
],
|
|
},
|
|
{
|
|
'query': 'W2<i32>, W2<i32>',
|
|
'others': [
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baag' },
|
|
{ 'path': 'generics_match_ambiguity', 'name': 'baah' },
|
|
],
|
|
},
|
|
];
|