use ide_db::imports::import_assets::item_for_path_search; use itertools::Itertools; use stdx::format_to; use syntax::ast::{self, AstNode, HasName, HasVisibility, StructKind}; use crate::{ utils::{find_impl_block_start, find_struct_impl, generate_impl_text}, AssistContext, AssistId, AssistKind, Assists, }; // FIXME: how to depupicate with `ide-diagnostics/mssing_fields` fn use_trivial_constructor( db: &ide_db::RootDatabase, path: ast::Path, ty: &hir::Type, ) -> Option { match ty.as_adt() { Some(hir::Adt::Enum(x)) => { let variants = x.variants(db); if variants.len() == 1 { let variant = variants[0]; if variant.fields(db).is_empty() { let path = ast::make::path_qualified( path, syntax::ast::make::path_segment(ast::make::name_ref( &variant.name(db).to_smol_str(), )), ); let is_record = variant.kind(db) == hir::StructKind::Record; return Some(if is_record { ast::Expr::RecordExpr(syntax::ast::make::record_expr( path, ast::make::record_expr_field_list(std::iter::empty()), )) } else { syntax::ast::make::expr_path(path) }); } } } Some(hir::Adt::Struct(x)) => { if x.fields(db).is_empty() { return Some(syntax::ast::make::expr_path(path)); } } _ => {} } None } // Assist: generate_new // // Adds a new inherent impl for a type. // // ``` // struct Ctx { // data: T,$0 // } // ``` // -> // ``` // struct Ctx { // data: T, // } // // impl Ctx { // fn $0new(data: T) -> Self { Self { data } } // } // ``` pub(crate) fn generate_new(acc: &mut Assists, ctx: &AssistContext) -> Option<()> { let strukt = ctx.find_node_at_offset::()?; // We want to only apply this to non-union structs with named fields let field_list = match strukt.kind() { StructKind::Record(named) => named, _ => return None, }; // Return early if we've found an existing new fn let impl_def = find_struct_impl(ctx, &ast::Adt::Struct(strukt.clone()), "new")?; let target = strukt.syntax().text_range(); acc.add(AssistId("generate_new", AssistKind::Generate), "Generate `new`", target, |builder| { let mut buf = String::with_capacity(512); if impl_def.is_some() { buf.push('\n'); } let vis = strukt.visibility().map_or(String::new(), |v| format!("{} ", v)); let current_module = ctx.sema.scope(strukt.syntax()).unwrap().module(); let trivial_constructors = field_list .fields() .map(|f| { let ty = ctx.sema.resolve_type(&f.ty()?)?; let item_in_ns = hir::ItemInNs::from(hir::ModuleDef::from(ty.as_adt()?)); let type_path = current_module .find_use_path(ctx.sema.db, item_for_path_search(ctx.sema.db, item_in_ns)?)?; let expr = use_trivial_constructor( &ctx.sema.db, ide_db::helpers::mod_path_to_ast(&type_path), &ty, )?; Some(format!("{}: {}", f.name()?.syntax(), expr)) }) .collect::>(); let params = field_list .fields() .enumerate() .filter_map(|(i, f)| { if trivial_constructors[i].is_none() { Some(format!("{}: {}", f.name()?.syntax(), f.ty()?.syntax())) } else { None } }) .format(", "); let fields = field_list .fields() .enumerate() .filter_map(|(i, f)| { let contructor = trivial_constructors[i].clone(); if contructor.is_some() { contructor } else { Some(f.name()?.to_string()) } }) .format(", "); format_to!(buf, " {}fn new({}) -> Self {{ Self {{ {} }} }}", vis, params, fields); let start_offset = impl_def .and_then(|impl_def| find_impl_block_start(impl_def, &mut buf)) .unwrap_or_else(|| { buf = generate_impl_text(&ast::Adt::Struct(strukt.clone()), &buf); strukt.syntax().text_range().end() }); match ctx.config.snippet_cap { None => builder.insert(start_offset, buf), Some(cap) => { buf = buf.replace("fn new", "fn $0new"); builder.insert_snippet(cap, start_offset, buf); } } }) } #[cfg(test)] mod tests { use crate::tests::{check_assist, check_assist_not_applicable, check_assist_target}; use super::*; #[test] fn test_generate_new() { check_assist( generate_new, r#" struct Foo {$0} "#, r#" struct Foo {} impl Foo { fn $0new() -> Self { Self { } } } "#, ); check_assist( generate_new, r#" struct Foo {$0} "#, r#" struct Foo {} impl Foo { fn $0new() -> Self { Self { } } } "#, ); check_assist( generate_new, r#" struct Foo<'a, T: Foo<'a>> {$0} "#, r#" struct Foo<'a, T: Foo<'a>> {} impl<'a, T: Foo<'a>> Foo<'a, T> { fn $0new() -> Self { Self { } } } "#, ); check_assist( generate_new, r#" struct Foo { baz: String $0} "#, r#" struct Foo { baz: String } impl Foo { fn $0new(baz: String) -> Self { Self { baz } } } "#, ); check_assist( generate_new, r#" struct Foo { baz: String, qux: Vec $0} "#, r#" struct Foo { baz: String, qux: Vec } impl Foo { fn $0new(baz: String, qux: Vec) -> Self { Self { baz, qux } } } "#, ); } #[test] fn check_that_visibility_modifiers_dont_get_brought_in() { check_assist( generate_new, r#" struct Foo { pub baz: String, pub qux: Vec $0} "#, r#" struct Foo { pub baz: String, pub qux: Vec } impl Foo { fn $0new(baz: String, qux: Vec) -> Self { Self { baz, qux } } } "#, ); } #[test] fn check_it_reuses_existing_impls() { check_assist( generate_new, r#" struct Foo {$0} impl Foo {} "#, r#" struct Foo {} impl Foo { fn $0new() -> Self { Self { } } } "#, ); check_assist( generate_new, r#" struct Foo {$0} impl Foo { fn qux(&self) {} } "#, r#" struct Foo {} impl Foo { fn $0new() -> Self { Self { } } fn qux(&self) {} } "#, ); check_assist( generate_new, r#" struct Foo {$0} impl Foo { fn qux(&self) {} fn baz() -> i32 { 5 } } "#, r#" struct Foo {} impl Foo { fn $0new() -> Self { Self { } } fn qux(&self) {} fn baz() -> i32 { 5 } } "#, ); } #[test] fn check_visibility_of_new_fn_based_on_struct() { check_assist( generate_new, r#" pub struct Foo {$0} "#, r#" pub struct Foo {} impl Foo { pub fn $0new() -> Self { Self { } } } "#, ); check_assist( generate_new, r#" pub(crate) struct Foo {$0} "#, r#" pub(crate) struct Foo {} impl Foo { pub(crate) fn $0new() -> Self { Self { } } } "#, ); } #[test] fn generate_new_not_applicable_if_fn_exists() { check_assist_not_applicable( generate_new, r#" struct Foo {$0} impl Foo { fn new() -> Self { Self } } "#, ); check_assist_not_applicable( generate_new, r#" struct Foo {$0} impl Foo { fn New() -> Self { Self } } "#, ); } #[test] fn generate_new_target() { check_assist_target( generate_new, r#" struct SomeThingIrrelevant; /// Has a lifetime parameter struct Foo<'a, T: Foo<'a>> {$0} struct EvenMoreIrrelevant; "#, "/// Has a lifetime parameter struct Foo<'a, T: Foo<'a>> {}", ); } #[test] fn test_unrelated_new() { check_assist( generate_new, r#" pub struct AstId { file_id: HirFileId, file_ast_id: FileAstId, } impl AstId { pub fn new(file_id: HirFileId, file_ast_id: FileAstId) -> AstId { AstId { file_id, file_ast_id } } } pub struct Source { pub file_id: HirFileId,$0 pub ast: T, } impl Source { pub fn map U, U>(self, f: F) -> Source { Source { file_id: self.file_id, ast: f(self.ast) } } } "#, r#" pub struct AstId { file_id: HirFileId, file_ast_id: FileAstId, } impl AstId { pub fn new(file_id: HirFileId, file_ast_id: FileAstId) -> AstId { AstId { file_id, file_ast_id } } } pub struct Source { pub file_id: HirFileId, pub ast: T, } impl Source { pub fn $0new(file_id: HirFileId, ast: T) -> Self { Self { file_id, ast } } pub fn map U, U>(self, f: F) -> Source { Source { file_id: self.file_id, ast: f(self.ast) } } } "#, ); } }