use clippy_utils::diagnostics::{span_lint_and_help, span_lint_and_sugg}; use clippy_utils::source::{snippet, snippet_with_applicability}; use clippy_utils::ty::is_type_diagnostic_item; use clippy_utils::{is_trait_method, strip_pat_refs}; use if_chain::if_chain; use rustc_errors::Applicability; use rustc_hir as hir; use rustc_hir::PatKind; use rustc_lint::LateContext; use rustc_middle::ty; use rustc_span::source_map::Span; use rustc_span::symbol::sym; use super::SEARCH_IS_SOME; /// lint searching an Iterator followed by `is_some()` /// or calling `find()` on a string followed by `is_some()` or `is_none()` #[allow(clippy::too_many_arguments, clippy::too_many_lines)] pub(super) fn check<'tcx>( cx: &LateContext<'_>, expr: &'tcx hir::Expr<'_>, search_method: &str, is_some: bool, search_recv: &hir::Expr<'_>, search_arg: &'tcx hir::Expr<'_>, is_some_recv: &hir::Expr<'_>, method_span: Span, ) { let option_check_method = if is_some { "is_some" } else { "is_none" }; // lint if caller of search is an Iterator if is_trait_method(cx, is_some_recv, sym::Iterator) { let msg = format!( "called `{}()` after searching an `Iterator` with `{}`", option_check_method, search_method ); let search_snippet = snippet(cx, search_arg.span, ".."); if search_snippet.lines().count() <= 1 { // suggest `any(|x| ..)` instead of `any(|&x| ..)` for `find(|&x| ..).is_some()` // suggest `any(|..| *..)` instead of `any(|..| **..)` for `find(|..| **..).is_some()` let any_search_snippet = if_chain! { if search_method == "find"; if let hir::ExprKind::Closure(_, _, body_id, ..) = search_arg.kind; let closure_body = cx.tcx.hir().body(body_id); if let Some(closure_arg) = closure_body.params.get(0); then { if let hir::PatKind::Ref(..) = closure_arg.pat.kind { Some(search_snippet.replacen('&', "", 1)) } else if let PatKind::Binding(annotation, _, ident, _) = strip_pat_refs(closure_arg.pat).kind { let name = &*ident.name.as_str(); let old_search_snippet = search_snippet.clone(); let search_snippet = search_snippet.replace(&format!("*{}", name), name); if_chain! { // if there is no dereferencing used in closure body if old_search_snippet == search_snippet; if annotation == hir::BindingAnnotation::Unannotated; if let ty::Ref(_, inner_ty, _) = cx.typeck_results().node_type(closure_arg.hir_id).kind(); if let ty::Ref(..) = inner_ty.kind(); // put an `&` in the closure body, but skip closure params if let Some((start, end)) = old_search_snippet.split_once(&name); then { let end = end.replace(name, &format!("&{}", name)); Some(format!("{}{}{}", start, name, end)) } else { Some(search_snippet) } } } else { None } } else { None } }; // add note if not multi-line if is_some { span_lint_and_sugg( cx, SEARCH_IS_SOME, method_span.with_hi(expr.span.hi()), &msg, "use `any()` instead", format!( "any({})", any_search_snippet.as_ref().map_or(&*search_snippet, String::as_str) ), Applicability::MachineApplicable, ); } else { let iter = snippet(cx, search_recv.span, ".."); span_lint_and_sugg( cx, SEARCH_IS_SOME, expr.span, &msg, "use `!_.any()` instead", format!( "!{}.any({})", iter, any_search_snippet.as_ref().map_or(&*search_snippet, String::as_str) ), Applicability::MachineApplicable, ); } } else { let hint = format!( "this is more succinctly expressed by calling `any()`{}", if option_check_method == "is_none" { " with negation" } else { "" } ); span_lint_and_help(cx, SEARCH_IS_SOME, expr.span, &msg, None, &hint); } } // lint if `find()` is called by `String` or `&str` else if search_method == "find" { let is_string_or_str_slice = |e| { let self_ty = cx.typeck_results().expr_ty(e).peel_refs(); if is_type_diagnostic_item(cx, self_ty, sym::String) { true } else { *self_ty.kind() == ty::Str } }; if_chain! { if is_string_or_str_slice(search_recv); if is_string_or_str_slice(search_arg); then { let msg = format!("called `{}()` after calling `find()` on a string", option_check_method); match option_check_method { "is_some" => { let mut applicability = Applicability::MachineApplicable; let find_arg = snippet_with_applicability(cx, search_arg.span, "..", &mut applicability); span_lint_and_sugg( cx, SEARCH_IS_SOME, method_span.with_hi(expr.span.hi()), &msg, "use `contains()` instead", format!("contains({})", find_arg), applicability, ); }, "is_none" => { let string = snippet(cx, search_recv.span, ".."); let mut applicability = Applicability::MachineApplicable; let find_arg = snippet_with_applicability(cx, search_arg.span, "..", &mut applicability); span_lint_and_sugg( cx, SEARCH_IS_SOME, expr.span, &msg, "use `!_.contains()` instead", format!("!{}.contains({})", string, find_arg), applicability, ); }, _ => (), } } } } }