//! Flycheck provides the functionality needed to run `cargo check` or //! another compatible command (f.x. clippy) in a background thread and provide //! LSP diagnostics based on the output of the command. #![warn(rust_2018_idioms, unused_lifetimes, semicolon_in_expressions_from_macros)] use std::{ fmt, io, process::{ChildStderr, ChildStdout, Command, Stdio}, time::Duration, }; use command_group::{CommandGroup, GroupChild}; use crossbeam_channel::{never, select, unbounded, Receiver, Sender}; use paths::AbsPathBuf; use rustc_hash::FxHashMap; use serde::Deserialize; use stdx::process::streaming_output; pub use cargo_metadata::diagnostic::{ Applicability, Diagnostic, DiagnosticCode, DiagnosticLevel, DiagnosticSpan, DiagnosticSpanMacroExpansion, }; #[derive(Copy, Clone, Debug, Default, PartialEq, Eq)] pub enum InvocationStrategy { Once, #[default] PerWorkspace, } #[derive(Clone, Debug, Default, PartialEq, Eq)] pub enum InvocationLocation { Root(AbsPathBuf), #[default] Workspace, } #[derive(Clone, Debug, PartialEq, Eq)] pub enum FlycheckConfig { CargoCommand { command: String, target_triple: Option, all_targets: bool, no_default_features: bool, all_features: bool, features: Vec, extra_args: Vec, extra_env: FxHashMap, }, CustomCommand { command: String, args: Vec, extra_env: FxHashMap, invocation_strategy: InvocationStrategy, invocation_location: InvocationLocation, }, } impl fmt::Display for FlycheckConfig { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { match self { FlycheckConfig::CargoCommand { command, .. } => write!(f, "cargo {}", command), FlycheckConfig::CustomCommand { command, args, .. } => { write!(f, "{} {}", command, args.join(" ")) } } } } /// Flycheck wraps the shared state and communication machinery used for /// running `cargo check` (or other compatible command) and providing /// diagnostics based on the output. /// The spawned thread is shut down when this struct is dropped. #[derive(Debug)] pub struct FlycheckHandle { // XXX: drop order is significant sender: Sender, _thread: jod_thread::JoinHandle, id: usize, } impl FlycheckHandle { pub fn spawn( id: usize, sender: Box, config: FlycheckConfig, workspace_root: AbsPathBuf, ) -> FlycheckHandle { let actor = FlycheckActor::new(id, sender, config, workspace_root); let (sender, receiver) = unbounded::(); let thread = jod_thread::Builder::new() .name("Flycheck".to_owned()) .spawn(move || actor.run(receiver)) .expect("failed to spawn thread"); FlycheckHandle { id, sender, _thread: thread } } /// Schedule a re-start of the cargo check worker. pub fn restart(&self) { self.sender.send(Restart::Yes).unwrap(); } /// Stop this cargo check worker. pub fn cancel(&self) { self.sender.send(Restart::No).unwrap(); } pub fn id(&self) -> usize { self.id } } pub enum Message { /// Request adding a diagnostic with fixes included to a file AddDiagnostic { id: usize, workspace_root: AbsPathBuf, diagnostic: Diagnostic }, /// Request check progress notification to client Progress { /// Flycheck instance ID id: usize, progress: Progress, }, } impl fmt::Debug for Message { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { match self { Message::AddDiagnostic { id, workspace_root, diagnostic } => f .debug_struct("AddDiagnostic") .field("id", id) .field("workspace_root", workspace_root) .field("diagnostic_code", &diagnostic.code.as_ref().map(|it| &it.code)) .finish(), Message::Progress { id, progress } => { f.debug_struct("Progress").field("id", id).field("progress", progress).finish() } } } } #[derive(Debug)] pub enum Progress { DidStart, DidCheckCrate(String), DidFinish(io::Result<()>), DidCancel, DidFailToRestart(String), } enum Restart { Yes, No, } /// A [`FlycheckActor`] is a single check instance of a workspace. struct FlycheckActor { /// The workspace id of this flycheck instance. id: usize, sender: Box, config: FlycheckConfig, /// Either the workspace root of the workspace we are flychecking, /// or the project root of the project. root: AbsPathBuf, /// CargoHandle exists to wrap around the communication needed to be able to /// run `cargo check` without blocking. Currently the Rust standard library /// doesn't provide a way to read sub-process output without blocking, so we /// have to wrap sub-processes output handling in a thread and pass messages /// back over a channel. cargo_handle: Option, } enum Event { Restart(Restart), CheckEvent(Option), } impl FlycheckActor { fn new( id: usize, sender: Box, config: FlycheckConfig, workspace_root: AbsPathBuf, ) -> FlycheckActor { tracing::info!(%id, ?workspace_root, "Spawning flycheck"); FlycheckActor { id, sender, config, root: workspace_root, cargo_handle: None } } fn report_progress(&self, progress: Progress) { self.send(Message::Progress { id: self.id, progress }); } fn next_event(&self, inbox: &Receiver) -> Option { let check_chan = self.cargo_handle.as_ref().map(|cargo| &cargo.receiver); if let Ok(msg) = inbox.try_recv() { // give restarts a preference so check outputs don't block a restart or stop return Some(Event::Restart(msg)); } select! { recv(inbox) -> msg => msg.ok().map(Event::Restart), recv(check_chan.unwrap_or(&never())) -> msg => Some(Event::CheckEvent(msg.ok())), } } fn run(mut self, inbox: Receiver) { 'event: while let Some(event) = self.next_event(&inbox) { match event { Event::Restart(Restart::No) => { self.cancel_check_process(); } Event::Restart(Restart::Yes) => { // Cancel the previously spawned process self.cancel_check_process(); while let Ok(restart) = inbox.recv_timeout(Duration::from_millis(50)) { // restart chained with a stop, so just cancel if let Restart::No = restart { continue 'event; } } let command = self.check_command(); tracing::debug!(?command, "will restart flycheck"); match CargoHandle::spawn(command) { Ok(cargo_handle) => { tracing::debug!( command = ?self.check_command(), "did restart flycheck" ); self.cargo_handle = Some(cargo_handle); self.report_progress(Progress::DidStart); } Err(error) => { self.report_progress(Progress::DidFailToRestart(format!( "Failed to run the following command: {:?} error={}", self.check_command(), error ))); } } } Event::CheckEvent(None) => { tracing::debug!(flycheck_id = self.id, "flycheck finished"); // Watcher finished let cargo_handle = self.cargo_handle.take().unwrap(); let res = cargo_handle.join(); if res.is_err() { tracing::error!( "Flycheck failed to run the following command: {:?}", self.check_command() ); } self.report_progress(Progress::DidFinish(res)); } Event::CheckEvent(Some(message)) => match message { CargoMessage::CompilerArtifact(msg) => { self.report_progress(Progress::DidCheckCrate(msg.target.name)); } CargoMessage::Diagnostic(msg) => { self.send(Message::AddDiagnostic { id: self.id, workspace_root: self.root.clone(), diagnostic: msg, }); } }, } } // If we rerun the thread, we need to discard the previous check results first self.cancel_check_process(); } fn cancel_check_process(&mut self) { if let Some(cargo_handle) = self.cargo_handle.take() { tracing::debug!( command = ?self.check_command(), "did cancel flycheck" ); cargo_handle.cancel(); self.report_progress(Progress::DidCancel); } } fn check_command(&self) -> Command { let (mut cmd, args) = match &self.config { FlycheckConfig::CargoCommand { command, target_triple, no_default_features, all_targets, all_features, extra_args, features, extra_env, } => { let mut cmd = Command::new(toolchain::cargo()); cmd.arg(command); cmd.current_dir(&self.root); cmd.args(&["--workspace", "--message-format=json", "--manifest-path"]) .arg(self.root.join("Cargo.toml").as_os_str()); if let Some(target) = target_triple { cmd.args(&["--target", target.as_str()]); } if *all_targets { cmd.arg("--all-targets"); } if *all_features { cmd.arg("--all-features"); } else { if *no_default_features { cmd.arg("--no-default-features"); } if !features.is_empty() { cmd.arg("--features"); cmd.arg(features.join(" ")); } } cmd.envs(extra_env); (cmd, extra_args) } FlycheckConfig::CustomCommand { command, args, extra_env, invocation_strategy, invocation_location, } => { let mut cmd = Command::new(command); cmd.envs(extra_env); match invocation_location { InvocationLocation::Workspace => { match invocation_strategy { InvocationStrategy::Once => { cmd.current_dir(&self.root); } InvocationStrategy::PerWorkspace => { // FIXME: cmd.current_dir(&affected_workspace); cmd.current_dir(&self.root); } } } InvocationLocation::Root(root) => { cmd.current_dir(root); } } (cmd, args) } }; cmd.args(args); cmd } fn send(&self, check_task: Message) { (self.sender)(check_task); } } struct JodChild(GroupChild); /// A handle to a cargo process used for fly-checking. struct CargoHandle { /// The handle to the actual cargo process. As we cannot cancel directly from with /// a read syscall dropping and therefore terminating the process is our best option. child: JodChild, thread: jod_thread::JoinHandle>, receiver: Receiver, } impl CargoHandle { fn spawn(mut command: Command) -> std::io::Result { command.stdout(Stdio::piped()).stderr(Stdio::piped()).stdin(Stdio::null()); let mut child = command.group_spawn().map(JodChild)?; let stdout = child.0.inner().stdout.take().unwrap(); let stderr = child.0.inner().stderr.take().unwrap(); let (sender, receiver) = unbounded(); let actor = CargoActor::new(sender, stdout, stderr); let thread = jod_thread::Builder::new() .name("CargoHandle".to_owned()) .spawn(move || actor.run()) .expect("failed to spawn thread"); Ok(CargoHandle { child, thread, receiver }) } fn cancel(mut self) { let _ = self.child.0.kill(); let _ = self.child.0.wait(); } fn join(mut self) -> io::Result<()> { let _ = self.child.0.kill(); let exit_status = self.child.0.wait()?; let (read_at_least_one_message, error) = self.thread.join()?; if read_at_least_one_message || exit_status.success() { Ok(()) } else { Err(io::Error::new(io::ErrorKind::Other, format!( "Cargo watcher failed, the command produced no valid metadata (exit code: {:?}):\n{}", exit_status, error ))) } } } struct CargoActor { sender: Sender, stdout: ChildStdout, stderr: ChildStderr, } impl CargoActor { fn new(sender: Sender, stdout: ChildStdout, stderr: ChildStderr) -> CargoActor { CargoActor { sender, stdout, stderr } } fn run(self) -> io::Result<(bool, String)> { // We manually read a line at a time, instead of using serde's // stream deserializers, because the deserializer cannot recover // from an error, resulting in it getting stuck, because we try to // be resilient against failures. // // Because cargo only outputs one JSON object per line, we can // simply skip a line if it doesn't parse, which just ignores any // erroneous output. let mut error = String::new(); let mut read_at_least_one_message = false; let output = streaming_output( self.stdout, self.stderr, &mut |line| { read_at_least_one_message = true; // Try to deserialize a message from Cargo or Rustc. let mut deserializer = serde_json::Deserializer::from_str(line); deserializer.disable_recursion_limit(); if let Ok(message) = JsonMessage::deserialize(&mut deserializer) { match message { // Skip certain kinds of messages to only spend time on what's useful JsonMessage::Cargo(message) => match message { cargo_metadata::Message::CompilerArtifact(artifact) if !artifact.fresh => { self.sender.send(CargoMessage::CompilerArtifact(artifact)).unwrap(); } cargo_metadata::Message::CompilerMessage(msg) => { self.sender.send(CargoMessage::Diagnostic(msg.message)).unwrap(); } _ => (), }, JsonMessage::Rustc(message) => { self.sender.send(CargoMessage::Diagnostic(message)).unwrap(); } } } }, &mut |line| { error.push_str(line); error.push('\n'); }, ); match output { Ok(_) => Ok((read_at_least_one_message, error)), Err(e) => Err(io::Error::new(e.kind(), format!("{:?}: {}", e, error))), } } } enum CargoMessage { CompilerArtifact(cargo_metadata::Artifact), Diagnostic(Diagnostic), } #[derive(Deserialize)] #[serde(untagged)] enum JsonMessage { Cargo(cargo_metadata::Message), Rustc(Diagnostic), }