#![warn(clippy::implicit_clone)] #![allow(clippy::redundant_clone)] use std::borrow::Borrow; use std::ffi::{OsStr, OsString}; use std::path::PathBuf; fn return_owned_from_slice(slice: &[u32]) -> Vec { slice.to_owned() } pub fn own_same(v: T) -> T where T: ToOwned, { v.to_owned() } pub fn own_same_from_ref(v: &T) -> T where T: ToOwned, { v.to_owned() } pub fn own_different(v: T) -> U where T: ToOwned, { v.to_owned() } #[derive(Copy, Clone)] struct Kitten {} impl Kitten { // badly named method fn to_vec(self) -> Kitten { Kitten {} } } impl Borrow for Kitten { fn borrow(&self) -> &BorrowedKitten { static VALUE: BorrowedKitten = BorrowedKitten {}; &VALUE } } struct BorrowedKitten {} impl ToOwned for BorrowedKitten { type Owned = Kitten; fn to_owned(&self) -> Kitten { Kitten {} } } mod weird { #[allow(clippy::ptr_arg)] pub fn to_vec(v: &Vec) -> Vec { v.clone() } } fn main() { let vec = vec![5]; let _ = return_owned_from_slice(&vec); let _ = vec.to_owned(); let _ = vec.to_vec(); let vec_ref = &vec; let _ = return_owned_from_slice(vec_ref); let _ = vec_ref.to_owned(); let _ = vec_ref.to_vec(); // we expect no lint for this let _ = weird::to_vec(&vec); // we expect no lints for this let slice: &[u32] = &[1, 2, 3, 4, 5]; let _ = return_owned_from_slice(slice); let _ = slice.to_owned(); let _ = slice.to_vec(); let str = "hello world".to_string(); let _ = str.to_owned(); // testing w/ an arbitrary type let kitten = Kitten {}; let _ = kitten.to_owned(); let _ = own_same_from_ref(&kitten); // this shouln't lint let _ = kitten.to_vec(); // we expect no lints for this let borrowed = BorrowedKitten {}; let _ = borrowed.to_owned(); let pathbuf = PathBuf::new(); let _ = pathbuf.to_owned(); let _ = pathbuf.to_path_buf(); let os_string = OsString::from("foo"); let _ = os_string.to_owned(); let _ = os_string.to_os_string(); // we expect no lints for this let os_str = OsStr::new("foo"); let _ = os_str.to_owned(); let _ = os_str.to_os_string(); // issue #8227 let pathbuf_ref = &pathbuf; let pathbuf_ref = &pathbuf_ref; let _ = pathbuf_ref.to_owned(); // Don't lint. Returns `&PathBuf` let _ = pathbuf_ref.to_path_buf(); let pathbuf_ref = &pathbuf_ref; let _ = pathbuf_ref.to_owned(); // Don't lint. Returns `&&PathBuf` let _ = pathbuf_ref.to_path_buf(); }