Oliver Schneider
b13d206a22
run rustfmt
2017-02-13 11:18:03 +01:00
f001
b3570db094
update via comments
2017-02-12 20:40:38 +08:00
f001
5a039f68f7
format adjust
2017-02-12 17:24:59 +08:00
f001
98aa0db0ac
Add a lint for slice.iter().cloned().collect()
...
If one uses `slice.iter().cloned().collect()` to create a new `Vec`,
it should be `slice.to_owned()`.
Fix #1292
2017-02-12 17:03:09 +08:00
Oliver Schneider
d198b99472
fix false negatives introduced in the rustup
2017-02-04 16:59:06 +01:00
Mrmaxmeier
d68f0797bf
Rustup to nightly from 2017-01-31
2017-02-03 14:16:14 +01:00
Mrmaxmeier
2216a890a6
TyCtxt::map is now called TyCtxt::hir
2017-02-03 14:16:07 +01:00
Ben Boeckel
2cdba9cd85
methods: fix the option_unwrap_used message
...
It had a hard linewrap in it rather than flowing naturally. This
confused the Vim error matching.
2017-01-30 10:44:52 -05:00
Oliver Schneider
713da45906
apply rustfmt
2017-01-17 19:30:32 +01:00
Andre Bogus
94c97d2ec9
formatting
2017-01-15 01:12:16 +01:00
Andre Bogus
b764b2a7aa
extend or_fun_call lint to cover methods
2017-01-15 00:31:20 +01:00
Andre Bogus
2fdb6e4d1a
deprecate extend_from_slice lint
2017-01-14 14:39:41 +01:00
Oliver Schneider
d944d7df9a
rustup to 2017-01-12
2017-01-13 17:04:56 +01:00
Manish Goregaokar
9a301fd508
Bump to 0.0.106; Fix false positive in wrong_self_convention ( fix #1420 )
2017-01-04 18:05:04 -08:00
Manish Goregaokar
ab42f02003
Rerun rustfmt
2017-01-04 15:53:16 -08:00
Manish Goregaokar
d6dd65620e
Rustup to rustc 1.16.0-nightly ( 468227129 2017-01-03): Fix self type
2017-01-04 15:50:54 -08:00
Manish Goregaokar
571369af1b
Rustup to rustc 1.16.0-nightly ( 468227129 2017-01-03): Borrow and spelling fixes
2017-01-04 15:50:50 -08:00
Manish Goregaokar
e02fac4896
Rustup to rustc 1.16.0-nightly ( 468227129 2017-01-03): Recover patterns from arguments
2017-01-04 15:50:43 -08:00
Josh Holmer
64f5dbc9f8
Rustup to rustc 1.16.0-nightly ( 468227129 2017-01-03): Body fixes for rustup
2017-01-04 15:50:30 -08:00
Manish Goregaokar
f552f170db
Rustup to rustc 1.16.0-nightly ( 468227129 2017-01-03): Fix various type errors for rustup
2017-01-04 15:50:18 -08:00
Oliver Schneider
47eead5ada
function definition style simplification
2016-12-21 12:14:54 +01:00
Oliver Schneider
ed9d71f2c9
remove nondeterminism by adjusting thresholds
2016-12-21 10:25:14 +01:00
Oliver Schneider
44533f09aa
rustfmt round n
2016-12-21 09:45:24 +01:00
Oliver Schneider
4a4e1ea2c5
also run rustfmt on clippy-lints
2016-12-20 18:21:30 +01:00
Oliver Schneider
778ce4dfd3
update to the rust-PR that unblocks clippy
2016-12-07 13:13:40 +01:00
Oliver Schneider
c6e2967b9c
rustup to rustc 1.15.0-dev (3b248a184 2016-12-05)
2016-12-06 11:32:21 +01:00
Oliver Schneider
16aab71688
enum glob use and copies left
2016-12-02 17:38:31 +01:00
Oliver Schneider
59b0077565
WIP compiles and doesn't crash (much) but tests are failing
2016-12-01 22:31:56 +01:00
mcarton
c7e3cc1e27
Rustup to *rustc 1.15.0-nightly ( 3bf2be9ce 2016-11-22)*
2016-11-23 22:44:00 +01:00
mcarton
c35f82b823
Rustup to *rustc 1.15.0-nightly ( 7b3eeea22 2016-11-21)*
2016-11-23 21:31:55 +01:00
Phil Turnbull
8705f3d11c
Remove mention of .push_str(s) being faster
...
For the `.push_str(str.chars())` case the compiler will inline `push_str` and
call `extend_from_slice` on the underlying vector, so this isn't actually
faster.
2016-11-20 17:28:14 -05:00
Phil Turnbull
e9f3911899
Suggest &s instead of s.as_str()
2016-11-20 11:19:36 -05:00
Phil Turnbull
73a73638c0
Add lint for string.extend(string.chars())
...
fixes #792
2016-11-19 14:55:47 -05:00
Phil Turnbull
fa78b09fa7
Add lint for string.extend("str".chars())
...
fixes #792
2016-11-19 14:55:02 -05:00
Phil Turnbull
0ab7e6c598
Factor out lint_vec_extend
2016-11-19 14:44:32 -05:00
mcarton
19c5f5394b
Rustup to rustc 1.15.0-nightly ( 0ed951993 2016-11-14)
2016-11-16 23:05:26 +01:00
Devon Hollowood
e94a4d4666
Fix suggestion in get_unwrap lint
2016-11-02 11:48:16 -07:00
Devon Hollowood
6a14dc7fd4
Remove false positives from get_unwrap lint
...
HashMap and BTreeMap don't implement `IndexMut`, so we shouldn't lint
for use of `get_mut().unwrap()` for those types.
2016-11-01 17:48:32 -07:00
Devon Hollowood
4e0d182d1d
Clean up get_unwrap code
2016-11-01 17:48:18 -07:00
Devon Hollowood
c5e270a1aa
Small fixes for get_unwrap lint
2016-11-01 01:08:38 -07:00
Devon Hollowood
0680ac3562
Add get_unwrap lint
2016-10-31 23:42:33 -07:00
d-dorazio
d213040381
Add lint for redundant pattern matching in iflet for Result/Option
2016-10-30 15:43:46 +01:00
Devon Hollowood
3a0d342a33
Fix false positive for wrong_self_convention
2016-10-27 01:11:34 -07:00
d-dorazio
62831c6e29
Suggest nth(X) instead of skip(X).next()
2016-10-14 13:38:00 +02:00
Andre Bogus
8188c46429
Allow option_map_unwrap_or(_else)
...
This fixes #1192 .
2016-10-02 21:23:26 +02:00
mcarton
5f1120b346
Fix markup in SINGLE_CHAR_PATTERN documentation
2016-09-18 18:27:08 +02:00
mcarton
ab6669a641
Rustup to *rustc 1.13.0-nightly ( f1f40f850 2016-09-09)*
2016-09-10 19:13:49 +02:00
kennytm
5f09020e90
Added a lint_without_lint_pass lint.
...
Four lints were missing from LintPass, making them unavailable unless the
`clippy` lint group is explicitly enabled:
* `for_loop_over_result`
* `for_loop_over_option`
* `match_overlapping_arm`
* `filter_next`
2016-09-01 15:07:37 +08:00
mcarton
189c5e5cfc
Rustup to rustc 1.13.0-nightly ( a23064af5 2016-08-27)
2016-08-28 17:25:58 +02:00
Georg Brandl
ff919376a6
rustup
2016-08-18 21:24:35 +02:00
Oliver Schneider
40720a61e8
rustup for the ! type
2016-08-17 17:58:15 +02:00
llogiq
ce3be22021
Merge pull request #1151 from oli-obk/clone_ref
...
add suggestions to clone_on_copy
2016-08-09 06:30:25 +02:00
Oliver Schneider
49f276ec6f
enable changing wrong_self_convention's lint level at the function level
2016-08-08 17:09:36 +02:00
Oliver Schneider
7e67f447ce
add suggestions to clone_on_copy
...
also:
* don't report clone_on_copy when reporting clone_on_double_ref
* don't suggest `((x))`
2016-08-08 16:43:45 +02:00
Georg Brandl
b91c1a509e
Make lint descriptions short and to the point; always fitting the column "triggers on".
2016-08-07 08:09:26 +02:00
Georg Brandl
3b5ff0f813
Make the lint docstrings more consistent.
2016-08-07 08:06:19 +02:00
Oliver Schneider
81c5757f44
lint on by ref patterns for references
2016-08-01 16:59:14 +02:00
mcarton
caa76e119b
Improve docs
2016-07-16 00:26:54 +02:00
mcarton
557baf253a
Format code for methods lints
2016-07-14 22:56:20 +02:00
mcarton
ea665c38f1
Fix FP with USELESS_VEC and non-copy types
2016-07-14 19:31:17 +02:00
mcarton
8aaaf198e3
Use utils::sugg in methods lints
2016-07-05 23:26:47 +02:00
mcarton
7778f314f2
Merge branch 'master' into sugg
2016-07-04 00:51:19 +02:00
Ben Boeckel
d35b94349c
typo: use commas around "e.g."
2016-07-02 07:59:20 -04:00
mcarton
a3c505551f
Cleanup
2016-07-01 17:12:48 +02:00
Oliver Schneider
799861d7e0
use span_lint_and_then instead of adding to the DiagnosticWrapper
2016-06-27 17:14:04 +02:00
Oliver Schneider
262148c946
update lint doc text
2016-06-22 13:03:59 +02:00
Oliver Schneider
5ccbf3d437
unify the lints
2016-06-22 10:44:46 +02:00
Oliver Schneider
415ddfb630
lint message nits
2016-06-21 14:41:16 +02:00
Oliver Schneider
8bfb31ee97
doc nits
2016-06-21 14:39:56 +02:00
Oliver Schneider
4e52852146
create a lint for each of the messages
2016-06-21 13:04:50 +02:00
Oliver Schneider
69c796e118
lint on filter(x).map(y), filter(x).flat_map(y), filter_map(x).flat_map(y)
2016-06-21 12:29:44 +02:00
Devon Hollowood
0e04153a70
Remove uneccessary, leftover comments in lint_iter_mut()
2016-06-16 14:51:16 -07:00
Devon Hollowood
cfa0c5782e
Extend iter_nth lint to work with iter_mut() and VecDeque
2016-06-16 14:46:29 -07:00
Oliver Schneider
4701f13551
round 1
2016-06-16 12:20:05 +02:00
Devon Hollowood
74025be59d
Make iter_nth work for Vecs too
2016-06-16 02:04:32 -07:00
Devon Hollowood
7764dc5ef4
Add slice_iter_nth lint
2016-06-16 01:36:11 -07:00
mcarton
90453fd893
Run rustfmt
...
Only partially apply suggestions.
2016-06-10 00:08:14 +02:00
mcarton
7bc7c675f2
Cleanup, use matches! some more
2016-06-05 20:46:42 +02:00
Oliver Schneider
bf227f4729
split clippy into lints, plugin and cargo-clippy
2016-05-27 13:03:58 +02:00
