bors
723ac0faf1
Auto merge of #6317 - chansuke:add-external-macro, r=llogiq
...
Add exteranal macros for as_conversions
Added external macros to this PR https://github.com/rust-lang/rust-clippy/pull/4888 .
r? `@llogiq`
changelog: none
2020-11-23 13:26:28 +00:00
flip1995
284c359c61
Fix ICE in utils::implements_trait
...
This only happend when debug_assertions were enabled in rustc
2020-11-23 13:52:27 +01:00
flip1995
d3d2018ead
Merge commit '3e7c6dec244539970b593824334876f8b6ed0b18' into clippyup
2020-11-23 13:51:04 +01:00
Cameron Steffen
a39a93faeb
Disable unnecessary_cast for cfg-dependant types
2020-11-22 19:35:04 -06:00
Cameron Steffen
a8c47440b4
Use article_and_description for missing docs
2020-11-22 17:24:56 -06:00
Lzu Tao
4b698f2069
Drop support for cloudabi targets
2020-11-22 17:11:41 -05:00
bors
3e7c6dec24
Auto merge of #6361 - integer32llc:doc-style, r=carols10cents
...
Small grammar, punctuation, and code style improvements to docs
changelog: Made small grammar, punctuation, and code style improvements to docs
I recently found some places in rust-lang/rust that had lists without spaces after commas, which led me to look for more places, which led me over here to find:
- Some similar lists in code examples that could use spaces after commas to be idiomatic Rust style
- Some lists in documentation text that didn't have spaces after commas, needed an Oxford comma (fight me), or were otherwise misformatted
- Some other grammar improvements in the area of the other changes
These changes should only be in user-facing documentation or output.
2020-11-22 15:34:56 +00:00
Carol (Nichols || Goulding)
445466e567
Apply suggestions from code review to change "that" to "which"
...
Co-authored-by: oliver <16816606+o752d@users.noreply.github.com>
2020-11-22 10:17:34 -05:00
Carol (Nichols || Goulding)
034244f108
Small grammar, punctuation, and code style improvements to docs
2020-11-22 10:17:34 -05:00
bors
831aa9607a
Auto merge of #6363 - o752d:patch-2, r=flip1995
...
a typo
typo
changelog: none
2020-11-22 14:08:01 +00:00
bors
4284ec3859
Auto merge of #6364 - o752d:master, r=flip1995
...
revisiting a typo
changelog: none
2020-11-22 13:48:02 +00:00
oliver
e30bb7661d
update
2020-11-22 00:50:09 -04:00
oliver
9b910e19ce
a typo
...
typo
2020-11-22 04:44:47 +00:00
Jonas Schievink
1464dcedfb
Thread Constness through selection
2020-11-22 02:13:53 +01:00
bors
0402c6ace7
Auto merge of #6354 - Daniel-B-Smith:refcell_ref_await, r=flip1995
...
Downgrade the await holding lints from correctness
We found a false positive in these lints (see https://github.com/rust-lang/rust-clippy/issues/6353 for more details). As a short-term mitigation, this downgrades the lints from correctness to limit the noise.
changelog: downgrade AWAIT_HOLDING_REFCELL_REF and AWAIT_HOLDING_LOCK to pedantic. From rustup earlier, where I forgot the changlog: deprecate [`panic_params`] (uplifted)
2020-11-20 16:51:41 +00:00
Daniel Smith
8b21241fd5
Revert "Convert the await holding lints to correctness"
...
This reverts commit d8c6bce440
2020-11-20 11:44:26 -05:00
bors
70ffebf5f0
Auto merge of #6347 - flip1995:changelog, r=Manishearth
...
Changelog Rust 1.48
[Rendered](https://github.com/flip1995/rust-clippy/blob/changelog/CHANGELOG.md )
This changelog is **big**. Hacktoberfest was pretty good for us, even though we had too few reviewers.
changelog: none
2020-11-20 09:58:55 +00:00
bors
8325d48d2d
Auto merge of #6351 - flip1995:rustup, r=flip1995
...
Rustup
r? `@ghost`
changelog: none
2020-11-20 09:07:56 +00:00
flip1995
5ee0a400fc
Fix dogfood errors
2020-11-20 10:06:26 +01:00
flip1995
dd4e471b3f
Properly deprecate panic_params lint
2020-11-20 09:37:47 +01:00
Mara Bos
113c1476c9
Clippy: Match on assert!() expansions without an inner block.
2020-11-19 19:47:25 +01:00
Mara Bos
78faaef8de
Remove the clippy::panic-params lint.
...
Rustc itself now warns for all cases that triggered this lint.
2020-11-19 18:34:40 +01:00
flip1995
e9afdf0740
Improve changlog update documentation
2020-11-19 11:23:59 +01:00
flip1995
a98acdba3e
Fix trailing whitespaces in CHANGELOG file
2020-11-19 11:23:28 +01:00
flip1995
4bf58bd55d
Add CHANGELOG for 1.48
2020-11-19 11:22:59 +01:00
bors
b2aefb8cc3
Auto merge of #6345 - giraffate:follow_up_of_rustup, r=flip1995
...
Revert "Add `rustfmt::skip` as a work around"
This reverts commit 0e803417f9https://github.com/rust-lang/rustfmt/issues/4528 .
changelog: none
2020-11-19 07:40:14 +00:00
Mara Bos
577ebc8cd6
Rollup merge of #79145 - camelid:clippy-fix-panics, r=flip1995
...
Fix handling of panic calls
This should make Clippy more resilient and will unblock #78343 .
This PR is made against rust-lang/rust to avoid the need for a subtree
sync at ``@flip1995's`` suggestion in rust-lang/rust-clippy#6310 .
r? ``@flip1995``
cc ``@m-ou-se``
2020-11-18 15:46:36 +01:00
Takayuki Nakata
6494bd0bac
Revert "Add rustfmt::skip as a work around"
...
This reverts commit 0e803417f9https://github.com/rust-lang/rustfmt/issues/4528 .
2020-11-18 12:36:47 +09:00
bors
8c2e2fd4ec
Auto merge of #6340 - giraffate:improve_doc_for_map_clone, r=Manishearth
...
Improve doc about `map_clone`
A follow up of https://github.com/rust-lang/rust-clippy/issues/6239#issuecomment-719100677 .
`map_clone` works with not only `Iterator` but `Option` although not written in [doc](https://rust-lang.github.io/rust-clippy/master/#map_clone ). Also, an example in the doc shows a usage of dereferencing, but this isn't also written.
changelog: Improve doc about `map_clone`
2020-11-18 02:49:29 +00:00
Takayuki Nakata
0502ac2a87
Improve doc about map_clone
2020-11-18 08:33:25 +09:00
Christiaan Dirkx
5a83968877
Change redundant_pattern_matching to also lint std::task::Poll
...
Suggest using utility methods `is_pending` and `is_ready`.
2020-11-17 23:40:31 +01:00
bors
44d944586c
Auto merge of #6070 - matsujika:unnecessary_wrap, r=flip1995
...
Add new lint `unnecessary_wrap`
Fixes #5969
changelog: New lint [`unnecessary_wraps`]
2020-11-17 20:28:32 +00:00
Camelid
4e4c4fb8aa
Fix handling of panic calls
...
This should make Clippy more resilient and will unblock #78343 .
This PR is made against rust-lang/rust to avoid the need for a subtree
sync at @flip1995's suggestion in rust-lang/rust-clippy#6310 .
2020-11-17 12:16:15 -08:00
bors
5464cbed2f
Auto merge of #6337 - ThibsG:FixIce6332, r=Manishearth
...
Remove `expect()` calls to avoid ICEs in `deref_addrof` lint
Fixes : #6332
changelog: none
2020-11-17 17:55:46 +00:00
bors
a8cafc6196
Auto merge of #6338 - flip1995:rustup, r=flip1995
...
Rustup
r? `@ghost`
changelog: none
2020-11-17 17:10:04 +00:00
flip1995
bf2d31d053
Run cargo dev fmt
2020-11-17 18:08:12 +01:00
Hirochika Matsumoto
c7445d7f2c
Pluralize lint name
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
1f577c0300
Fix embarrassing grammatical error
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
4e5c02e898
Ignore trait implementations
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
4c8d248190
Update stderr files
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
86331a46e4
Update stderr files
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
bf46f78ca7
Fix clippy error
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
532d205218
Skip functions in PartialOrd
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
9d96311d73
Remove wildcard use
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
e998d61fe6
Downgrade applicability to MaybeIncorrect
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
30632fb8e6
Allow this lint on lint tests
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
c7692cf749
Skip function with no exprs contained
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
c5447eb3c1
Make lint skip macros
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
12474c62ff
Add support for methods
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
2f85aa736e
Make lint skip closures
2020-11-18 01:28:37 +09:00
