10924: minor: Add LICENSE file to make vsce happy r=lnicola a=lnicola
Newer `vsce` versions error out if a `LICENSE` file is missing, even if the license is specified in `package.json`. Concatenate the two licenses we use and add a file with that to make a future `vsce` upgrade easier.
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
10906: [first contributation] fix: `add return type` assit works when there's missing whitespace r=Veykril a=izik1
I feel like the way I handled whitespace here isn't... Right? Maybe it should be folded into `InsertOrReplace::Insert`
Also, sorry about the commit name, I am _not_ good at writing user facing commit messages
Also sorry about the test names, could be clearer I feel
Co-authored-by: Skyler Rain Ross <orangesnowfox@gmail.com>
10891: fix: emit trait names in moniker identifier r=Veykril a=tjdevries
Hi,
Not sure if this is the best fix for the problem, but I noticed that functions that part of a trait are not namespaced with the trait name, so this could lead to problems if you had a function and a trait-function both defined in the same module.
Thanks!
TJ
Co-authored-by: TJ DeVries <devries.timothyj@gmail.com>
10899: ide: hack to make self not unresolved reference in async trait wrapped impl's r=Veykril a=jhgg
fixes#10708
this is a bit hacky, but it "works".
i'm not sure how to even write a test for this though, but i've confirmed it works via manual testing...
Co-authored-by: Jake Heinz <jh@discordapp.com>
10897: internal: Try to fix Code tests r=lnicola a=lnicola
It looks like `--noEmit` broke our unit tests:
r? `@ChayimFriedman2`
I suppose we might still:
- compile stuff twice
- not detect failing tests on CI (since we didn't notice this)
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
